January 2017 - Wine-devel - list.winehq.org

Re: [PATCH] riched20: Check for NULL in fnTextSrv_TxSetText and add test
by Nikolay Sivov 02 Jan '17

02 Jan '17

On 02.01.2017 23:19, Fabian Maurer wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=12185 > > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/riched20/tests/txtsrv.c | 3 +++ > dlls/riched20/txtsrv.c | 7 +++---- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/dlls/riched20/tests/txtsrv.c b/dlls/riched20/tests/txtsrv.c > index 1a6ca61052..6fd77d1b59 100644 > --- a/dlls/riched20/tests/txtsrv.c > +++ b/dlls/riched20/tests/txtsrv.c > @@ -681,6 +681,9 @@ static void test_TxSetText(void) > ok(memcmp(rettext,settext,SysStringByteLen(rettext)) == 0, > "String returned differs\n"); > > + /* Test if we crash when using NULL as text */ > + ITextServices_TxSetText(txtserv, NULL); > + > SysFreeString(rettext); > ITextServices_Release(txtserv); > ITextHost_Release(host); It's important to test if NULL text actually discards existing content or just does nothing. > diff --git a/dlls/riched20/txtsrv.c b/dlls/riched20/txtsrv.c > index 3df779834b..307b484352 100644 > --- a/dlls/riched20/txtsrv.c > +++ b/dlls/riched20/txtsrv.c > @@ -286,10 +286,9 @@ DECLSPEC_HIDDEN HRESULT WINAPI fnTextSrv_TxSetText(ITextServices *iface, LPCWSTR > ME_Cursor cursor; > > ME_SetCursorToStart(This->editor, &cursor); > - ME_InternalDeleteText(This->editor, &cursor, > - ME_GetTextLength(This->editor), FALSE); > - ME_InsertTextFromCursor(This->editor, 0, pszText, -1, > - This->editor->pBuffer->pDefaultStyle); > + ME_InternalDeleteText(This->editor, &cursor, ME_GetTextLength(This->editor), FALSE); > + if(pszText) > + ME_InsertTextFromCursor(This->editor, 0, pszText, -1, This->editor->pBuffer->pDefaultStyle); > ME_SetSelection(This->editor, 0, 0); > This->editor->nModifyStep = 0; > OleFlushClipboard(); Maybe it's better to add a check to ME_InsertTextFromCursor?

2 1

Starting wine virtual desktop minimized
by Austin English 02 Jan '17

02 Jan '17

Howdy, I'm looking for a way to start a virtual desktop and have it be minimized, similar to: wine start /min notepad But for the desktop itself. My goal is to be able to run winetest/winetricks-test/etc. with minimal graphical interface if I'm using the machine myself. Thanks and happy new year!

2 4

Re: [Patch] wined3d Add Turks HD6600 Binary driver
by Henri Verbeet 02 Jan '17

02 Jan '17

On 29 December 2016 at 12:07, Jarkko Korpi <jarkko_korpi(a)hotmail.com> wrote: > This is a regression fix. > What regression is that? If it's bug 38216, that was pretty much abandoned in early 2015. It was later reopened, but I don't see that bug report going anywhere without input from the original reporter. In fact, it's not all that clear whether the original issue still exists since commit 1df961bd3d1a5d4d4badfe364ca51e9f6cc88fd3.

1 0

Re: [PATCH] user32/tests: Added some tests for FindWindow()
by Marvin 02 Jan '17

02 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27514 Your paranoid android. === w864 (32 bit win) === win.c:2305: Test failed: expected !100 win.c:2305: Test failed: expected !100 === w864 (64 bit win) === win.c:2305: Test failed: expected !100 win.c:2305: Test failed: expected !100

1 0