February 2017 - Wine-devel - list.winehq.org

wine-1.8.7-rc2 Available
by Michael Stefaniuc 15 Feb '17

15 Feb '17

Hello guys, wine-1.8.7-rc2 is now available, including the tag: https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ Changes to rc1: - Removed commit "winex11.drv: Added ThreadDetach entry point and use it instead of DllMain." as it needs a dependency not suitable for Stable. - Added Turkish translations. Thanks to Can Taşan for dealing with the fallout of msgmerge'ing the tr.po from wine-2.0. bye michael

1 0

Re: [PATCH 3/7] ddraw: Fix IDirectDraw_CreateSurface's invalid descriptor error code.
by Henri Verbeet 15 Feb '17

15 Feb '17

On 15 February 2017 at 07:53, Alex Henrie <alexhenrie24(a)gmail.com> wrote: > @@ -3000,7 +3000,7 @@ static HRESULT WINAPI ddraw1_CreateSurface(IDirectDraw *iface, > { > WARN("Application supplied invalid surface descriptor\n"); > wined3d_mutex_unlock(); > - return DDERR_INVALIDPARAMS; > + return E_INVALIDARG; Did you verify the test fails without this change? How is DDERR_INVALIDPARAMS defined?

3 2

Re: winedevice: Use WINE_RB_FOR_EACH_ENTRY_DESTRUCTOR to free drivers in async_shutdown_drivers.
by Sebastian Lackner 15 Feb '17

15 Feb '17

On 15.02.2017 16:47, Jacek Caban wrote: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > programs/winedevice/device.c | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) This isn't really a noop, the previous code also cleared tree->root.

2 1

Re: [PATCH 13/14] rbtree.h: Added WINE_RB_FOR_EACH_DESTRUCTOR and WINE_RB_FOR_EACH_ENTRY_DESTRUCTOR helpers for implementing tree destructors.
by Matteo Bruni 15 Feb '17

15 Feb '17

2017-02-13 21:12 GMT+01:00 Jacek Caban <jacek(a)codeweavers.com>: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > include/wine/rbtree.h | 20 ++++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-) These sound like the _SAFE variants of our list implementation. Any reason not to use the same naming here?

2 3

Re: [PATCH 1/7] ddraw/tests: Test IDirectDraw4_CreateSurface without cooperative level.
by Henri Verbeet 15 Feb '17

15 Feb '17

On 15 February 2017 at 07:53, Alex Henrie <alexhenrie24(a)gmail.com> wrote: > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/ddraw/tests/ddraw4.c | 6 ++++++ > 1 file changed, 6 insertions(+) > I think this belongs in test_coop_level_surf_create().

1 0

Re: [PATCH 2/8] wined3d: Honor buffer ranges for shader resource views.
by Matteo Bruni 15 Feb '17

15 Feb '17

2017-02-14 13:15 GMT+01:00 Józef Kucia <jkucia(a)codeweavers.com>: > > context_bind_texture(context, GL_TEXTURE_BUFFER, view->name); > - GL_EXTCALL(glTexBuffer(GL_TEXTURE_BUFFER, view_format->glInternal, buffer->buffer_object)); > + if (gl_info->supported[ARB_TEXTURE_BUFFER_RANGE]) > + { > + GL_EXTCALL(glTexBufferRange(GL_TEXTURE_BUFFER, view_format->glInternal, > + buffer->buffer_object, offset, size)); > + } > + else > + { > + if (!offset || size != buffer->resource.size) > + FIXME("OpenGL implementation does not support ARB_texture_buffer_range.\n"); > + GL_EXTCALL(glTexBuffer(GL_TEXTURE_BUFFER, view_format->glInternal, buffer->buffer_object)); > + } I think you want the FIXME if offset is non-zero.

2 1

Re: wine.inf: Add Dynamic DST/{First,Last}Entry registry keys
by Piotr Caban 15 Feb '17

15 Feb '17

On 02/14/17 22:54, Sebastian Lackner wrote: > Is it actually used by apps? If yes, I hope it doesn't cause problems > that we store them in "sparse" format (sometimes years are missing inbetween, > when they match the information in the parent registry key). It's used by mono. Without this patch it crashes in some timezone related functions. I've grepped mono source and the "Dynamic DST" keys are used in 3 places. None of them is correctly handling the missing entries (one returns error on missing entry, others define adjustment rules only for specified years). Thanks, Piotr

1 0

Re: [PATCH 6/7] ddraw: Fix IDirectDraw7_CreateSurface's invalid descriptor error code.
by Marvin 15 Feb '17

15 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28636 Your paranoid android. === w864 (64 bit ddraw7) === The test timed out

1 0

Re: [PATCH] ddraw: Avoid break in __TRY blocks.
by Sebastian Lackner 15 Feb '17

15 Feb '17

On 14.02.2017 22:56, Stefan Dösinger wrote: > This fixes compilation on Visual Studio with native compiler exceptions. > > Signed-off-by: Stefan Dösinger <stefandoesinger(a)gmx.at> While you are just at it, please note that this code also contains a leak when the exception is triggered. Actually, it would probably be easier to test if the pointer is writeable in advance, and exit early without creating the surface at all. > --- > dlls/ddraw/ddraw.c | 36 ++++++++++++++++++++++-------------- > 1 file changed, 22 insertions(+), 14 deletions(-) > > diff --git a/dlls/ddraw/ddraw.c b/dlls/ddraw/ddraw.c > index 254dae7..54f3817 100644 > --- a/dlls/ddraw/ddraw.c > +++ b/dlls/ddraw/ddraw.c > @@ -2836,11 +2836,13 @@ static HRESULT WINAPI ddraw7_CreateSurface(IDirectDraw7 *iface, DDSURFACEDESC2 * > if (FAILED(hr)) > { > *surface = NULL; > - break; > } > - *surface = &impl->IDirectDrawSurface7_iface; > - IDirectDraw7_AddRef(iface); > - impl->ifaceToRelease = (IUnknown *)iface; > + else > + { > + *surface = &impl->IDirectDrawSurface7_iface; > + IDirectDraw7_AddRef(iface); > + impl->ifaceToRelease = (IUnknown *)iface; > + } > } > __EXCEPT_PAGE_FAULT > { > @@ -2898,11 +2900,13 @@ static HRESULT WINAPI ddraw4_CreateSurface(IDirectDraw4 *iface, > if (FAILED(hr)) > { > *surface = NULL; > - break; > } > - *surface = &impl->IDirectDrawSurface4_iface; > - IDirectDraw4_AddRef(iface); > - impl->ifaceToRelease = (IUnknown *)iface; > + else > + { > + *surface = &impl->IDirectDrawSurface4_iface; > + IDirectDraw4_AddRef(iface); > + impl->ifaceToRelease = (IUnknown *)iface; > + } > } > __EXCEPT_PAGE_FAULT > { > @@ -2962,10 +2966,12 @@ static HRESULT WINAPI ddraw2_CreateSurface(IDirectDraw2 *iface, > if (FAILED(hr)) > { > *surface = NULL; > - break; > } > - *surface = &impl->IDirectDrawSurface_iface; > - impl->ifaceToRelease = NULL; > + else > + { > + *surface = &impl->IDirectDrawSurface_iface; > + impl->ifaceToRelease = NULL; > + } > } > __EXCEPT_PAGE_FAULT > { > @@ -3022,10 +3028,12 @@ static HRESULT WINAPI ddraw1_CreateSurface(IDirectDraw *iface, > if (FAILED(hr)) > { > *surface = NULL; > - break; > } > - *surface = &impl->IDirectDrawSurface_iface; > - impl->ifaceToRelease = NULL; > + else > + { > + *surface = &impl->IDirectDrawSurface_iface; > + impl->ifaceToRelease = NULL; > + } > } > __EXCEPT_PAGE_FAULT > { >

3 4

Re: [PATCH 2/3] dpnet: Add basic validation in IDirectPlay8Peer EnumHosts
by Marvin 15 Feb '17

15 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28626 Your paranoid android. === wvistau64 (64 bit client) === client.c:645: Test failed: got 0x80004005

1 0