February 2017 - Wine-devel - list.winehq.org

Re: ntoskrnl.exe: add KeAcquireInStackQueuedSpinLock stub (resend)
by Austin English 07 Feb '17

07 Feb '17

Sorry, please ignore this one, I missed Sebastian's previous feedback. On Mon, Feb 6, 2017 at 5:12 PM, Austin English <austinenglish(a)gmail.com> wrote: > For https://bugs.winehq.org/show_bug.cgi?id=41472 > > -- > -Austin > GPG: 14FB D7EA A041 937B -- -Austin GPG: 14FB D7EA A041 937B

1 0

Re: [PATCH 2/4] shell32: Implement IShellImageData::Decode() when created from file path
by Alexandre Julliard 07 Feb '17

07 Feb '17

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -29,9 +29,17 @@ cpp_quote("#endif") > > cpp_quote("#ifndef _GDIPLUSHEADERS_H") > typedef BYTE EncoderParameters; > +cpp_quote("#endif") > + > +/* Wine does not define GDI+ class wrappers */ > +cpp_quote("#if defined(__WINESRC__) || !defined(_GDIPLUSHEADERS_H)") > typedef BYTE Image; > cpp_quote("#endif") We don't have C++ code in the Wine source, so I don't see why you'd need that. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH 1/4] shell32: Added IShellImageData stub
by Alex Henrie 07 Feb '17

07 Feb '17

+static inline LPWSTR strdupW( LPCWSTR src ) +{ + LPWSTR dest; + if (!src) return NULL; + dest = HeapAlloc( GetProcessHeap(), 0, (lstrlenW(src)+1)*sizeof(WCHAR) ); + if (dest) + lstrcpyW(dest, src); + return dest; +} I submitted a similar patch months ago and was told that I had to change LPWSTR to WCHAR * and consistently indent or not indent after these two if statements. -Alex

2 1

Re: [v4 2/3] ntdll: Implement FileIdInformation class support in NtQueryInformationFile.
by Marvin 07 Feb '17

07 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28380 Your paranoid android. === wxppro (32 bit file) === file.c:1473: Test failed: can't get fid1, res c0000003 file.c:1479: Test failed: CreateFile error 2 file.c:1484: Test failed: can't get fid2, res c0000003 file.c:1496: Test failed: can't get new fid2, res c0000003 file.c:1499: Test failed: file id is not unique === w2003std (32 bit file) === file.c:1473: Test failed: can't get fid1, res c0000003 file.c:1479: Test failed: CreateFile error 2 file.c:1484: Test failed: can't get fid2, res c0000003 file.c:1496: Test failed: can't get new fid2, res c0000003 file.c:1499: Test failed: file id is not unique === wvistau64 (32 bit file) === file.c:1473: Test failed: can't get fid1, res c0000002 file.c:1479: Test failed: CreateFile error 2 file.c:1484: Test failed: can't get fid2, res c0000002 file.c:1496: Test failed: can't get new fid2, res c0000002 file.c:1499: Test failed: file id is not unique === w2008s64 (32 bit file) === file.c:1473: Test failed: can't get fid1, res c0000002 file.c:1479: Test failed: CreateFile error 2 file.c:1484: Test failed: can't get fid2, res c0000002 file.c:1496: Test failed: can't get new fid2, res c0000002 file.c:1499: Test failed: file id is not unique === w7u (32 bit file) === file.c:1473: Test failed: can't get fid1, res c0000003 file.c:1479: Test failed: CreateFile error 2 file.c:1484: Test failed: can't get fid2, res c0000003 file.c:1496: Test failed: can't get new fid2, res c0000003 file.c:1499: Test failed: file id is not unique === w7pro64 (32 bit file) === file.c:1473: Test failed: can't get fid1, res c0000002 file.c:1479: Test failed: CreateFile error 2 file.c:1484: Test failed: can't get fid2, res c0000002 file.c:1496: Test failed: can't get new fid2, res c0000002 file.c:1499: Test failed: file id is not unique === wvistau64 (64 bit file) === file.c:1473: Test failed: can't get fid1, res c0000003 file.c:1479: Test failed: CreateFile error 2 file.c:1484: Test failed: can't get fid2, res c0000003 file.c:1496: Test failed: can't get new fid2, res c0000003 file.c:1499: Test failed: file id is not unique === w2008s64 (64 bit file) === file.c:1473: Test failed: can't get fid1, res c0000003 file.c:1479: Test failed: CreateFile error 2 file.c:1484: Test failed: can't get fid2, res c0000003 file.c:1496: Test failed: can't get new fid2, res c0000003 file.c:1499: Test failed: file id is not unique === w7pro64 (64 bit file) === file.c:1473: Test failed: can't get fid1, res c0000003 file.c:1479: Test failed: CreateFile error 2 file.c:1484: Test failed: can't get fid2, res c0000003 file.c:1496: Test failed: can't get new fid2, res c0000003 file.c:1499: Test failed: file id is not unique

1 0

Re: dinput: Give correct count of devices still to be enumerated.
by Andrew Eikum 07 Feb '17

07 Feb '17

Thanks for working on this. The logic looks good, just some small comments in-line below. On Sat, Feb 04, 2017 at 03:35:10PM +0200, Jetro Jormalainen wrote: > diff --git a/dlls/dinput/dinput_main.c b/dlls/dinput/dinput_main.c > index 06af92f9b2..05651c9ced 100644 > --- a/dlls/dinput/dinput_main.c > +++ b/dlls/dinput/dinput_main.c > @@ -930,7 +930,8 @@ static HRESULT WINAPI IDirectInput8AImpl_EnumDevicesBySemantics( > LPDIRECTINPUTDEVICE8A lpdid; > DWORD callbackFlags; > int i, j; > - > + int c = 0; Please use a more descriptive variable name, like "count" or "total" or something. > + for (i=0; i < c; i++) > + { > + unsigned remain = c - (i+1) + ((dwFlags & DIEDBSFL_FORCEFEEDBACK) ? 0 : sizeof(guids)/sizeof(guids[0])); Please consistently use spaces around operators. If you wanted to make that line a little less ugly, you could assign "remain" before the loop and decrement it each iteration. > + callbackFlags = diactionformat_priorityA(lpdiActionFormat, lpdiActionFormat->dwGenre); > + IDirectInput_CreateDevice(iface, &didevis[i].guidInstance, &lpdid, NULL); > + > + if (lpCallback(&didevis[i], lpdid, callbackFlags, remain, pvRef) == DIENUM_STOP) > + { > + HeapFree(GetProcessHeap(), 0, (void*) didevis); > + return DI_OK; > + } > + } > + > + HeapFree(GetProcessHeap(), 0, (void*) didevis); > + There's no need for the explicit cast in HeapFree. All of the above also applies to the W-version, obviously. > + if (!data->device_count) { > + data->first_remaining = dwRemaining; > + } > + ok (dwRemaining == data->first_remaining - data->device_count, > + "enum semantics remaining devices is wrong, expected %d, had %d", > + data->first_remaining - data->device_count, dwRemaining); This ok() needs a newline at the end. Andrew

1 0

Re: [PATCH 01/2] dpnet/test: Share code between tests (resend)
by Erich E. Hoover 07 Feb '17

07 Feb '17

On Mon, Jan 30, 2017 at 12:05 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/dpnet/tests/address.c | 28 +------- > dlls/dpnet/tests/client.c | 150 +-------------------------------------- > dlls/dpnet/tests/dpnet_private.h | 32 +++++++++ > dlls/dpnet/tests/server.c | 16 ++--- > ... I have never seen a "*_private.h" header in any of the other tests, though there are a small number of "*_test.h" headers. This instance might be _especially_ confusing since it would result in both a "./dlls/dpnet/dpnet_private.h" and a "./dlls/dpnet/tests/dpnet_private.h". The second patch looks reasonable to me, though you may wish for others to weigh in. Best, Erich

2 2

wine-1.8.7-rc1 Available
by Michael Stefaniuc 07 Feb '17

07 Feb '17

Hello guys, I have pushed wine-1.8.7-rc1 (with tag) to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ This will be the final release in the 1.8.x series. For the release I would follow the same process: one week for feedback followed by another rc if needed with the final release 3-4 days later. And now the interesting parts from the ANNOUNCE file: What's new in this release (see below for details): - Various bug fixes. - A few more cards added to the GPU description table. ---------------------------------------------------------------- Bugs fixed in 1.8.7 (total 39): 11808 winefile: broken horizontal scrolling 17196 Text Editor Cursor can be scrolled outside editor 19862 CodeCreatures crashes. 30355 DVDSubEdit 1.52 crashes on startup, broken TBM_SETRANGEMAX handling 30385 Multiple applications need support for shell32.SHGetKnownFolderPath KF_FLAG_DEFAULT_PATH option (Windows Live Essentials 2011 web installer, MediaMonkey 4.1.x in Vista+ mode) 31222 Hitman: Blood Money crashes when changing screen resolution 32682 Multiple .NET 4.0 applications fail to load the pen cursor (IDC_PEN, 32631, 0x7F77 missing) 33859 Visual Web Developer Express 2008 crashes when clicking "Browse" (bug in PropertySheet common control) 34127 FIFA 2000 demo crashes after 'Press Any Key' 34465 process hacker 2.31 crashes in toolbar code 35495 sharing violation and prompt for copy /B file1+file2 file1 37762 Runaway & Runaway 2: wrong colors 38207 Unreal Tournament 3 uninstaller fails when invoking from 'wine uninstaller' (removes wrong entries) 39268 x11drv: Can't store handle for display fd 39509 OneDrive for Business installer crashes in Win8 mode (user32.dll 'SetCoalescableTimer' stub missing) 39661 Font width incorrect in wineconsole 39714 Halo some sounds in cut scenes don't play 40112 kernel32:time regression 40243 Korg Nano editor USB MIDI driver won't install, requires Administrator Privileges 40247 Wine returns the loopback IP as first item in GetIpAddrTable causing some licensed programs to fail due to invalid MAC address 40845 Uninstaller does not remove missing applications from the list 40978 Wrong colors on i915 and similar GPUs in GTA Vice City 41001 64-bit Core Temp 1.x kernel driver 'ALSysIO.sys' crashes on unimplemented function ntoskrnl.exe.RtlUnwindEx 41055 "Texture ... does not have a drawable" on i915 with D3D8 41141 gcc6: d3drm build warnings 41218 curl 7.50: HTTPS fails with InitializeSecurityContext failed: SEC_E_INVALID_TOKEN 41252 Helldivers gives this error when trying to run on MacOS 41476 Cannot paste in WinAuth 3.5.1 (32-bit) 41508 Menu infinitely loops, the application hangs. 41572 Windows API crash (GetTimeZoneInformationForYear) 41599 Battle.net and Hearthstone play loud static when receiving messages 41732 wineconsole: changing to emacs mode requires restart 41733 wineconsole: crashes in emacs mode when pasting (Ctrl+Y) empty buffer 41898 ToCA Race Driver 3 needs ntoskrnl.exe.RtlCopyMemory 41909 Calling TBM_SETPOS after TBM_SETRANGEMIN/TBM_SETRANGEMAX does not draw slider control properly 42090 Highway Pursuit constantly emits loud noise when sound effects enabled 42110 regression: commit "xinput1_3 prefer builtin dll" aliens versus predator classic 2000 (steam) fails to launch 42187 Radeon R9 285 GPU incorrectly recognized 42211 redefinition of typedef 'REFERENCE_TIME' ---------------------------------------------------------------- Changes since 1.8.6: Adam Bolte (1): wined3d: Add GPU information for AMD FIJI. Alex Henrie (1): user32: Tell MENU_SuspendPopup which message to remove. Alexandre Julliard (3): winex11: Also ignore BadWindow errors caused by XSendEvent. wineconsole: Leave room for wide characters only when using a DBCS codepage. Update copyright info for 2017. Andrew Eikum (5): user32: Support IDC_PEN. dsound: Handle default case in dsound3d mode switch (Coverity). dsound: Use the value from SetVolume when 3D processing is disabled. msacm32: Support conversion from 24-bit PCM. dsound: Fix rolloff factor calculation. Austin English (1): ntoskrnl.exe: Forward RtlUnwindEx to ntdll. Brock York (1): msctf: Remove incorrect dereference of double pointer. Bruno Jesus (1): iphlpapi: Ensure GetIpAddrTable returns loopback addresses in the end. Carlos Rodriguez (1): wined3d: Recognize Geforce GTX 1050. Henri Verbeet (4): wined3d: Properly check for the required extensions before selecting the GLSL FFP implementations. d3drm: Introduce d3drm_set_color(). wined3d: Add GPU information for AMD TONGA. wine.inf: Add Dynamic DST data for Asia/Tehran. Hugh McMaster (4): kernel32: Check for a valid pointer before yanking the line. kernel32: Use Emacs keymap mode immediately after wineconsole configuration change. appwiz.cpl: Remove list entries left over from an earlier uninstall. appwiz.cpl: Do not overwrite application IDs when changing registry keys. Jacek Caban (2): winex11.drv: Added ThreadDetach entry point and use it instead of DllMain. secur32: Don't change input buffer in InitializeSecurityContext. Jarkko Korpi (2): wined3d: Add Amd Rx 480 binary driver. winex11.drv: Add 640x400 mode to virtual desktop. Józef Kucia (5): wined3d: Update "screen_format" when ChangeDisplaySettingsEx() call is redundant. d3d8/tests: Add more tests for UnlockRect(). d3d8: Return D3D_OK from UnlockRect() for not locked textures. d3d9/tests: Add test showing WM_SIZE is not sent during fullscreen mode change. wined3d: Filter messages for fullscreen mode changes. Lauri Kenttä (3): user32: Fix caret disappearing after scrolling. cmd: Fix copying when the dest is one of the sources. winefile: Fix horizontal scrolling. Louis Lenders (1): wine.inf: Add Drivers32 registry key. Matteo Bruni (3): wined3d: Also check BLENDWEIGHT for immediate mode fallback. d3d9/tests: Add a vertex blending test with D3DCOLOR weights. wined3d: Swizzle D3DCOLOR attributes in the GLSL FFP replacement when necessary. Michael Cronenworth (1): wined3d: Add Iris Haswell PCI ids and descriptions. Michael Stefaniuc (1): include: Make wine_dbgstr_rect() available for tests too. Nikolay Sivov (8): ntoskrnl: Added RtlCopyMemory() export. shell32: Move retrieving folder path logic to SHGetKnownFolderPath(). shell32: Don't access uninitialized buffer (Coverity). comctl32/tests: Trackbar test to show that thumb is updated on TBM_SETTICFREQ. comctl32/trackbar: Update thumb unconditionally on TBM_SETTICFREQ. comctl32/trackbar: Fix TBM_SETRANGEMAX handling when new limit is less than current min boundary. comctl32/toolbar: Protect from NULL pointer access in TB_GETBUTTONINFOW handler. comctl32/propsheet: Double size of a template buffer passed to PSCB_PRECREATE. Olivier F. R. Dierick (1): xinput1_3: Add DECLSPEC_HOTPATCH to XInputEnable() definition. Piotr Caban (1): user32: Test error returned in out of timers case. Sebastian Lackner (2): include: Avoid duplicate definition of REFERENCE_TIME. user32: Implement SetCoalescableTimer and add basic tests. Stefan Dösinger (1): d3d8/tests: Test invalid locks with textures. VRan Liu (1): shell32/tests: Simple test for KF_FLAG_DEFAULT_PATH. Vincent Povirk (3): kernel32/tests: Add tests for GetTimeZoneInformationForYear. kernel32: Implement GetTimeZoneInformationForYear. kernel32/tests: Avoid testing for a hard-coded timezone name. -- Michael Stefaniuc mstefani(a)winehq.org

2 2

Re: [PATCH v2 1/2] msvcrt/tests: Add tests for _creat.
by Piotr Caban 07 Feb '17

07 Feb '17

Hi, please fix the implementation in first patch and then add test in second. Currently the tests are using garbage data from stack causing random failures: file.c:2419: Test failed: expected read-only file file.c:2441: Test succeeded inside todo block: expected rw file Thanks, Piotr

2 1

Re: [PATCH] winejoystick.drv: add HID support
by Alexandre Julliard 07 Feb '17

07 Feb '17

Aric Stewart <aricstewart(a)gmail.com> writes: > Right now, only enabled if no other joystick platform layer is defined > or HID_WINMM is explicitly defined There shouldn't be any reason to ifdef it out, even when it's not used it should at least be built. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: d3d11: Silence a d3d11_immediate_context_OMSetBlendState fixme
by Henri Verbeet 07 Feb '17

07 Feb '17

On 6 February 2017 at 21:27, André Hentschel <nerv(a)dawncrow.de> wrote: > Signed-off-by: André Hentschel <nerv(a)dawncrow.de> > --- > > For https://bugs.winehq.org/show_bug.cgi?id=42017 > If you're a developer working on this code, and you're finding it hard to separate the FIXMEs that matter from the ones that don't, the correct way to do this would be to check "desc" for references to D3D11_BLEND_BLEND_FACTOR or D3D11_BLEND_INV_BLEND_FACTOR. But then, in that case it would be only marginally harder to just implement the functionality. For users uncomfortable with scary letters, I'd suggest WINEDEBUG=-all for a more thorough fix.

1 0