February 2017 - Wine-devel - list.winehq.org

Re: [PATCH 6/8] wined3d: Introduce wined3d_device_dispatch_compute().
by Henri Verbeet 02 Feb '17

02 Feb '17

On 2 February 2017 at 12:43, Józef Kucia <jkucia(a)codeweavers.com> wrote: > diff --git a/dlls/wined3d/drawprim.c b/dlls/wined3d/drawprim.c > index a3d88b9..4980413 100644 > --- a/dlls/wined3d/drawprim.c > +++ b/dlls/wined3d/drawprim.c > @@ -580,3 +580,46 @@ void draw_primitive(struct wined3d_device *device, const struct wined3d_state *s > > TRACE("Done all gl drawing.\n"); > } > + > +void dispatch_compute(struct wined3d_device *device, const struct wined3d_state *state, > + unsigned int group_count_x, unsigned int group_count_y, unsigned int group_count_z) I don't care too much, but in the longer term I'd be inclined to merge drawprim.c into some other file like context.c.

1 0

Re: [PATCH 3/5] wined3d: Fix querying texture-related limits on core profile.
by Józef Kucia 02 Feb '17

02 Feb '17

On Thu, Feb 2, 2017 at 1:04 AM, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > else > { > gl_info->limits.texture_coords = max(gl_info->limits.texture_coords, gl_max); > + TRACE("Max texture coords: %d.\n", gl_info->limits.texture_coords); > gl_info->limits.fragment_samplers = max(gl_info->limits.fragment_samplers, gl_max); > } Is this "else" block supposed to be executed only for legacy contexts? It might be better to merge it into the "if (gl_info->supported[WINED3D_GL_LEGACY_CONTEXT])" block above.

1 0

Re: user32: Hardcode the GetWindowLong values for the desktop window to avoid a server round-trip.
by Marvin 02 Feb '17

02 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28217 Your paranoid android. === w7u (32 bit win) === win.c:1003: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00CD01B0 fg 000401AE in hook HCBT_MINMAX

2 1

Re: [PATCH v2] user32: In menu.c converted all tabs to spaces
by Michael Stefaniuc 02 Feb '17

02 Feb '17

Hello Fabian, On 02/01/2017 11:25 PM, Fabian Maurer wrote: > This change makes it a lot to edit easier with some editors. > Conversion done with Notepad++, with tabsize 8 spaces. > > v2: removed trailing whitespace > > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/user32/menu.c | 1922 ++++++++++++++++++++++++++-------------------------- > 1 file changed, 961 insertions(+), 961 deletions(-) sorry, but this is just change noise. You can do the TAB to SPACE changes en passant when modifying the respective lines. Probably the only valid exception is when the indentation of the code is visibly messed up. But that's not the case here. bye michael

2 3

Re: user32: Avoid querying the server to determine whether the desktop window is a child window.
by Alexandre Julliard 02 Feb '17

02 Feb '17

Huw Davies <huw(a)codeweavers.com> writes: > Signed-off-by: Huw Davies <huw(a)codeweavers.com> > --- > dlls/user32/win.c | 31 +++++++++++++++++++++++++++++-- > 1 file changed, 29 insertions(+), 2 deletions(-) > > diff --git a/dlls/user32/win.c b/dlls/user32/win.c > index a7be4a3..341769f 100644 > --- a/dlls/user32/win.c > +++ b/dlls/user32/win.c > @@ -414,6 +414,33 @@ static HWND *list_window_parents( HWND hwnd ) > return NULL; > } > > +/******************************************************************* > + * is_child_win > + * > + * Helper to determine whether WS_CHILD is set. > + * It avoids a server round trip for the desktop window. > + */ We could probably make GetWindowLong return hardcoded values for the desktop window, so that all callers benefit. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] winealsa.drv: Fix handling of system real time MIDI messages
by Andrew Eikum 01 Feb '17

01 Feb '17

On Tue, Jan 31, 2017 at 04:16:17AM -0200, Bruno Jesus wrote: > MIDI spec at http://www.somascape.org/midi/tech/spec.html state that system real time messages "... are each single byte messages, with no following data bytes...", currently wine is prepending SYSEX header generating invalid messages. > Looking at this spec, should Tune Request be handled the same way as these system real time messages? I also noticed Reset is still handled as a SysEx after your patch. Should it be? Aside from that, I also noticed an old patch that unfortunately never got merged: https://www.winehq.org/pipermail/wine-patches/2013-January/121366.html If you understand this MIDI stuff a little bit, you might be a good person to review and re-submit that patch :) Thanks, Andrew

2 2

Re: [PATCH] wmvcore.c: Implement WMCreateReaderPriv
by Bruno Jesus 01 Feb '17

01 Feb '17

On Wed, Feb 1, 2017 at 11:35 PM, Jefferson Carpenter <jeffersoncarpenter2(a)gmail.com> wrote: > > -HRESULT WINAPI WMCreateReader(IUnknown *reserved, DWORD rights, IWMReader **ret_reader) > +HRESULT WINAPI WMCreateReaderPriv(IWMReader **ret_reader) > { > WMReader *reader; > > - TRACE("(%p, %x, %p)\n", reserved, rights, ret_reader); > - > reader = heap_alloc(sizeof(*reader)); > if(!reader) > return E_OUTOFMEMORY; > @@ -667,6 +665,13 @@ HRESULT WINAPI WMCreateReader(IUnknown *reserved, DWORD rights, IWMReader **ret_ > return S_OK; > } IMO it's better to not change the original function, make the newer function call WMCreateReader passing NULL reserved and 0 for rights. > +HRESULT WINAPI WMCreateReader(IUnknown *reserved, DWORD rights, IWMReader **ret_reader) > +{ > + TRACE("(%p, %x, %p)\n", reserved, rights, ret_reader); > + > + return WMCreateReaderPriv(ret_reader); > +} > + You are mixing spaces and tabs, please use the most common style from the file.

1 0

Re: [2/2] advapi32/tests: Add test of LsaLookupSids buffer behaviour
by Marvin 01 Feb '17

01 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28202 Your paranoid android. === wvistau64 (64 bit lsa) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit lsa) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit lsa) === Found no trace of the test summary line or of a crash === w864 (64 bit lsa) === Found no trace of the test summary line or of a crash === w1064 (64 bit lsa) === Found no trace of the test summary line or of a crash

1 0

Re: [PATCH v2] kernel32: Add stub implementation of NtQueryInformationThread(ThreadIsIoPending)
by Alexandre Julliard 01 Feb '17

01 Feb '17

Piotr Caban <piotr(a)codeweavers.com> writes: > v2: > - set last error on failure in GetThreadIOPendingFlag > > Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> > --- > dlls/kernel32/thread.c | 13 +++++++++++-- > dlls/ntdll/thread.c | 7 ++++++- > 2 files changed, 17 insertions(+), 3 deletions(-) This breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M kernel32.dll -p kernel32_test.exe.so thread && touch thread.ok thread.c:1977: Test failed: for info 16 expected STATUS_ACCESS_DENIED, got 00000000 (ret_len 4) thread.c:345: Tests skipped: child process wasn't mapped at same address, so can't do CreateRemoteThread tests. Makefile:731: recipe for target 'thread.ok' failed make: *** [thread.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] user32: Add WM_NCPAINT tests for windows crossing screen or maximized
by Marvin 01 Feb '17

01 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28193 Your paranoid android. === w864 (64 bit msg) === msg.c:10732: Test failed: wrong qstatus 00690048 msg.c:10783: Test failed: wrong qstatus 00290000 msg.c:10788: Test failed: PeekMessageA should have returned FALSE instead of msg 031f

1 0