February 2017 - Wine-devel - list.winehq.org

Re: [PATCH 17/18] comctl32: TaskDialog - Implement TDM_HELP and add tests
by Marvin 25 Feb '17

25 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28905 Your paranoid android. === w7pro64 (64 bit taskdialog) === 0270:taskdialog: unhandled exception c0000005 at 000000000046211E === w864 (64 bit taskdialog) === 0f88:taskdialog: unhandled exception c0000005 at 00007FFB25902CE1 === w1064 (64 bit taskdialog) === 0f6c:taskdialog: unhandled exception c0000005 at 000000000046211E

1 0

Re: [PATCH 16/18] comctl32: Taskdialog - Implement TDM_ENABLE_BUTTON and add tests
by Marvin 25 Feb '17

25 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28904 Your paranoid android. === w1064 (32 bit taskdialog) === 108c:taskdialog: unhandled exception c0000005 at 00472B00 === w7pro64 (64 bit taskdialog) === 0274:taskdialog: unhandled exception c0000005 at 000000000046211E === w864 (64 bit taskdialog) === 0f50:taskdialog: unhandled exception c0000005 at 000000000046211E === w1064 (64 bit taskdialog) === 0ac8:taskdialog: unhandled exception c0000005 at 000000000046211E

1 0

Re: [PATCH 15/18] comctl32: TaskDialog - Set default button and add tests
by Marvin 25 Feb '17

25 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28902 Your paranoid android. === w7pro64 (64 bit taskdialog) === 0828:taskdialog: unhandled exception c0000005 at 000000000046211E === w1064 (64 bit taskdialog) === 0e28:taskdialog: unhandled exception c0000005 at 000000000046211E

1 0

Re: [06/18] comctl32: TaskDialog - Implement main and content text controls
by Joachim Priesner 24 Feb '17

24 Feb '17

Glad to see that someone is finally implementing this properly :) > @@ -276,7 +324,33 @@ HRESULT WINAPI TaskDialogIndirect(const TASKDIALOGCONFIG *pTaskConfig, int *pnBu > > /* Start creating controls */ > > - controls_add(controls, IDOK, class_button, text_ok, WS_CHILD | WS_VISIBLE, 105, 85, 40, 10); > + if(!STR_EMPTY(pTaskConfig->pszMainInstruction)) > + { > + RECT rect; > + > + SelectObject(dc_dummy, font_main); > + rect = text_get_rect(dc_dummy, pTaskConfig->pszMainInstruction, dialog_width); > + > + controls_add(controls, ID_TEXTMAIN, class_static, pTaskConfig->pszMainInstruction, > + WS_CHILD | WS_VISIBLE, 5, dialog_height + 5, rect.right, rect.bottom); The psz* parameters (e.g. pszMainInstruction) can contain a resource ID instead of a string. (Passing an invalid ID just results in an empty string.) Right now passing something that is not a string crashes the dialog, which probably should not happen. To get the string if a resource ID has been passed you can use something like +/* Fills "result" with a pointer to the string specified by "text", which may be a resource identifier. */ +static HRESULT TASKDIALOG_GetText(const WCHAR *text, HINSTANCE instance, const WCHAR **result) +{ + if (IS_INTRESOURCE(text)) + { + SetLastError(S_OK); + LoadStringW(instance, LOWORD(text), (LPWSTR)result, 0); + return HRESULT_FROM_WIN32(GetLastError()); + } + else + { + *result = text; + return S_OK; + } +}

2 3

RE: wineinstall - Add support for parallel builds using 'nproc' to detect cpu count
by wylda＠volny.cz 24 Feb '17

24 Feb '17

Hi, i like/use "make -j 1" for log comparison. Can you leave NPROC=1 or allow override? W.

5 12

Re: [18/18] comctl32: TaskDialog - Add ability to cancel dialog
by Marvin 24 Feb '17

24 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28889 Your paranoid android. === wxppro (32 bit taskdialog) === taskdialog.c:631: Test failed: TaskDialogIndirect not exported by name. === w2003std (32 bit taskdialog) === taskdialog.c:631: Test failed: TaskDialogIndirect not exported by name. === w7pro64 (64 bit taskdialog) === 0718:taskdialog: unhandled exception c0000005 at 000000000046211E === w1064 (64 bit taskdialog) === 0b44:taskdialog: unhandled exception c0000005 at 000000000046211E

1 0

Re: [17/18] comctl32: TaskDialog - Implement TDM_HELP and add tests
by Marvin 24 Feb '17

24 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28888 Your paranoid android. === wxppro (32 bit taskdialog) === taskdialog.c:550: Test failed: TaskDialogIndirect not exported by name. === w2003std (32 bit taskdialog) === taskdialog.c:550: Test failed: TaskDialogIndirect not exported by name. === w7pro64 (64 bit taskdialog) === 06fc:taskdialog: unhandled exception c0000005 at 000000000046211E === w1064 (64 bit taskdialog) === 0e6c:taskdialog: unhandled exception c0000005 at 000000000046211E

1 0

Re: [16/18] comctl32: Taskdialog - Implement TDM_ENABLE_BUTTON and add tests
by Marvin 24 Feb '17

24 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28887 Your paranoid android. === wxppro (32 bit taskdialog) === taskdialog.c:531: Test failed: TaskDialogIndirect not exported by name. === w2003std (32 bit taskdialog) === taskdialog.c:531: Test failed: TaskDialogIndirect not exported by name. === w7pro64 (64 bit taskdialog) === 0438:taskdialog: unhandled exception c0000005 at 000000000046211E === w864 (64 bit taskdialog) === 0f54:taskdialog: unhandled exception c0000005 at 000000000046211E === w1064 (64 bit taskdialog) === 0e44:taskdialog: unhandled exception c0000005 at 000000000046211E

1 0

Re: [15/18] comctl32: TaskDialog - Set default button and add tests
by Marvin 24 Feb '17

24 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28886 Your paranoid android. === wxppro (32 bit taskdialog) === taskdialog.c:456: Test failed: TaskDialogIndirect not exported by name. === w2003std (32 bit taskdialog) === taskdialog.c:456: Test failed: TaskDialogIndirect not exported by name. === w7pro64 (64 bit taskdialog) === 0824:taskdialog: unhandled exception c0000005 at 000000000046211E === w1064 (64 bit taskdialog) === 074c:taskdialog: unhandled exception c0000005 at 000000000046211E

1 0

Re: [03/18] comctl32: Added basic implementation for task dialogs and add tests
by Nikolay Sivov 24 Feb '17

24 Feb '17

On 24.02.2017 23:03, Fabian Maurer wrote: > The dialog doesn't show text and can basically do nothing, > but it sets the foundation. > > +} > + > +/* Functions for turning our dialog structures into a usable dialog template > + * We don't load the dialog template from a resource, we instead create it in memory > + * This way we can easily handle variable control numbers */ I think this is an overkill. How about using static template and then destroying controls you don't need?

1 1