May 2017 - Wine-devel - list.winehq.org

Re: [PATCH 3/4] d3dx9: Do not set active pass if BeginPass() failed.
by Marvin 03 May '17

03 May '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30755 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 2/4] d3dx9: Return shader functions in d3dx9_base_effect_get_pass_desc().
by Marvin 03 May '17

03 May '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30754 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 1/4] d3dx9/tests: Add test for GetPassDesc() function.
by Marvin 03 May '17

03 May '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30753 Your paranoid android. === build (build) === Make failed

1 0

Wine native fps overlay
by CARLOS RODRIGUEZ 03 May '17

03 May '17

Hi Could be possible add native fps overlay, maybe can usefull for many apps and without forget steam overlay give performance issues in certain apps (steam overlay dont work since wine 2.6) Thanks

3 2

pulse/alsa option in wine cfg audio tab
by CARLOS RODRIGUEZ 03 May '17

03 May '17

Hi Seeking donat enikeev patch for add csmt option to graphics tab Could be possible add option for select which audio driver can be used aka alsa o pulse in winecfg audio tab ? Because various apps still needed alsa case tales of zestiria, alan wake and many others Thanks

2 1

Re: [PATCH 01/10] d3dx9/tests: Use compare_float() in D3DXFresnelTest().
by Alexandre Julliard 03 May '17

03 May '17

Matteo Bruni <mbruni(a)codeweavers.com> writes: > Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Could you please try to send the signoff mail as a reply to the original patch, instead of a reply to your previous signoff? This way the tracker can find the appropriate patch automatically. Thanks. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/5] wsdapi: Implement WSD LinkedMemory functions [try 4]
by Alexandre Julliard 03 May '17

03 May '17

Owen Rudge <orudge(a)codeweavers.com> writes: > + ptr = HeapAlloc(procHeap, HEAP_ZERO_MEMORY, MEMORY_ALLOCATION_SIZE + cbSize); Are all allocations supposed to be zeroed? This is a little surprising, it would need a test too. > + > + srand((unsigned)time(NULL)); Please don't do that, test results need to be reproducible. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [RFC] README: Update Linux version requirement to 2.3.31.
by wylda＠volny.cz 03 May '17

03 May '17

> >> I've not tested the version, but recent commit 45a632ee81c9c5c58309426de5aadbd8dbbba0f5 >> introduces SYS_mmap2 system call which doesn't exist before 2.3.31. >> So, should we update the requirement? Is 2.3.31 valid enough? > >I'm not sure that we know what the minimum version is these days. If >mmap2 is really the only new dependency, adding a workaround is easy >enough. Is anybody able to test this? > >-- >Alexandre Julliard >julliard(a)winehq.org > Hmmm, no answers... It seems to me like crazy project, which nobody on Earth would ever undergo. To promote it from crazy to totally insane I could give a drive to one of my oldies. Like - 486DX - 386DX + 387 / 32MB RAM - 386DX / 4MB RAM with ISA Trident 512KB (no 386SX / 486SX;) just to see, how deep we can sink with those old ships :-)) I would let Pentium and Pentium MMX docked for being too modern. So when testing old kernels (Debian distributions) – If that ever compile what else could be interesting? GCC version? Libc version? X version? How to interpret successful test - compilation? (pre-compiled in VM) - Running winecfg?? - Running MS Paint???

3 3

Re: [PATCH resend] comctl32: When adding a scrollbar to a listview, update the other one.
by Nikolay Sivov 03 May '17

03 May '17

On 03.05.2017 7:53, Alex Henrie wrote: > Cc: Nikolay Sivov <nsivov(a)codeweavers.com> > > Fixes https://bugs.winehq.org/show_bug.cgi?id=35529 > > Adding a vertical scrollbar can necessitate adding a horizontal > scrollbar just as easily as adding a horizontal scrollbar can > necessitate adding a vertical scrollbar. (And in the same way, removing > either of the scrollbars can necessitate removing the other scrollbar.) > > This patch was previously assigned to Nikolay, but I never received any > feedback about it. Sorry about that. > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/comctl32/listview.c | 78 +++++++++++++++++++++++++++++++----------------- > 1 file changed, 50 insertions(+), 28 deletions(-) > > diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c > index c01d816c46..c3c89d08dc 100644 > --- a/dlls/comctl32/listview.c > +++ b/dlls/comctl32/listview.c > @@ -2016,23 +2016,10 @@ static void LISTVIEW_UpdateHeaderSize(const LISTVIEW_INFO *infoPtr, INT nNewScro > SWP_NOZORDER | SWP_NOACTIVATE); > } > > -/*** > - * DESCRIPTION: > - * Update the scrollbars. This functions should be called whenever > - * the content, size or view changes. > - * > - * PARAMETER(S): > - * [I] infoPtr : valid pointer to the listview structure > - * > - * RETURN: > - * None > - */ > -static void LISTVIEW_UpdateScroll(const LISTVIEW_INFO *infoPtr) > +static INT LISTVIEW_UpdateHScroll(LISTVIEW_INFO *infoPtr) > { > - SCROLLINFO horzInfo, vertInfo; > - INT dx, dy; > - > - if ((infoPtr->dwStyle & LVS_NOSCROLL) || !is_redrawing(infoPtr)) return; > + SCROLLINFO horzInfo; > + INT dx; > > ZeroMemory(&horzInfo, sizeof(SCROLLINFO)); > horzInfo.cbSize = sizeof(SCROLLINFO); > @@ -2084,10 +2071,22 @@ static void LISTVIEW_UpdateScroll(const LISTVIEW_INFO *infoPtr) > dx -= SetScrollInfo(infoPtr->hwndSelf, SB_HORZ, &horzInfo, TRUE); > TRACE("horzInfo=%s\n", debugscrollinfo(&horzInfo)); > > - /* Setting the horizontal scroll can change the listview size > - * (and potentially everything else) so we need to recompute > - * everything again for the vertical scroll > - */ > + /* Update the Header Control */ > + if (infoPtr->hwndHeader) > + { > + horzInfo.fMask = SIF_POS; > + GetScrollInfo(infoPtr->hwndSelf, SB_HORZ, &horzInfo); > + LISTVIEW_UpdateHeaderSize(infoPtr, horzInfo.nPos); > + } > + > + LISTVIEW_UpdateSize(infoPtr); > + return dx; > +} > + > +static INT LISTVIEW_UpdateVScroll(LISTVIEW_INFO *infoPtr) > +{ > + SCROLLINFO vertInfo; > + INT dy; > > ZeroMemory(&vertInfo, sizeof(SCROLLINFO)); > vertInfo.cbSize = sizeof(SCROLLINFO); > @@ -2117,6 +2116,37 @@ static void LISTVIEW_UpdateScroll(const LISTVIEW_INFO *infoPtr) > dy -= SetScrollInfo(infoPtr->hwndSelf, SB_VERT, &vertInfo, TRUE); > TRACE("vertInfo=%s\n", debugscrollinfo(&vertInfo)); > > + LISTVIEW_UpdateSize(infoPtr); > + return dy; > +} > + > +/*** > + * DESCRIPTION: > + * Update the scrollbars. This function should be called whenever > + * the content, size or view changes. > + * > + * PARAMETER(S): > + * [I] infoPtr : valid pointer to the listview structure > + * > + * RETURN: > + * None > + */ > +static void LISTVIEW_UpdateScroll(LISTVIEW_INFO *infoPtr) > +{ > + INT dx, dy; > + > + if ((infoPtr->dwStyle & LVS_NOSCROLL) || !is_redrawing(infoPtr)) return; > + > + /* Setting the horizontal scroll can change the listview size > + * (and potentially everything else) so we need to recompute > + * everything again for the vertical scroll and vice-versa > + */ > + > + dx = LISTVIEW_UpdateHScroll(infoPtr); > + dy = LISTVIEW_UpdateVScroll(infoPtr); > + dx += LISTVIEW_UpdateHScroll(infoPtr); > + dy += LISTVIEW_UpdateVScroll(infoPtr); > + This certainly doesn't look pretty, but I see what you mean. I'll take a look, thanks for reminding me. > /* Change of the range may have changed the scroll pos. If so move the content */ > if (dx != 0 || dy != 0) > { > @@ -2125,14 +2155,6 @@ static void LISTVIEW_UpdateScroll(const LISTVIEW_INFO *infoPtr) > ScrollWindowEx(infoPtr->hwndSelf, dx, dy, &listRect, &listRect, 0, 0, > SW_ERASE | SW_INVALIDATE); > } > - > - /* Update the Header Control */ > - if (infoPtr->hwndHeader) > - { > - horzInfo.fMask = SIF_POS; > - GetScrollInfo(infoPtr->hwndSelf, SB_HORZ, &horzInfo); > - LISTVIEW_UpdateHeaderSize(infoPtr, horzInfo.nPos); > - } > } > > >

1 0

Re: [2/4] ole32: Implement DataCache_InitCache
by Huw Davies 03 May '17

03 May '17

On Tue, May 02, 2017 at 06:11:22PM +0800, Wei Xie wrote: > diff --git a/dlls/ole32/datacache.c b/dlls/ole32/datacache.c > index 441a874..51a67e2 100644 > --- a/dlls/ole32/datacache.c > +++ b/dlls/ole32/datacache.c > @@ -2052,8 +2052,45 @@ static HRESULT WINAPI DataCache_InitCache( > IOleCache2* iface, > IDataObject* pDataObject) > { > - FIXME("stub\n"); > - return E_NOTIMPL; > + HRESULT hr; > + FORMATETC fmt; > + STGMEDIUM med; > + > + FIXME("semi-stub\n"); > + > + hr = IDataObject_GetData(pDataObject, &fmt, &med); > + if (FAILED(hr)) > + { > + return CACHE_E_NOCACHE_UPDATED; > + } > + > + if (!fmt.cfFormat || !fmt.tymed || > + (check_valid_clipformat_and_tymed(fmt.cfFormat, fmt.tymed, FALSE) > + && TYMED_NULL != med.tymed)) > + { > + switch(med.tymed) > + { > + case TYMED_GDI: > + { > + fmt.cfFormat = CF_BITMAP; > + fmt.ptd = NULL; > + fmt.dwAspect = DVASPECT_CONTENT; > + fmt.lindex = -1; > + fmt.tymed = TYMED_GDI; > + } > + break; > + default: > + FIXME("Fill formatetc\n"); > + } > + } > + > + hr = IOleCache2_SetData(iface, &fmt, &med, FALSE); > + if (FAILED(hr)) > + { > + return CACHE_E_NOCACHE_UPDATED; > + } > + > + return hr; > } This isn't correct. What I think the tests will show you is that it looks something like the pseudo-code: for_each_cached_format( &fmt ) /* some function that returns the fmt of each cache entry */ { IDataObject_GetData(pDataObject, &fmt, &med); IOleCache2_SetData(iface, &fmt, &med); } Of course there needs to be error handling, tests if the cache has already been initialized, etc. However for now I suggest you just concerntrate on getting the tests in, and come back to this and the subsequent patches later on. Huw.

1 0