June 2017 - Wine-devel - list.winehq.org

Re: [PATCH 7/7] mshtml/tests: Added IHTMLInputTextElement2 tests.
by Marvin 15 Jun '17

15 Jun '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31658 Your paranoid android. === wxppro (32 bit dom) === dom.c:8303: Test failed: Could not get {3050f2d2-98b5-11cf-bb82-00aa00bdce0b} interface: 80004002 dom.c:8358: Test failed: Could not get {3050f2d2-98b5-11cf-bb82-00aa00bdce0b} interface: 80004002 dom.c:9143: Test failed: Could not get {3050f2d2-98b5-11cf-bb82-00aa00bdce0b} interface: 80004002 === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath htmldoc.c:5092: Test failed: unexpected call {d9befc84-f21e-4166-874b-a8d3010dc764}

1 0

Re: [PATCH 2/7] mshtml: Added IHTMLInputTextElement2 stub implementation.
by Marvin 15 Jun '17

15 Jun '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31657 Your paranoid android. === wxppro (32 bit dom) === dom.c:8303: Test failed: Could not get {3050f2d2-98b5-11cf-bb82-00aa00bdce0b} interface: 80004002 dom.c:8358: Test failed: Could not get {3050f2d2-98b5-11cf-bb82-00aa00bdce0b} interface: 80004002 dom.c:9143: Test failed: Could not get {3050f2d2-98b5-11cf-bb82-00aa00bdce0b} interface: 80004002

1 0

Re: [v2 4/7] d3dx9: Add scalar and vector setting path to set_constants().
by Matteo Bruni 14 Jun '17

14 Jun '17

2017-06-12 13:22 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/preshader.c | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/dlls/d3dx9_36/preshader.c b/dlls/d3dx9_36/preshader.c > index 2f9648d..1ca02c4 100644 > --- a/dlls/d3dx9_36/preshader.c > +++ b/dlls/d3dx9_36/preshader.c > @@ -1101,6 +1101,12 @@ static void regstore_set_data(struct d3dx_regstore *rs, unsigned int table, > }; > enum pres_value_type table_type = table_info[table].type; > > + if (param_type == table_type) > + { > + regstore_set_values(rs, table, in, offset, count); > + return; > + } Maybe it's a bit paranoid but I'd like an assert in regstore_set_values() ensuring that there is no overlap between destination and source of the memcpy(). That's clearly the case at the moment but it might become less obvious in the future.

2 2

Re: [PATCH v2] msacm32: Rewrite PCM conversion functions.
by Andrew Eikum 14 Jun '17

14 Jun '17

On Tue, Jun 13, 2017 at 04:35:52PM -0500, Zebediah Figura wrote: > +#define PCM_CVT_CHANGE_FUNC(name) static void name(DWORD srcRate, const unsigned char *src, DWORD *nsrc, \ > + DWORD dstRate, unsigned char *dst, DWORD *ndst) \ > + { \ > + DWORD error = srcRate / 2; \ > + DWORD srcUsed = 0, dstUsed = 0; \ > + for (srcUsed = 0; srcUsed < *nsrc; srcUsed++) { \ > + error += dstRate; \ > + while (error > srcRate) { \ > + if (dstUsed == *ndst) { \ > + *nsrc = srcUsed; \ > + *ndst = dstUsed; \ > + return; \ > + } > + > + /* conversion is done here */ > + > +#define PCM_CVT_CHANGE_FUNC_END(offset) \ > + dstUsed++; \ > + error -= srcRate; \ > + } \ > + src += offset; \ > + } \ > + *nsrc = srcUsed; \ > + *ndst = dstUsed; \ > +} > + > +PCM_CVT_CHANGE_FUNC(cvtSS88C) > + *dst++ = src[0]; > + *dst++ = src[1]; > +PCM_CVT_CHANGE_FUNC_END(2) > + I really dislike complicated preprocessor tricks. Can't this be done in a similar way with real functions? If not, I'd rather have the copy-pasted code than these difficult macros. Andrew

4 6

Re: [PATCH] include/wincodec.idl: Stop redefinition of ID2D1Image
by Sebastian Lackner 14 Jun '17

14 Jun '17

On 14.06.2017 13:54, Alistair Leslie-Hughes wrote: > Fixes: https://bugs.winehq.org/show_bug.cgi?id=43175 > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > include/wincodec.idl | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/wincodec.idl b/include/wincodec.idl > index 1ea6e0e203..bdc2031ac3 100644 > --- a/include/wincodec.idl > +++ b/include/wincodec.idl > @@ -224,7 +224,9 @@ typedef DWORD *D2D1_PIXEL_FORMAT; > cpp_quote ("#endif") > > cpp_quote ("typedef interface ID2D1Device ID2D1Device;") > +cpp_quote ("#ifndef __ID2D1Image_FWD_DEFINED__") > cpp_quote ("typedef interface ID2D1Image ID2D1Image;") > +cpp_quote ("#endif") > > typedef struct WICRect { > INT X; > And what if the include files are used in the opposite order? You don't define __ID2D1Image_FWD_DEFINED__, so the bug will reappear. Best regards, Sebastian

2 1

Re: [5/6] webservices: Implement WsReadXmlBuffer.
by Marvin 14 Jun '17

14 Jun '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31634 Your paranoid android. === w7u (32 bit reader) === reader.c:5208: Test failed: got 487 === w7pro64 (32 bit reader) === reader.c:5208: Test failed: got 487 === w8 (32 bit reader) === reader.c:5208: Test failed: got 487 === w864 (32 bit reader) === reader.c:5208: Test failed: got 487 === w7pro64 (64 bit reader) === reader.c:5208: Test failed: got 487 === w864 (64 bit reader) === reader.c:5208: Test failed: got 487

1 0

Re: [1/6] webservices: Add a static builtin dictionary.
by Marvin 14 Jun '17

14 Jun '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31632 Your paranoid android. === w7u (32 bit reader) === reader.c:5208: Test failed: got 487 === w7pro64 (32 bit reader) === reader.c:5208: Test failed: got 487 === w8 (32 bit reader) === reader.c:5208: Test failed: got 487 === w864 (32 bit reader) === reader.c:5208: Test failed: got 487 === w7pro64 (64 bit reader) === reader.c:5208: Test failed: got 487 === w864 (64 bit reader) === reader.c:5208: Test failed: got 487

1 0

Re: [v2 6/7] d3dx9: Get rid of constant's length checking for matrix in set_constants().
by Matteo Bruni 13 Jun '17

13 Jun '17

2017-06-12 13:22 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > When count in const_upload_info is calculated precisely (considering actual > constant set length), boolean matrix setting always fall in direct copy path. > The test has both row_major and column_major qualified boolean matrices, but > the qualifier is ignored by compiler. Is it? The effect parameter is always row major, but it looks like the constant is actually affected (and you're handling that correctly AFAICS). > If change the type of matrix to int, > the matrix goes to float constants and not to bool constants. So it looks like > the case of incomplete last row for matrix should now never happen. Right, and the FIXME you're adding in this patch should trigger if any of those assumptions turns out to be invalid. Looks good.

1 0

Re: [v2 3/7] d3dx9: Avoid casting each value separately in set_constants().
by Matteo Bruni 13 Jun '17

13 Jun '17

2017-06-12 13:22 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > +static void pres_float_to_int(const void *in, void *out, unsigned int count) Something I forgot earlier and maybe it's bikeshedding, but anyway: could you flip those functions around like e.g. pres_int_from_float()? The "out" argument should also be swapped with "in". Patch looks good otherwise.

1 0

Re: [PATCH 3/6] server: Implement changing the label of a security descriptor.
by Alexandre Julliard 13 Jun '17

13 Jun '17

Matteo Bruni <mbruni(a)codeweavers.com> writes: > From: Michael Müller <michael(a)fds-team.de> > > Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> > --- > dlls/advapi32/tests/security.c | 153 ++++++++++++++++++++++++++++++++++++++++- > dlls/ntdll/sec.c | 3 +- > server/handle.c | 130 +++++++++++++++++++++++++++++++++- > 3 files changed, 282 insertions(+), 4 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M advapi32.dll -p advapi32_test.exe.so security && touch security.ok security.c:2065: Tests skipped: Well known SID 38 not implemented security.c:2065: Tests skipped: Well known SID 39 not implemented security.c:2065: Tests skipped: Well known SID 40 not implemented security.c:2065: Tests skipped: Well known SID 41 not implemented security.c:2065: Tests skipped: Well known SID 42 not implemented security.c:2065: Tests skipped: Well known SID 43 not implemented security.c:2065: Tests skipped: Well known SID 44 not implemented security.c:2065: Tests skipped: Well known SID 45 not implemented security.c:2065: Tests skipped: Well known SID 46 not implemented security.c:2065: Tests skipped: Well known SID 47 not implemented security.c:2065: Tests skipped: Well known SID 48 not implemented security.c:2065: Tests skipped: Well known SID 49 not implemented security.c:2065: Tests skipped: Well known SID 50 not implemented security.c:2065: Tests skipped: Well known SID 62 not implemented security.c:2065: Tests skipped: Well known SID 63 not implemented security.c:2065: Tests skipped: Well known SID 64 not implemented security.c:2065: Tests skipped: Well known SID 65 not implemented security.c:2065: Tests skipped: Well known SID 70 not implemented security.c:2065: Tests skipped: Well known SID 71 not implemented security.c:2065: Tests skipped: Well known SID 72 not implemented security.c:2065: Tests skipped: Well known SID 73 not implemented security.c:2065: Tests skipped: Well known SID 74 not implemented security.c:2065: Tests skipped: Well known SID 75 not implemented security.c:2065: Tests skipped: Well known SID 76 not implemented security.c:2065: Tests skipped: Well known SID 77 not implemented security.c:2065: Tests skipped: Well known SID 78 not implemented security.c:2065: Tests skipped: Well known SID 79 not implemented security.c:2065: Tests skipped: Well known SID 81 not implemented security.c:2065: Tests skipped: Well known SID 82 not implemented wine: Unhandled page fault on read access to 0x00000004 at address 0x7ed5a0bf (thread 0047), starting debugger... Unhandled exception: page fault on read access to 0x00000004 in 32-bit code (0x7ed5a0bf). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7ed5a0bf ESP:0033f9ac EBP:0033fb88 EFLAGS:00010206( R- -- I - -P- ) EAX:00000000 EBX:7ed83000 ECX:0000001f EDX:00000400 ESI:00133838 EDI:7ed73e9f Stack dump: 0x0033f9ac: 0000007a 00000000 00000000 7ed79a04 0x0033f9bc: 7ed74d52 7ed7996c 7ed79918 0033fa44 0x0033f9cc: 00000001 7ed79940 00000001 7ed84b58 0x0033f9dc: 7ed79994 7ed798e8 001336e0 7ed74cc0 0x0033f9ec: 7ed74cb2 7ed74ca0 0033fa40 0033fa30 0x0033f9fc: 0033fa2c 7ed7980c 7ed797dc 7ed79a90 Backtrace: =>0 0x7ed5a0bf test_AddMandatoryAce+0xf9f() [/home/julliard/wine/wine/dlls/advapi32/tests/security.c:6348] in advapi32_test (0x0033fb88) 1 0x7ed625fa func_security+0x24a9() [/home/julliard/wine/wine/dlls/advapi32/tests/security.c:6764] in advapi32_test (0x0033fd48) 2 0x7ed2596d main+0x25c(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/dlls/advapi32/tests/../../../include/wine/test.h:589] in advapi32_test (0x0033fdf8) 3 0x7ed6df9b __wine_spec_exe_entry+0x4a(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in advapi32_test (0x0033fe38) 4 0x7b45e79c call_process_entry+0xb() in kernel32 (0x0033fe58) 5 0x7b45f6d9 start_process+0x68(entry=<couldn't compute location>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1116] in kernel32 (0x0033fe98) 6 0x7bc7f23c call_thread_func_wrapper+0xb() in ntdll (0x0033feb8) 7 0x7bc81ff9 call_thread_func+0xa8(entry=0x7b45f670, arg=0x7ed6df50, frame=0x33ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2759] in ntdll (0x0033ffa8) 8 0x7bc7f21a call_thread_entry_point+0x11() in ntdll (0x0033ffc8) 9 0x7bc54023 start_process+0x12(arg=0xff871728) [/home/julliard/wine/wine/dlls/ntdll/loader.c:3083] in ntdll (0x0033ffe8) 10 0xf75938cd __x86.get_pc_thunk.di+0x2a() in libwine.so.1 (0x00000000) 11 0xf7593a30 wine_switch_to_stack+0x1f(func=0x7bc54010, arg=0xff871728, stack=0x340000) [/home/julliard/wine/wine/libs/wine/port.c:77] in libwine.so.1 (0xff8716f8) 12 0x7bc59cde LdrInitializeThunk+0x22d(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ntdll/loader.c:3144] in ntdll (0xff871748) 13 0x7b46563f __wine_kernel_init+0xa4e() [/home/julliard/wine/wine/dlls/kernel32/process.c:1310] in kernel32 (0xff872638) 14 0x7bc5ab33 __wine_process_init+0x152() [/home/julliard/wine/wine/dlls/ntdll/loader.c:3353] in ntdll (0xff8726a8) 15 0xf7591b33 wine_init+0x2a2(argc=0x3, argv=0xff872bf4, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:974] in libwine.so.1 (0xff8726f8) 16 0x7c000b58 main+0x97(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/loader/main.c:258] in <wine-loader> (0xff872b48) 17 0xf739b276 __libc_start_main+0xf5() in libc.so.6 (0x00000000) 0x7ed5a0bf test_AddMandatoryAce+0xf9f [/home/julliard/wine/wine/dlls/advapi32/tests/security.c:6348] in advapi32_test: movzwl 0x4(%eax),%edx 6348 ok(!sacl->AceCount, "SACL contains an unexpected ACE count %u\n", sacl->AceCount); -- Alexandre Julliard julliard(a)winehq.org

3 3