June 2017 - Wine-devel - list.winehq.org

Re: [PATCH v2 3/4] msi: Implement INSTALLMESSAGE_INITIALIZE and INSTALLMESSAGE_TERMINATE.
by Marvin 27 Jun '17

27 Jun '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31865 Your paranoid android. === wvistau64 (32 bit package) === package.c:9397: Test failed: MsiOpenPackage with valid db: in msg 0x0b000000 field 2: expected "", got "þþ" === wvistau64 (64 bit package) === package.c:9397: Test failed: MsiOpenPackage with valid db: in msg 0x0b000000 field 2: expected "", got "þþ"

1 0

Re: [PATCH v2 2/4] msi: Send the correct UI messages upon calling MsiDoAction().
by Marvin 27 Jun '17

27 Jun '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31864 Your paranoid android. === wvistau64 (32 bit package) === package.c:9397: Test failed: MsiOpenPackage with valid db: in msg 0x0b000000 field 2: expected "", got "þþ" === wvistau64 (64 bit package) === package.c:9397: Test failed: MsiOpenPackage with valid db: in msg 0x0b000000 field 2: expected "", got "þþ"

1 0

Re: [PATCH v2 1/4] msi/tests: Add tests for external UI callback.
by Marvin 27 Jun '17

27 Jun '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31863 Your paranoid android. === wvistau64 (32 bit package) === package.c:9397: Test failed: MsiOpenPackage with valid db: in msg 0x0b000000 field 2: expected "", got "þþ" === wvistau64 (64 bit package) === package.c:9397: Test failed: MsiOpenPackage with valid db: in msg 0x0b000000 field 2: expected "", got "þþ"

1 0

Re: [v3 2/2] user32/tests: Add test for GetWindowDisplayAffinity.
by Marvin 26 Jun '17

26 Jun '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31853 Your paranoid android. === w7u (32 bit win) === win.c:9860: Test failed: SetWindowDisplayAffinity returned with 8 win.c:9864: Test failed: GetWindowDisplayAffinity returned unexpected affinity 0 win.c:9867: Test failed: SetWindowDisplayAffinity returned with 8 === w7pro64 (32 bit win) === win.c:9860: Test failed: SetWindowDisplayAffinity returned with 8 win.c:9864: Test failed: GetWindowDisplayAffinity returned unexpected affinity 0 win.c:9867: Test failed: SetWindowDisplayAffinity returned with 8 === w7pro64 (64 bit win) === win.c:9860: Test failed: SetWindowDisplayAffinity returned with 8 win.c:9864: Test failed: GetWindowDisplayAffinity returned unexpected affinity 0 win.c:9867: Test failed: SetWindowDisplayAffinity returned with 8

2 1

Re: [PATCH] gdiplus: Write API doc for GdipAddPathEllipse and GdipAddPathEllipseI
by Vincent Povirk 26 Jun '17

26 Jun '17

This description is probably more complicated than it needs to be. If we want consistency with the GdipAddPathLine description, we can state it in terms of the newfigure value, which is ignored on input and TRUE on output. On Sat, Jun 24, 2017 at 11:26 AM, Clemens Tamme <clemens.tamme(a)gmail.com> wrote: > + * As an ellipse is always a new subpath the current subpath of the given path > + * cannot be continued afterwards. Additionally, the next thing added to the > + * path will be the start of the next subpath.

1 0

Re: [1/3] server: Add field for window display affinity.
by Alexandre Julliard 26 Jun '17

26 Jun '17

Andrew Wesie <awesie(a)gmail.com> writes: > Signed-off-by: Andrew Wesie <awesie(a)gmail.com> > --- > include/wine/server_protocol.h | 9 ++++++--- > server/protocol.def | 3 +++ > server/request.h | 4 +++- > server/window.c | 4 ++++ > 4 files changed, 16 insertions(+), 4 deletions(-) > > diff --git a/include/wine/server_protocol.h b/include/wine/server_protocol.h > index d31579c..f442a94 100644 > --- a/include/wine/server_protocol.h > +++ b/include/wine/server_protocol.h > @@ -47,7 +47,7 @@ struct reply_header > > struct request_max_size > { > - int pad[16]; > + int pad[18]; > }; You can't change the request size. Also note that this is a generated file, updated by tools/make_requests. Do you have an app that uses this across processes? Otherwise you can probably simply store a local flag for now. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 1/5] msi/tests: Add tests for external UI callback.
by Hans Leidekker 26 Jun '17

26 Jun '17

On Sun, 2017-06-25 at 21:13 -0500, Zebediah Figura wrote: > @@ -822,6 +823,8 @@ static UINT package_from_db(MSIHANDLE hdb, MSIHANDLE *handle) > CHAR szPackage[12]; > MSIHANDLE hPackage; > > + CoInitialize(NULL); > + > sprintf(szPackage, "#%u", hdb); > res = MsiOpenPackageA(szPackage, &hPackage); > if (res != ERROR_SUCCESS) > @@ -837,22 +840,39 @@ static UINT package_from_db(MSIHANDLE hdb, MSIHANDLE *handle) > return res; > } > > + CoUninitialize(); > + Why do you need this? > -static void create_test_file(const CHAR *name) > +static void create_file_data(LPCSTR name, LPCSTR data, DWORD size) > { > HANDLE file; > DWORD written; > > file = CreateFileA(name, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, NULL); > ok(file != INVALID_HANDLE_VALUE, "Failure to open file %s\n", name); > - WriteFile(file, name, strlen(name), &written, NULL); > + if (file == INVALID_HANDLE_VALUE) > + return; > + > + WriteFile(file, data, strlen(data), &written, NULL); > WriteFile(file, "\n", strlen("\n"), &written, NULL); > + > + if (size) > + { > + SetFilePointer(file, size, NULL, FILE_BEGIN); > + SetEndOfFile(file); > + } > + > CloseHandle(file); > } You're not using this in this patch set.

3 3

Re: [PATCH 4/5] msi: Implement INSTALLMESSAGE_INITIALIZE and INSTALLMESSAGE_TERMINATE.
by Marvin 26 Jun '17

26 Jun '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31839 Your paranoid android. === wvistau64 (32 bit package) === package.c:9405: Test failed: MsiOpenPackage with valid db: in msg 0x0b000000 field 2: expected "", got "þþ" === wvistau64 (64 bit package) === package.c:9405: Test failed: MsiOpenPackage with valid db: in msg 0x0b000000 field 2: expected "", got "þþ"

1 0

Re: [PATCH 3/5] msi: Send the correct UI messages upon calling MsiDoAction().
by Marvin 26 Jun '17

26 Jun '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31838 Your paranoid android. === wvistau64 (32 bit package) === package.c:9405: Test failed: MsiOpenPackage with valid db: in msg 0x0b000000 field 2: expected "", got "þþ" === wvistau64 (64 bit package) === package.c:9405: Test failed: MsiOpenPackage with valid db: in msg 0x0b000000 field 2: expected "", got "þþ"

1 0

Re: [PATCH 1/5] msi/tests: Add tests for external UI callback.
by Marvin 26 Jun '17

26 Jun '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31836 Your paranoid android. === wvistau64 (32 bit package) === package.c:9405: Test failed: MsiOpenPackage with valid db: in msg 0x0b000000 field 2: expected "", got "þþ" === wvistau64 (64 bit package) === package.c:9405: Test failed: MsiOpenPackage with valid db: in msg 0x0b000000 field 2: expected "", got "þþ"

1 0