August 2017 - Wine-devel - list.winehq.org

Re: [PATCH 2/2] wined3d: do not call queue_is_empty in wined3d_cs_mt_finish.
by Henri Verbeet 07 Aug '17

07 Aug '17

On 4 August 2017 at 10:21, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +/* This function assumes that it is called from the command stream thread. */ > static BOOL wined3d_cs_queue_is_empty(const struct wined3d_cs_queue *queue) It should probably have a wined3d_from_cs() then.

1 0

Re: winebuild: Improved position independent code generation
by Martin Storsjö 06 Aug '17

06 Aug '17

On Sun, 6 Aug 2017, André Hentschel wrote: > Android only accepts proper position independent binaries, but until now we generated code which led to a TEXTREL flag > > Signed-off-by: André Hentschel <nerv(a)dawncrow.de> > --- > tools/winebuild/import.c | 34 ++++++++++++++-------------------- > tools/winebuild/spec32.c | 4 ++-- > 2 files changed, 16 insertions(+), 22 deletions(-) Signed-off-by: Martin Storsjo <martin(a)martin.st> // Martin

1 0

Re: [PATCH] msvcrt: Fix strcpy implementation so it works on overlapping buffers
by Ken Thomases 05 Aug '17

05 Aug '17

On Aug 5, 2017, at 10:43 AM, Piotr Caban <piotr(a)codeweavers.com> wrote: > +char* CDECL MSVCRT_strcpy(char *dst, const char *src) > +{ > + char *ret = dst; > + > + while(1) { > + *dst = *src; > + if (!*src) break; > + src++; > + *dst++; What's the dereference for? > + } > + > + return ret; > +} -Ken

2 1

Re: [4/6] wsdapi: Implement "Hello" message creation support. [try 3]
by Vincent Povirk 04 Aug '17

04 Aug '17

I think it would make more sense to do the initial random delay on the background threads.

2 2

Re: shell32: Implement SHCreateItemInKnownFolder.
by Huw Davies 04 Aug '17

04 Aug '17

On Sun, Jul 30, 2017 at 05:37:02PM +0800, Jactry Zeng wrote: > diff --git a/dlls/shell32/shellitem.c b/dlls/shell32/shellitem.c > index 1e19f7c72e..57fb849f16 100644 > --- a/dlls/shell32/shellitem.c > +++ b/dlls/shell32/shellitem.c > @@ -662,6 +662,66 @@ HRESULT WINAPI SHCreateItemFromIDList(PCIDLIST_ABSOLUTE pidl, REFIID riid, void > return ret; > } > > +HRESULT WINAPI SHCreateItemInKnownFolder(REFKNOWNFOLDERID rfid, DWORD flags, > + LPWSTR filename, REFIID riid, void **ppv) > +{ > + HRESULT hr; > + WCHAR *pathW = NULL; > + IShellFolder *desktop = NULL, *folder = NULL; > + LPITEMIDLIST pidl_folder = NULL, pidl = NULL; > + > + TRACE("%p, %x, %s, %s, %p\n", rfid, flags, wine_dbgstr_w(filename), > + debugstr_guid(riid), ppv); > + > + if(!rfid || !ppv) > + return E_INVALIDARG; > + > + if(flags) > + FIXME("flags 0x%08x not supported\n", flags); > + > + *ppv = NULL; > + hr = SHGetDesktopFolder(&desktop); > + if(hr != S_OK) return hr; > + > + hr = SHGetKnownFolderPath(rfid, 0, NULL, &pathW); > + if(hr != S_OK) return hr; > + > + hr = IShellFolder_ParseDisplayName(desktop, NULL, NULL, pathW, NULL, &pidl_folder, NULL); > + if(hr != S_OK) > + goto cleanup; You probably want to use SHGetKnownFolderIDList() instead of these last two calls. Huw.

2 3

Re: [4/4] kernel32/tests: Add tests for LoadLibrary with LIBRARY_SEARCH_* flags
by Marvin 03 Aug '17

03 Aug '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32575 Your paranoid android. === w2003std (32 bit module) === module.c:443: Test failed: Expected ERROR_MOD_NOT_FOUND or ERROR_DLL_NOT_FOUND (win9x), got 87 module.c:471: Test failed: Could not load test library testFlags.dll from C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\ module.c:472: Test failed: Expected 0xdeadbeef or ERROR_SUCCESS, got 87 module.c:481: Test failed: Expected ERROR_MOD_NOT_FOUND or ERROR_DLL_NOT_FOUND (win9x), got 87 module.c:496: Test failed: Library testFlags.dll was expected to be loaded from 'system32' module.c:497: Test failed: Expected 0xdeadbeef or ERROR_SUCCESS, got 87 module.c:505: Test failed: Library testFlags.dll was expected to be loaded from 'system32' module.c:506: Test failed: Expected 0xdeadbeef or ERROR_SUCCESS, got 87 === w7u (32 bit loader) === loader.c:2199: Test failed: expected WAIT_OBJECT_0, got 0x102 loader.c:2209: Test failed: expected thread exit code 196, got 259 loader.c:1713: Test failed: expected thread exit code 196, got 195

1 0

Re: [PATCH 2/2] winebrowser: Open the default browser if called without an argument.
by Alexandre Julliard 03 Aug '17

03 Aug '17

Zebediah Figura <zfigura(a)codeweavers.com> writes: > xdg-open can't handle this, so work around with the following command > (suggested by Vincent Povirk): > gtk-launch `xdg-mime query default x-scheme-handler/http` > > Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> > --- > programs/winebrowser/main.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) I'd suggest to simply open the default start page in that case. That's what iexplore does when there are no arguments. -- Alexandre Julliard julliard(a)winehq.org

3 5

Re: [1/2] msvcrt/tests: Add tests for mbstowcs and wcstombs with empty strings.
by Piotr Caban 03 Aug '17

03 Aug '17

Hi, the patch causes compilation warnings on 64-bit wine. ../../../../wine_src/dlls/msvcrt/tests/string.c: In function 'test_mbstowcs': ../../../../wine_src/dlls/msvcrt/tests/string.c:1869:123: warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t {aka long unsigned int}' [-Wformat=] ../../../../wine_src/dlls/msvcrt/tests/string.c:1872:123: warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t {aka long unsigned int}' [-Wformat=] ../../../../wine_src/dlls/msvcrt/tests/string.c:1887:123: warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t {aka long unsigned int}' [-Wformat=] ../../../../wine_src/dlls/msvcrt/tests/string.c:1890:123: warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t {aka long unsigned int}' [-Wformat=] ../../../../wine_src/dlls/msvcrt/tests/string.c:1903:228: warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t {aka long unsigned int}' [-Wformat=] ../../../../wine_src/dlls/msvcrt/tests/string.c:1911:123: warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t {aka long unsigned int}' [-Wformat=] ../../../../wine_src/dlls/msvcrt/tests/string.c:1932:228: warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t {aka long unsigned int}' [-Wformat=] ../../../../wine_src/dlls/msvcrt/tests/string.c:1951:123: warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t {aka long unsigned int}' [-Wformat=] Thanks, Piotr

1 0

Re: ntdll: Support receiving server reply data to memory with write watch.
by Alexandre Julliard 03 Aug '17

03 Aug '17

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -256,6 +256,7 @@ static void read_reply_data( void *buffer, size_t size ) > if (!ret) break; > if (errno == EINTR) continue; > if (errno == EPIPE) break; > + if (errno == EFAULT && virtual_uninterrupted_write_memory( buffer, NULL, size ) >= size) continue; > server_protocol_perror("read"); You can't enter a critical section in the middle of a server call. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH v3] ole32: Store proxy/stub CLSIDs per process, not per apartment.
by Huw Davies 03 Aug '17

03 Aug '17

On Wed, Aug 02, 2017 at 11:00:04AM -0500, Zebediah Figura wrote: > +static void COM_RevokeAllPSClsids(void) > +{ How about calling it revoke_registered_psclsids() ? Otherwise, this looks good. Huw.

1 0