November 2018 - Wine-devel - list.winehq.org

[PATCH vkd3d 1/5] vkd3d: Do not set VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT for multisample textures.
by Józef Kucia 26 Nov '18

26 Nov '18

From: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- libs/vkd3d/resource.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libs/vkd3d/resource.c b/libs/vkd3d/resource.c index 56af01002485..31883f6e91aa 100644 --- a/libs/vkd3d/resource.c +++ b/libs/vkd3d/resource.c @@ -518,7 +518,8 @@ static HRESULT vkd3d_create_image(struct d3d12_device *device, if (!(desc->Flags & D3D12_RESOURCE_FLAG_ALLOW_DEPTH_STENCIL) && dxgi_format_is_typeless(desc->Format)) image_info.flags |= VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT; if (desc->Dimension == D3D12_RESOURCE_DIMENSION_TEXTURE2D - && desc->Width == desc->Height && desc->DepthOrArraySize >= 6) + && desc->Width == desc->Height && desc->DepthOrArraySize >= 6 + && desc->SampleDesc.Count == 1) image_info.flags |= VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT; if (desc->Dimension == D3D12_RESOURCE_DIMENSION_TEXTURE3D) image_info.flags |= VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT_KHR; -- 2.18.1

2 1

[PATCH] testbot: Provide the missions list to the Reconfig scripts.
by Francois Gouget 26 Nov '18

26 Nov '18

The scripts need it to know which builds to update. A Wine VM may only need to update the win32 build for instance, but may have to recreate wineprefixes for multiple locales. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/bin/WineRunReconfig.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/testbot/bin/WineRunReconfig.pl b/testbot/bin/WineRunReconfig.pl index 4d50a3789a..2a8b1d625d 100755 --- a/testbot/bin/WineRunReconfig.pl +++ b/testbot/bin/WineRunReconfig.pl @@ -46,6 +46,7 @@ use WineTestBot::Jobs; use WineTestBot::VMs; use WineTestBot::Log; use WineTestBot::LogUtils; +use WineTestBot::Missions; use WineTestBot::Engine::Notify; @@ -345,7 +346,7 @@ my $Script = $VM->Type eq "wine" ? "WineReconfig.pl" : "Reconfig.pl"; $Script = "#!/bin/sh\n". "( set -x\n". " echo git pull &&\n". - " ../bin/build/$Script\n". + " ../bin/build/$Script ". MergeMissionStatementTasks($Task->Missions) ."\n". ") >Reconfig.log 2>&1\n"; my $TA = $VM->GetAgent(); Debug(Elapsed($Start), " Sending the script: [$Script]\n"); -- 2.19.1

1 0

[PATCH 1/2] testbot: There is no 'build' mission.
by Francois Gouget 26 Nov '18

26 Nov '18

Build tasks need to be told what type of executable to build and thus expect 'exe32' and/or 'exe64' missions. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/lib/WineTestBot/Missions.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/testbot/lib/WineTestBot/Missions.pm b/testbot/lib/WineTestBot/Missions.pm index dcaeb31d1d..9761a5a88f 100644 --- a/testbot/lib/WineTestBot/Missions.pm +++ b/testbot/lib/WineTestBot/Missions.pm @@ -108,7 +108,6 @@ sub GetTaskMissionDescription($) my $Builds = $TaskMission->{Builds}; my $Description = - $Builds->{build} ? "build" : ($Builds->{exe64} and ($Builds->{exe32} or $Builds->{exe32})) ? "32 & 64 bit executable" : $Builds->{exe32} ? "32 bit executable" : $Builds->{exe64} ? "64 bit executable" : -- 2.19.1

1 1

[PATCH v2] dsound: Close sleepev handle after releasing audio client.
by Jacek Caban 26 Nov '18

26 Nov '18

It's used as audio client event handle, so it shouldn't be closed as long as audio client is alive. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> --- v2: Fixed a typo in commit message. dlls/dsound/dsound.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

1 0

[PATCH 2/2] dsound: Wait on thread handle instead of dedicated event in DirectSoundDevice_Release.
by Jacek Caban 26 Nov '18

26 Nov '18

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/dsound/dsound.c | 4 +--- dlls/dsound/dsound_private.h | 1 - dlls/dsound/mixer.c | 1 - 3 files changed, 1 insertion(+), 5 deletions(-)

2 3

[PATCH 1/2] dsound: Close speepev handle after releasing audio client.
by Jacek Caban 26 Nov '18

26 Nov '18

It's used as audio client event handle, so it shouldn't be closed as long as audio client is alive. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/dsound/dsound.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

2 1

[Patch resend] server: Release of related atoms when destroying a window class
by Ralf Habacker 26 Nov '18

26 Nov '18

2 1

user32: Adds test to check if the corresponding atom is released after calling UnregisterClass().
by Ralf Habacker 26 Nov '18

26 Nov '18

2 1

server: Release of related atoms when destroying a window class
by Ralf Habacker 26 Nov '18

26 Nov '18

1 0

[PATCH v2 1/4] dbghelp: Avoid using inline assembly in do_x86cpuid().
by Zebediah Figura 26 Nov '18

26 Nov '18

Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> --- v2: save/restore the right register (thanks Chip). dlls/dbghelp/minidump.c | 31 +++++++++++++++++++------------ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/dlls/dbghelp/minidump.c b/dlls/dbghelp/minidump.c index 975bb45c9a..ee214b274d 100644 --- a/dlls/dbghelp/minidump.c +++ b/dlls/dbghelp/minidump.c @@ -542,20 +542,27 @@ static unsigned dump_modules(struct dump_context* dc, BOOL dump_elf) return sz; } -/* Calls cpuid with an eax of 'ax' and returns the 16 bytes in *p - * We are compiled with -fPIC, so we can't clobber ebx. - */ -static inline void do_x86cpuid(unsigned int ax, unsigned int *p) +extern void do_x86cpuid(unsigned int ax, unsigned int *p); + +#ifdef __i386__ +__ASM_GLOBAL_FUNC( do_x86cpuid, + "pushl %esi\n\t" + "pushl %ebx\n\t" + "movl 4(%esp),%eax\n\t" + "movl 8(%esp),%esi\n\t" + "cpuid\n\t" + "movl %eax,(%esi)\n\t" + "movl %ebx,4(%esi)\n\t" + "movl %ecx,8(%esi)\n\t" + "movl %edx,12(%esi)\n\t" + "popl %ebx\n\t" + "popl %esi\n\t" + "ret" ); +#else +void do_x86cpuid(unsigned int ax, unsigned int *p) { -#if defined(__GNUC__) && defined(__i386__) - __asm__("pushl %%ebx\n\t" - "cpuid\n\t" - "movl %%ebx, %%esi\n\t" - "popl %%ebx" - : "=a" (p[0]), "=S" (p[1]), "=c" (p[2]), "=d" (p[3]) - : "0" (ax)); -#endif } +#endif /* From xf86info havecpuid.c 1.11 */ static inline int have_x86cpuid(void) -- 2.14.1

3 8