December 2018 - Wine-devel - list.winehq.org

Wine staging 4.0-rc1 release
by Alistair Leslie-Hughes 09 Dec '18

09 Dec '18

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary of the past few weeks * Rebased to current wine 4.0-rc1 (805 patches are applied to wine vanilla) * Reviewed and upstreamed patches. Upstreamed (Either directly from staging or fixed with a similar patch). * dxgi: Implement setting and querying the gamma value of an output. * gdi32/tests: Add some additional tests for ExtExtOut on a path for an EMF DC. * gdi32: ExtTextOut on a path with bitmap font selected shouldn't fail. * gdi32/tests: Explicitly test BeginPath() return value in the metafile path tests. * gdi32: Improve detection of symbol charset for old truetype fonts. * kernelbase: Add semi-stub for PathCchCombineEx. * ntdll: Add RtlAddGrowableFunctionTable stub. * ntdll: Add RtlGrowFunctionTable stub. * ntdll: Add stub for RtlGetUnloadEventTraceEx. * ntoskrnl.exe: Implement KeWaitForMultipleObjects(). * ntoskrnl.exe: Implement KeInitializeEvent(). * ntoskrnl.exe: Implement KeSetEvent(). * ntoskrnl.exe: Implement KeResetEvent(). * ntoskrnl.exe: Implement KeWaitForSingleObject(). * ntoskrnl.exe: Implement KeClearEvent(). * ntoskrnl.exe: Implement KeInitializeSemaphore(). * ntoskrnl.exe: Implement KeReleaseSemaphore() and waiting on semaphores. * ntoskrnl.exe: Implement KeInitializeMutex(). * ntoskrnl.exe: Implement KeReleaseMutex() and waiting on mutexes. * ntoskrnl.exe: Implement KeWaitForMutexObject(). * ntoskrnl.exe/tests: Add some tests for synchronization functions. * ntoskrnl.exe: Implement KeInitializeTimerEx(). * ntoskrnl.exe: Implement KeSetTimerEx() and waiting on timers. * ntoskrnl.exe: Implement KeCancelTimer(). * ntoskrnl.exe/tests: Add tests for waiting on timers. * ntoskrnl.exe: Implement KeDelayExecutionThread(). * oleaut32: Accept DISP_E_PARAMNOTFOUND for missing optional parameters in ITypeInfo::Invoke implementation. * user32: Move the auto radio button group logic from BM_SETCHECK to WM_LBUTTONUP handler. * user32/tests: Add a message test for group of radio buttons. * user32: Don't force a combobox repaint on WM_SIZE. * user32/tests: Simplify the test for BM_CLICK on autoradio button by using a dialog. * user32/tests: Add a test for navigating a group of buttons using keyboard events. * user32: Add support for navigating a group of radio buttons using a keyboard. * user32/tests: Add a focus test for an empty dialog that returns TRUE in WM_INITDIALOG. * user32: If there is no dialog controls to set focus to then set focus to dialog itself. * windowscodecs: Use V_UI1() instead of V_UNION() to assign a VT_UI1 variant member. * windowscodecs: Limit number of colors in a palette in BMP decoder. * windowscodecs: find_decoder() should return an error it received from the decoder. * windowscodecs: PNG decoder should return WINCODEC_ERR_UNKNOWNIMAGEFORMAT when image loading fails. * windowscodecs: Add registration for GUID_WICPixelFormat32bppGrayFloat pixel format. * windowscodecs: Implement IWICBitmapDecoder::GetMetadataQueryReader in the TIFF decoder. * windowscodecs: Improve stub for IWICBitmapDecoder::GetMetadataQueryReader in the PNG decoder. * windowscodecs/tests: Add some tests for IWICPalette::InitializeFromBitmap. * winhttp: Fix handling of Accept headers. * libs/wine: Do not restrict base address of main thread on 64 bit mac os. * loader: Implement preloader for Mac OS. Added * [45696] shell32: Generate icons from available icons if required. * [46215] user32: File Open Dialog fails to set focus to Filename text box Updated: * ddraw-Rendering_Targets * qwave-QOSCreateHandle * dwrite-FontFallback * winepulse-PulseAudio_Support Where can you help * Run Steam/Battle.net/UPlay. * Try you favorite game: * Test your favorite applications. * Steal staging patches and get them accepted upstream. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

[PATCH] shell32: Avoid an unneeded strlenW() call.
by Francois Gouget 09 Dec '18

09 Dec '18

Signed-off-by: Francois Gouget <fgouget(a)free.fr> --- Note that command is a buffer and cannot be NULL. dlls/shell32/shlexec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/shell32/shlexec.c b/dlls/shell32/shlexec.c index aca02d74888..28f2e36f9a7 100644 --- a/dlls/shell32/shlexec.c +++ b/dlls/shell32/shlexec.c @@ -736,7 +736,7 @@ static UINT SHELL_FindExecutable(LPCWSTR lpPath, LPCWSTR lpFile, LPCWSTR lpVerb, extension++; if (GetProfileStringW(wExtensions, extension, wszEmpty, command, ARRAY_SIZE(command)) > 0) { - if (strlenW(command) != 0) + if (*command) { strcpyW(lpResult, command); tok = strchrW(lpResult, '^'); /* should be ^.extension? */ -- 2.19.2

2 1

[PATCH] rpcrt4/tests: Make create_server_process() static.
by Francois Gouget 09 Dec '18

09 Dec '18

Signed-off-by: Francois Gouget <fgouget(a)free.fr> --- dlls/rpcrt4/tests/server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/rpcrt4/tests/server.c b/dlls/rpcrt4/tests/server.c index 587dc45333b..89cf514ea1e 100644 --- a/dlls/rpcrt4/tests/server.c +++ b/dlls/rpcrt4/tests/server.c @@ -1973,7 +1973,7 @@ static void test_server_listening(void) ok(status == RPC_S_OK, "RpcStringFree\n"); } -HANDLE create_server_process(void) +static HANDLE create_server_process(void) { SECURITY_ATTRIBUTES sec_attr = { sizeof(sec_attr), NULL, TRUE }; HANDLE ready_event; -- 2.19.2

1 0

[PATCH] user32/tests: Make test_LoadImage_working_directory_run() static.
by Francois Gouget 09 Dec '18

09 Dec '18

Signed-off-by: Francois Gouget <fgouget(a)free.fr> --- dlls/user32/tests/cursoricon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/user32/tests/cursoricon.c b/dlls/user32/tests/cursoricon.c index 405856c77b7..323db82bc36 100644 --- a/dlls/user32/tests/cursoricon.c +++ b/dlls/user32/tests/cursoricon.c @@ -1203,7 +1203,7 @@ static void create_ico_file(const char *filename, const test_icon_entries_t *tes HeapFree(GetProcessHeap(), 0, buf); } -void test_LoadImage_working_directory_run(char *path) +static void test_LoadImage_working_directory_run(char *path) { DWORD bytes_written; HANDLE handle; -- 2.19.2

1 0

[PATCH] dbghelp: Make symt_get_best_at() static.
by Francois Gouget 09 Dec '18

09 Dec '18

Signed-off-by: Francois Gouget <fgouget(a)free.fr> --- dlls/dbghelp/symbol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/dbghelp/symbol.c b/dlls/dbghelp/symbol.c index c9585c5e714..96a1f8743c4 100644 --- a/dlls/dbghelp/symbol.c +++ b/dlls/dbghelp/symbol.c @@ -851,7 +851,7 @@ static void symt_get_length(struct module* module, const struct symt* symt, ULON } /* neede by symt_find_nearest */ -int symt_get_best_at(struct module* module, int idx_sorttab) +static int symt_get_best_at(struct module* module, int idx_sorttab) { ULONG64 ref_addr; int idx_sorttab_orig = idx_sorttab; -- 2.19.2

1 0

[PATCH] wined3d: Use NULL instead of casting 0
by Michael Stefaniuc 07 Dec '18

07 Dec '18

Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/wined3d/query.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/wined3d/query.c b/dlls/wined3d/query.c index d4e7cf5b37..0b54d287f3 100644 --- a/dlls/wined3d/query.c +++ b/dlls/wined3d/query.c @@ -100,7 +100,7 @@ static BOOL wined3d_query_buffer_queue_result(struct wined3d_context *context, s GL_EXTCALL(glBindBuffer(GL_QUERY_BUFFER, query->buffer_object)); /* Read the same value twice. We know we have the result if map_ptr[0] == map_ptr[1]. */ - GL_EXTCALL(glGetQueryObjectui64v(id, GL_QUERY_RESULT, (void *)0)); + GL_EXTCALL(glGetQueryObjectui64v(id, GL_QUERY_RESULT, NULL)); GL_EXTCALL(glGetQueryObjectui64v(id, GL_QUERY_RESULT, (void *)sizeof(query->map_ptr[0]))); GL_EXTCALL(glBindBuffer(GL_QUERY_BUFFER, 0)); checkGLcall("queue query result"); -- 2.19.2

2 2

[PATCH] ntoskrnl.exe/tests: Use NULL instead of casting 0
by Michael Stefaniuc 07 Dec '18

07 Dec '18

Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/ntoskrnl.exe/tests/driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/ntoskrnl.exe/tests/driver.c b/dlls/ntoskrnl.exe/tests/driver.c index 17e54cd508..8f41d39747 100644 --- a/dlls/ntoskrnl.exe/tests/driver.c +++ b/dlls/ntoskrnl.exe/tests/driver.c @@ -435,7 +435,7 @@ static void test_sync(void) ok(ret == i - 9, "expected %d, got %d\n", i - 9, ret); } - run_thread(mutex_thread, (void *)0); + run_thread(mutex_thread, NULL); ret = wait_single(&test_mutex, 0); ok(ret == 0, "got %#x\n", ret); @@ -445,7 +445,7 @@ static void test_sync(void) ret = KeReleaseMutex(&test_mutex, 0); ok(ret == 0, "got %#x\n", ret); - run_thread(mutex_thread, (void *)0); + run_thread(mutex_thread, NULL); /* test timers */ KeInitializeTimerEx(&timer, NotificationTimer); -- 2.19.2

3 4

[PATCH] configure: Fix building of the preloader on the Mac using Xcode 10 or later.
by Ken Thomases 07 Dec '18

07 Dec '18

The linker that comes with Xcode 10 requires that libSystem be linked for dynamic executables (those using dyld) unless -mmacosx-version-min=10.7 (or earlier) is used. Signed-off-by: Ken Thomases <ken(a)codeweavers.com> --- This suggests that the future is grim for the approach taken for the Mac preloader. This is a stopgap measure. We've filed a bug with Apple asking that this capability be restored or, failing that, that they provide another way to do the address space reservations we need before system libraries can interfere. The alternative is to revert the Mac preloader implementation. configure.ac | 36 +++++++++++++++++++++++++++++------- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/configure.ac b/configure.ac index 08fbc3c..26fc392 100644 --- a/configure.ac +++ b/configure.ac @@ -717,6 +717,7 @@ wine_binary="wine" test "x$enable_win64" != "xyes" || wine_binary="wine64" AC_SUBST(WINELOADER_PROGRAMS,"$wine_binary") libwine_soversion=`expr $libwine_version : '$[[0-9]]*$\..*'` +wine_can_build_preloader=yes case $host_os in cygwin*|mingw32*) @@ -772,9 +773,20 @@ case $host_os in WINEPRELOADER_LDFLAGS="-nostartfiles -nodefaultlibs -e _start -ldylib1.o -Wl,-image_base,0x7c400000,-pagezero_size,0x1000,-sectcreate,__TEXT,__info_plist,wine_info.plist" WINE_TRY_CFLAGS([-Wl,-no_new_main -e _main], - [WINEPRELOADER_LDFLAGS="-Wl,-no_new_main $WINEPRELOADER_LDFLAGS"]) - WINE_TRY_CFLAGS([-Wl,-no_pie], - [WINEPRELOADER_LDFLAGS="-Wl,-no_pie $WINEPRELOADER_LDFLAGS"]) + [WINEPRELOADER_LDFLAGS="-Wl,-no_new_main $WINEPRELOADER_LDFLAGS" + WINE_TRY_CFLAGS([-Wl,-no_new_main -e _main -nostartfiles -nodefaultlibs],, + [WINE_TRY_CFLAGS([-Wl,-no_new_main -e _main -mmacosx-version-min=10.7 -nostartfiles -nodefaultlibs], + [WINEPRELOADER_LDFLAGS="-mmacosx-version-min=10.7 $WINEPRELOADER_LDFLAGS"], + [wine_can_build_preloader=no])])], + [WINE_TRY_CFLAGS([-nostartfiles -nodefaultlibs],, + [WINE_TRY_CFLAGS([-mmacosx-version-min=10.7 -nostartfiles -nodefaultlibs], + [WINEPRELOADER_LDFLAGS="-mmacosx-version-min=10.7 $WINEPRELOADER_LDFLAGS"], + [wine_can_build_preloader=no])])]) + if test "$wine_can_build_preloader" = "yes" + then + WINE_TRY_CFLAGS([-Wl,-no_pie], + [WINEPRELOADER_LDFLAGS="-Wl,-no_pie $WINEPRELOADER_LDFLAGS"]) + fi if test "$ac_cv_header_DiskArbitration_DiskArbitration_h" = "yes" then @@ -2110,25 +2122,35 @@ case $build_os in cygwin*|mingw32*) AC_SUBST(TOOLSEXT,".exe") ;; esac +wine_want_preloader=no case $host_os in linux*) case $host_cpu in *i[[3456789]]86*|x86_64*|*aarch64*) - test "$wine_binary" = wine || WINE_IGNORE_FILE("loader/wine-preloader") - WINELOADER_PROGRAMS="$WINELOADER_PROGRAMS $wine_binary-preloader" + wine_want_preloader=yes ;; esac ;; darwin*|macosx*) case $host_cpu in *i[[3456789]]86*|x86_64*) - test "$wine_binary" = wine || WINE_IGNORE_FILE("loader/wine-preloader") - WINELOADER_PROGRAMS="$WINELOADER_PROGRAMS $wine_binary-preloader" + wine_want_preloader=yes ;; esac ;; esac +if test "$wine_want_preloader" = "yes" +then + if test "$wine_can_build_preloader" = "yes" + then + test "$wine_binary" = wine || WINE_IGNORE_FILE("loader/wine-preloader") + WINELOADER_PROGRAMS="$WINELOADER_PROGRAMS $wine_binary-preloader" + else + WINE_WARNING([can't build Wine preloader; many programs won't work]) + fi +fi + dnl **** Check for functions **** ac_save_CFLAGS="$CFLAGS" -- 2.10.2

1 0

[PATCH] shell32: Use SetRect() instead of open coding it
by Michael Stefaniuc 07 Dec '18

07 Dec '18

Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/shell32/ebrowser.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/dlls/shell32/ebrowser.c b/dlls/shell32/ebrowser.c index 2d5a30aabb..637104c58d 100644 --- a/dlls/shell32/ebrowser.c +++ b/dlls/shell32/ebrowser.c @@ -314,9 +314,7 @@ static void update_layout(ExplorerBrowserImpl *This) if(navpane_width_actual) { - This->navpane.rc.left = This->navpane.rc.top = 0; - This->navpane.rc.right = navpane_width_actual; - This->navpane.rc.bottom = rc.bottom; + SetRect(&This->navpane.rc, 0, 0, navpane_width_actual, rc.bottom); if(!This->navpane.hwnd_splitter) initialize_navpane(This, This->hwnd_main, &This->navpane.rc); @@ -324,10 +322,8 @@ static void update_layout(ExplorerBrowserImpl *This) else ZeroMemory(&This->navpane.rc, sizeof(RECT)); - This->sv_rc.left = navpane_width_actual; - This->sv_rc.top = 0; - This->sv_rc.right = This->sv_rc.left + shellview_width_actual; - This->sv_rc.bottom = rc.bottom; + SetRect(&This->sv_rc, navpane_width_actual, 0, navpane_width_actual + shellview_width_actual, + rc.bottom); } static void size_panes(ExplorerBrowserImpl *This) -- 2.19.2

1 0

[PATCH] wined3d: Use GL_LINEAR for unsupported filter types.
by Józef Kucia 07 Dec '18

07 Dec '18

Linear filtering is a much more appropriate fallback for more advanced filtering types. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41929 Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- dlls/wined3d/surface.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index 85f94899cd60..3441f018f417 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -169,16 +169,16 @@ static void texture2d_blt_fbo(const struct wined3d_device *device, struct wined3 switch (filter) { - case WINED3D_TEXF_LINEAR: - gl_filter = GL_LINEAR; + case WINED3D_TEXF_NONE: + case WINED3D_TEXF_POINT: + gl_filter = GL_NEAREST; break; default: FIXME("Unsupported filter mode %s (%#x).\n", debug_d3dtexturefiltertype(filter), filter); /* fall through */ - case WINED3D_TEXF_NONE: - case WINED3D_TEXF_POINT: - gl_filter = GL_NEAREST; + case WINED3D_TEXF_LINEAR: + gl_filter = GL_LINEAR; break; } -- 2.19.2

3 3