July 2018 - Wine-devel - list.winehq.org

[PATCH] wineconsole: Use the ARRAY_SIZE() macro
by Michael Stefaniuc 13 Jul '18

13 Jul '18

Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- programs/wineconsole/curses.c | 2 +- programs/wineconsole/dialog.c | 23 +++++++++-------------- programs/wineconsole/user.c | 18 +++++++++--------- programs/wineconsole/wineconsole.c | 2 +- 4 files changed, 20 insertions(+), 25 deletions(-) diff --git a/programs/wineconsole/curses.c b/programs/wineconsole/curses.c index 7413c8f00f..6c35554d84 100644 --- a/programs/wineconsole/curses.c +++ b/programs/wineconsole/curses.c @@ -340,7 +340,7 @@ static void WCCURSES_SetTitle(const struct inner_data* data) { WCHAR wbuf[256]; - if (WINECON_GetConsoleTitle(data->hConIn, wbuf, sizeof(wbuf)/sizeof(WCHAR))) + if (WINECON_GetConsoleTitle(data->hConIn, wbuf, ARRAY_SIZE(wbuf))) { char buffer[256]; diff --git a/programs/wineconsole/dialog.c b/programs/wineconsole/dialog.c index 9a14184ba4..898812553a 100644 --- a/programs/wineconsole/dialog.c +++ b/programs/wineconsole/dialog.c @@ -208,12 +208,10 @@ static LRESULT WINAPI WCUSER_FontPreviewProc(HWND hWnd, UINT msg, WPARAM wParam, FillRect(ps.hdc, &ps.rcPaint, CreateSolidBrush(bkcolor)); SetBkColor(ps.hdc, bkcolor); SetTextColor(ps.hdc, get_color(di, IDC_FNT_COLOR_FG)); - len = LoadStringW(GetModuleHandleW(NULL), IDS_FNT_PREVIEW, - buf, sizeof(buf) / sizeof(buf[0])); + len = LoadStringW(GetModuleHandleW(NULL), IDS_FNT_PREVIEW, buf, ARRAY_SIZE(buf)); if (len) TextOutW(ps.hdc, 0, 0, buf, len); - TextOutW(ps.hdc, 0, di->font[size_idx].height, ascii, - sizeof(ascii)/sizeof(ascii[0]) - 1); + TextOutW(ps.hdc, 0, di->font[size_idx].height, ascii, ARRAY_SIZE(ascii) - 1); SelectObject(ps.hdc, hOldFont); } EndPaint(hWnd, &ps); @@ -366,7 +364,7 @@ static int CALLBACK font_enum_size(const LOGFONTW* lf, const TEXTMETRICW* tm, static const int sizes[] = {8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72}; int i; - di->nFont = sizeof(sizes) / sizeof(sizes[0]); + di->nFont = ARRAY_SIZE(sizes); di->font = HeapAlloc(GetProcessHeap(), 0, di->nFont * sizeof(di->font[0])); for (i = 0; i < di->nFont; i++) { @@ -459,11 +457,11 @@ static BOOL select_font(struct dialog_info* di) SendDlgItemMessageW(di->hDlg, IDC_FNT_PREVIEW, WM_SETFONT, (WPARAM)hFont, TRUE); if (hOldFont) DeleteObject(hOldFont); - LoadStringW(GetModuleHandleW(NULL), IDS_FNT_DISPLAY, fmt, sizeof(fmt) / sizeof(fmt[0])); + LoadStringW(GetModuleHandleW(NULL), IDS_FNT_DISPLAY, fmt, ARRAY_SIZE(fmt)); args[0] = config.cell_width; args[1] = config.cell_height; FormatMessageW(FORMAT_MESSAGE_FROM_STRING|FORMAT_MESSAGE_ARGUMENT_ARRAY, - fmt, 0, 0, buf, sizeof(buf)/sizeof(*buf), (__ms_va_list*)args); + fmt, 0, 0, buf, ARRAY_SIZE(buf), (__ms_va_list*)args); SendDlgItemMessageW(di->hDlg, IDC_FNT_FONT_INFO, WM_SETTEXT, 0, (LPARAM)buf); @@ -687,10 +685,8 @@ static INT_PTR WINAPI WCUSER_ConfigDlgProc(HWND hDlg, UINT msg, WPARAM wParam, L WCHAR cap[256]; WCHAR txt[256]; - LoadStringW(GetModuleHandleW(NULL), IDS_DLG_TIT_ERROR, - cap, sizeof(cap) / sizeof(cap[0])); - LoadStringW(GetModuleHandleW(NULL), IDS_DLG_ERR_SBWINSIZE, - txt, sizeof(txt) / sizeof(cap[0])); + LoadStringW(GetModuleHandleW(NULL), IDS_DLG_TIT_ERROR, cap, ARRAY_SIZE(cap)); + LoadStringW(GetModuleHandleW(NULL), IDS_DLG_ERR_SBWINSIZE, txt, ARRAY_SIZE(txt)); MessageBoxW(hDlg, txt, cap, MB_OK); SetWindowLongPtrW(hDlg, DWLP_MSGRESULT, PSNRET_INVALID); @@ -831,9 +827,8 @@ BOOL WCUSER_GetProperties(struct inner_data* data, BOOL current) memset(&psHead, 0, sizeof(psHead)); psHead.dwSize = sizeof(psHead); - if (!LoadStringW(GetModuleHandleW(NULL), - (current) ? IDS_DLG_TIT_CURRENT : IDS_DLG_TIT_DEFAULT, - buff, sizeof(buff) / sizeof(buff[0]))) + if (!LoadStringW(GetModuleHandleW(NULL), (current) ? IDS_DLG_TIT_CURRENT : IDS_DLG_TIT_DEFAULT, + buff, ARRAY_SIZE(buff))) { buff[0] = 'S'; buff[1] = 'e'; diff --git a/programs/wineconsole/user.c b/programs/wineconsole/user.c index 03d0ea18e6..0b29157ef9 100644 --- a/programs/wineconsole/user.c +++ b/programs/wineconsole/user.c @@ -823,25 +823,25 @@ static BOOL WCUSER_FillMenu(HMENU hMenu, BOOL sep) hSubMenu = CreateMenu(); if (!hSubMenu) return FALSE; - LoadStringW(hInstance, IDS_MARK, buff, sizeof(buff) / sizeof(buff[0])); + LoadStringW(hInstance, IDS_MARK, buff, ARRAY_SIZE(buff)); InsertMenuW(hSubMenu, -1, MF_BYPOSITION|MF_STRING, IDS_MARK, buff); - LoadStringW(hInstance, IDS_COPY, buff, sizeof(buff) / sizeof(buff[0])); + LoadStringW(hInstance, IDS_COPY, buff, ARRAY_SIZE(buff)); InsertMenuW(hSubMenu, -1, MF_BYPOSITION|MF_STRING, IDS_COPY, buff); - LoadStringW(hInstance, IDS_PASTE, buff, sizeof(buff) / sizeof(buff[0])); + LoadStringW(hInstance, IDS_PASTE, buff, ARRAY_SIZE(buff)); InsertMenuW(hSubMenu, -1, MF_BYPOSITION|MF_STRING, IDS_PASTE, buff); - LoadStringW(hInstance, IDS_SELECTALL, buff, sizeof(buff) / sizeof(buff[0])); + LoadStringW(hInstance, IDS_SELECTALL, buff, ARRAY_SIZE(buff)); InsertMenuW(hSubMenu, -1, MF_BYPOSITION|MF_STRING, IDS_SELECTALL, buff); - LoadStringW(hInstance, IDS_SCROLL, buff, sizeof(buff) / sizeof(buff[0])); + LoadStringW(hInstance, IDS_SCROLL, buff, ARRAY_SIZE(buff)); InsertMenuW(hSubMenu, -1, MF_BYPOSITION|MF_STRING, IDS_SCROLL, buff); - LoadStringW(hInstance, IDS_SEARCH, buff, sizeof(buff) / sizeof(buff[0])); + LoadStringW(hInstance, IDS_SEARCH, buff, ARRAY_SIZE(buff)); InsertMenuW(hSubMenu, -1, MF_BYPOSITION|MF_STRING, IDS_SEARCH, buff); if (sep) InsertMenuW(hMenu, -1, MF_BYPOSITION|MF_SEPARATOR, 0, NULL); - LoadStringW(hInstance, IDS_EDIT, buff, sizeof(buff) / sizeof(buff[0])); + LoadStringW(hInstance, IDS_EDIT, buff, ARRAY_SIZE(buff)); InsertMenuW(hMenu, -1, MF_BYPOSITION|MF_STRING|MF_POPUP, (UINT_PTR)hSubMenu, buff); - LoadStringW(hInstance, IDS_DEFAULT, buff, sizeof(buff) / sizeof(buff[0])); + LoadStringW(hInstance, IDS_DEFAULT, buff, ARRAY_SIZE(buff)); InsertMenuW(hMenu, -1, MF_BYPOSITION|MF_STRING, IDS_DEFAULT, buff); - LoadStringW(hInstance, IDS_PROPERTIES, buff, sizeof(buff) / sizeof(buff[0])); + LoadStringW(hInstance, IDS_PROPERTIES, buff, ARRAY_SIZE(buff)); InsertMenuW(hMenu, -1, MF_BYPOSITION|MF_STRING, IDS_PROPERTIES, buff); return TRUE; diff --git a/programs/wineconsole/wineconsole.c b/programs/wineconsole/wineconsole.c index 9e3afb19c2..439099c37a 100644 --- a/programs/wineconsole/wineconsole.c +++ b/programs/wineconsole/wineconsole.c @@ -45,7 +45,7 @@ static void printf_res(UINT uResId, ...) va_list args; va_start(args, uResId); - LoadStringW(GetModuleHandleW(NULL), uResId, buffer, sizeof(buffer)/sizeof(buffer[0])); + LoadStringW(GetModuleHandleW(NULL), uResId, buffer, ARRAY_SIZE(buffer)); WideCharToMultiByte(CP_UNIXCP, 0, buffer, -1, ansi, sizeof(ansi), NULL, NULL); vprintf(ansi, args); va_end(args); -- 2.14.4

1 0

[PATCH] winemine: Use the ARRAY_SIZE() macro
by Michael Stefaniuc 13 Jul '18

13 Jul '18

Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- programs/winemine/dialog.c | 9 ++++----- programs/winemine/main.c | 10 +++++----- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/programs/winemine/dialog.c b/programs/winemine/dialog.c index c182e91e69..4741241338 100644 --- a/programs/winemine/dialog.c +++ b/programs/winemine/dialog.c @@ -69,9 +69,8 @@ INT_PTR CALLBACK CongratsDlgProc( HWND hDlg, UINT uMsg, WPARAM wParam, LPARAM lP case WM_COMMAND: switch( LOWORD( wParam ) ) { case IDOK: - GetDlgItemTextW( hDlg, IDC_EDITNAME, - p_board->best_name[p_board->difficulty], - sizeof( p_board->best_name[p_board->difficulty] ) / sizeof(WCHAR) ); + GetDlgItemTextW( hDlg, IDC_EDITNAME, p_board->best_name[p_board->difficulty], + ARRAY_SIZE(p_board->best_name[p_board->difficulty] )); EndDialog( hDlg, 0 ); return TRUE; @@ -107,8 +106,8 @@ INT_PTR CALLBACK TimesDlgProc( HWND hDlg, UINT uMsg, WPARAM wParam, LPARAM lPara case WM_COMMAND: switch( LOWORD( wParam ) ) { case IDC_RESET: - LoadStringW( NULL, IDC_CONFIRMTITLE, confirm_title, sizeof(confirm_title)/sizeof(WCHAR) ); - LoadStringW( NULL, IDC_CONFIRMTEXT, confirm_text, sizeof(confirm_text)/sizeof(WCHAR) ); + LoadStringW( NULL, IDC_CONFIRMTITLE, confirm_title, ARRAY_SIZE(confirm_title)); + LoadStringW( NULL, IDC_CONFIRMTEXT, confirm_text, ARRAY_SIZE(confirm_text)); confirm_msgbox_result = MessageBoxW( hDlg, confirm_text, confirm_title, MB_OKCANCEL | MB_DEFBUTTON2 | MB_ICONWARNING ); if( confirm_msgbox_result != IDOK ) break; diff --git a/programs/winemine/main.c b/programs/winemine/main.c index 5bec84cb32..255d21714f 100644 --- a/programs/winemine/main.c +++ b/programs/winemine/main.c @@ -112,7 +112,7 @@ static void LoadBoard( BOARD *p_board ) size = sizeof( data ); if( RegQueryValueExW( hkey, key_name, NULL, &type, (LPBYTE) data, &size ) == ERROR_SUCCESS ) - lstrcpynW( p_board->best_name[i], data, sizeof(p_board->best_name[i])/sizeof(WCHAR) ); + lstrcpynW( p_board->best_name[i], data, ARRAY_SIZE(p_board->best_name[i])); else LoadStringW( p_board->hInst, IDS_NOBODY, p_board->best_name[i], MAX_PLAYER_NAME_SIZE+1 ); } @@ -179,7 +179,7 @@ void SaveBoard( BOARD *p_board ) for( i = 0; i < 3; i++ ) { wsprintfW( key_name, nameW, i+1 ); - lstrcpynW( data, p_board->best_name[i], sizeof(data)/sizeof(WCHAR) ); + lstrcpynW( data, p_board->best_name[i], ARRAY_SIZE(data)); RegSetValueExW( hkey, key_name, 0, REG_SZ, (LPBYTE) data, (lstrlenW(data)+1) * sizeof(WCHAR) ); } @@ -1003,8 +1003,8 @@ static LRESULT WINAPI MainProc( HWND hWnd, UINT msg, WPARAM wParam, LPARAM lPara case IDM_ABOUT: { WCHAR appname[256], other[256]; - LoadStringW( board.hInst, IDS_APPNAME, appname, sizeof(appname)/sizeof(WCHAR) ); - LoadStringW( board.hInst, IDS_ABOUT, other, sizeof(other)/sizeof(WCHAR) ); + LoadStringW( board.hInst, IDS_APPNAME, appname, ARRAY_SIZE(appname)); + LoadStringW( board.hInst, IDS_ABOUT, other, ARRAY_SIZE(other)); ShellAboutW( hWnd, appname, other, LoadImageW(board.hInst, MAKEINTRESOURCEW(IDI_WINEMINE), IMAGE_ICON, 48, 48, LR_SHARED)); return 0; @@ -1025,7 +1025,7 @@ int WINAPI wWinMain( HINSTANCE hInst, HINSTANCE hPrevInst, LPWSTR cmdline, int c HACCEL haccel; WCHAR appname[20]; - LoadStringW( hInst, IDS_APPNAME, appname, sizeof(appname)/sizeof(WCHAR)); + LoadStringW( hInst, IDS_APPNAME, appname, ARRAY_SIZE(appname)); wc.cbSize = sizeof(wc); wc.style = 0; -- 2.14.4

1 0

[PATCH] dxerr9: Use the ARRAY_SIZE() macro
by Michael Stefaniuc 13 Jul '18

13 Jul '18

Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/dxerr9/dxerr9.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/dxerr9/dxerr9.c b/dlls/dxerr9/dxerr9.c index c65f48e391..e5b18610fe 100644 --- a/dlls/dxerr9/dxerr9.c +++ b/dlls/dxerr9/dxerr9.c @@ -55,7 +55,7 @@ const char * WINAPI DXGetErrorString9A(HRESULT hr) { unsigned int i, j, k = 0; - for (i = sizeof(info)/sizeof(info[0]); i != 0; i /= 2) { + for (i = ARRAY_SIZE(info); i != 0; i /= 2) { j = k + (i / 2); if (hr == info[j].hr) return info[j].resultA; @@ -73,7 +73,7 @@ const WCHAR * WINAPI DXGetErrorString9W(HRESULT hr) static const WCHAR unknown[] = { 'U', 'n', 'k', 'n', 'o', 'w', 'n', 0 }; unsigned int i, j, k = 0; - for (i = sizeof(info)/sizeof(info[0]); i != 0; i /= 2) { + for (i = ARRAY_SIZE(info); i != 0; i /= 2) { j = k + (i / 2); if (hr == info[j].hr) return info[j].resultW; @@ -90,7 +90,7 @@ const char * WINAPI DXGetErrorDescription9A(HRESULT hr) { unsigned int i, j, k = 0; - for (i = sizeof(info)/sizeof(info[0]); i != 0; i /= 2) { + for (i = ARRAY_SIZE(info); i != 0; i /= 2) { j = k + (i / 2); if (hr == info[j].hr) return info[j].descriptionA; @@ -108,7 +108,7 @@ const WCHAR * WINAPI DXGetErrorDescription9W(HRESULT hr) static const WCHAR na[] = { 'n', '/', 'a', 0 }; unsigned int i, j, k = 0; - for (i = sizeof(info)/sizeof(info[0]); i != 0; i /= 2) { + for (i = ARRAY_SIZE(info); i != 0; i /= 2) { j = k + (i / 2); if (hr == info[j].hr) return info[j].descriptionW; -- 2.14.4

1 0

[PATCH] dxerr8: Use the ARRAY_SIZE() macro
by Michael Stefaniuc 13 Jul '18

13 Jul '18

Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/dxerr8/dxerr8.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/dxerr8/dxerr8.c b/dlls/dxerr8/dxerr8.c index e42ee00171..1d2229690a 100644 --- a/dlls/dxerr8/dxerr8.c +++ b/dlls/dxerr8/dxerr8.c @@ -51,7 +51,7 @@ const char * WINAPI DXGetErrorString8A(HRESULT hr) { unsigned int i, j, k = 0; - for (i = sizeof(info)/sizeof(info[0]); i != 0; i /= 2) { + for (i = ARRAY_SIZE(info); i != 0; i /= 2) { j = k + (i / 2); if (hr == info[j].hr) return info[j].resultA; @@ -69,7 +69,7 @@ const WCHAR * WINAPI DXGetErrorString8W(HRESULT hr) static const WCHAR unknown[] = { 'U', 'n', 'k', 'n', 'o', 'w', 'n', 0 }; unsigned int i, j, k = 0; - for (i = sizeof(info)/sizeof(info[0]); i != 0; i /= 2) { + for (i = ARRAY_SIZE(info); i != 0; i /= 2) { j = k + (i / 2); if (hr == info[j].hr) return info[j].resultW; @@ -86,7 +86,7 @@ const char * WINAPI DXGetErrorDescription8A(HRESULT hr) { unsigned int i, j, k = 0; - for (i = sizeof(info)/sizeof(info[0]); i != 0; i /= 2) { + for (i = ARRAY_SIZE(info); i != 0; i /= 2) { j = k + (i / 2); if (hr == info[j].hr) return info[j].descriptionA; @@ -104,7 +104,7 @@ const WCHAR * WINAPI DXGetErrorDescription8W(HRESULT hr) static const WCHAR na[] = { 'n', '/', 'a', 0 }; unsigned int i, j, k = 0; - for (i = sizeof(info)/sizeof(info[0]); i != 0; i /= 2) { + for (i = ARRAY_SIZE(info); i != 0; i /= 2) { j = k + (i / 2); if (hr == info[j].hr) return info[j].descriptionW; -- 2.14.4

1 0

[PATCH v2] ucrtbase: Don't fail if path ends with '\' character in stat functions family.
by Piotr Caban 13 Jul '18

13 Jul '18

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45292 Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msvcrt/file.c | 22 ++++++++++++++++++---- dlls/ucrtbase/tests/misc.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+), 4 deletions(-)

1 0

[PATCH] guiddef.h: REF* types do not depend on CINTERFACE.
by Serge Gautherie 13 Jul '18

13 Jul '18

Addendum to 4626db2bb2a61cdceb00e0e346628062ee51aade. Signed-off-by: Serge Gautherie <winehq-git_serge_180711(a)gautherie.fr> --- include/guiddef.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/guiddef.h b/include/guiddef.h index 36c932c..2adde9c 100644 --- a/include/guiddef.h +++ b/include/guiddef.h @@ -130,12 +130,12 @@ typedef GUID FMTID,*LPFMTID; #define REFCLSID const CLSID & #define REFIID const IID & #define REFFMTID const FMTID & -#else /* !defined(__cplusplus) && !defined(CINTERFACE) */ +#else /* !defined(__cplusplus) */ #define REFGUID const GUID* __MIDL_CONST #define REFCLSID const CLSID* __MIDL_CONST #define REFIID const IID* __MIDL_CONST #define REFFMTID const FMTID* __MIDL_CONST -#endif /* !defined(__cplusplus) && !defined(CINTERFACE) */ +#endif /* !defined(__cplusplus) */ #if defined(__cplusplus) && !defined(CINTERFACE) #define IsEqualGUID(rguid1, rguid2) (!memcmp(&(rguid1), &(rguid2), sizeof(GUID))) -- 2.10.0.windows.1

1 0

[PATCH] windowscodecs: Fix a MsVC warning about get_decoder_info().
by Serge Gautherie 13 Jul '18

13 Jul '18

"...\info.c(2163) : warning C4028: formal parameter 1 different from declaration" ReactOS-Bug: https://jira.reactos.org/browse/CORE-7538 Signed-off-by: Serge Gautherie <winehq-git_serge_180711(a)gautherie.fr> --- This is the first patch I submit to Wine... --- dlls/windowscodecs/info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/windowscodecs/info.c b/dlls/windowscodecs/info.c index 21e6610..e131107 100644 --- a/dlls/windowscodecs/info.c +++ b/dlls/windowscodecs/info.c @@ -2155,7 +2155,7 @@ void ReleaseComponentInfos(void) IWICComponentInfo_Release(&info->IWICComponentInfo_iface); } -HRESULT get_decoder_info(const CLSID *clsid, IWICBitmapDecoderInfo **info) +HRESULT get_decoder_info(REFCLSID clsid, IWICBitmapDecoderInfo **info) { IWICComponentInfo *compinfo; HRESULT hr; -- 2.10.0.windows.1

2 4

[PATCH 3/3] winemac: Implement Vulkan driver on top of MoltenVK
by Andrew Eikum 13 Jul '18

13 Jul '18

Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Ken Thomases <ken(a)codeweavers.com> --- configure.ac | 8 +- dlls/winemac.drv/Makefile.in | 1 + dlls/winemac.drv/gdi.c | 2 +- dlls/winemac.drv/macdrv.h | 1 + dlls/winemac.drv/vulkan.c | 613 +++++++++++++++++++++++++++++++++++ dlls/winex11.drv/vulkan.c | 3 + 6 files changed, 625 insertions(+), 3 deletions(-) create mode 100644 dlls/winemac.drv/vulkan.c diff --git a/configure.ac b/configure.ac index 9ba9a28cc3..be247ea200 100644 --- a/configure.ac +++ b/configure.ac @@ -1858,9 +1858,13 @@ dnl *** Check for Vulkan *** if test "x$with_vulkan" != "xno" then WINE_CHECK_SONAME(vulkan, vkGetInstanceProcAddr) + if test "x$ac_cv_lib_soname_vulkan" = "x" + then + WINE_CHECK_SONAME(MoltenVK, vkGetInstanceProcAddr) + fi fi -WINE_NOTICE_WITH(vulkan,[test "x$ac_cv_lib_soname_vulkan" = "x"], - [libvulkan ${notice_platform}development files not found, Vulkan won't be supported.]) +WINE_NOTICE_WITH(vulkan,[test "x$ac_cv_lib_soname_vulkan" = "x" -a "x$ac_cv_lib_soname_MoltenVK" = "x"], + [libvulkan and libMoltenVK ${notice_platform}development files not found, Vulkan won't be supported.]) dnl **** Check for vkd3d **** if test "x$with_vkd3d" != "xno" diff --git a/dlls/winemac.drv/Makefile.in b/dlls/winemac.drv/Makefile.in index 33f4e2ee00..3ffb7d666c 100644 --- a/dlls/winemac.drv/Makefile.in +++ b/dlls/winemac.drv/Makefile.in @@ -17,6 +17,7 @@ C_SRCS = \ opengl.c \ surface.c \ systray.c \ + vulkan.c \ window.c OBJC_SRCS = \ diff --git a/dlls/winemac.drv/gdi.c b/dlls/winemac.drv/gdi.c index 1f9ac8be41..77da2334ee 100644 --- a/dlls/winemac.drv/gdi.c +++ b/dlls/winemac.drv/gdi.c @@ -418,7 +418,7 @@ static const struct gdi_dc_funcs macdrv_funcs = NULL, /* pUnrealizePalette */ NULL, /* pWidenPath */ macdrv_wine_get_wgl_driver, /* wine_get_wgl_driver */ - NULL, /* wine_get_vulkan_driver */ + macdrv_wine_get_vulkan_driver, /* wine_get_vulkan_driver */ GDI_PRIORITY_GRAPHICS_DRV /* priority */ }; diff --git a/dlls/winemac.drv/macdrv.h b/dlls/winemac.drv/macdrv.h index bb0e8ed13f..f948da42c7 100644 --- a/dlls/winemac.drv/macdrv.h +++ b/dlls/winemac.drv/macdrv.h @@ -209,6 +209,7 @@ static inline RECT rect_from_cgrect(CGRect cgrect) extern BOOL query_drag_drop(macdrv_query* query) DECLSPEC_HIDDEN; extern struct opengl_funcs *macdrv_wine_get_wgl_driver(PHYSDEV dev, UINT version) DECLSPEC_HIDDEN; +extern const struct vulkan_funcs *macdrv_wine_get_vulkan_driver(PHYSDEV dev, UINT version) DECLSPEC_HIDDEN; extern void sync_gl_view(struct macdrv_win_data* data, const RECT* old_whole_rect, const RECT* old_client_rect) DECLSPEC_HIDDEN; extern CGImageRef create_cgimage_from_icon_bitmaps(HDC hdc, HANDLE icon, HBITMAP hbmColor, diff --git a/dlls/winemac.drv/vulkan.c b/dlls/winemac.drv/vulkan.c new file mode 100644 index 0000000000..d590903310 --- /dev/null +++ b/dlls/winemac.drv/vulkan.c @@ -0,0 +1,613 @@ +/* Mac Driver Vulkan implementation + * + * Copyright 2017 Roderick Colenbrander + * Copyright 2018 Andrew Eikum for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +/* NOTE: If making changes here, consider whether they should be reflected in + * the other drivers. */ + +#include "config.h" +#include "wine/port.h" +#include "macdrv.h" + +#include <stdarg.h> +#include <stdio.h> + +#include "windef.h" +#include "winbase.h" + +#include "wine/debug.h" +#include "wine/heap.h" +#include "wine/library.h" + +#define VK_NO_PROTOTYPES +#define WINE_VK_HOST + +#include "wine/vulkan.h" +#include "wine/vulkan_driver.h" + +WINE_DEFAULT_DEBUG_CHANNEL(vulkan); + +#ifdef SONAME_LIBMOLTENVK + +typedef VkFlags VkMacOSSurfaceCreateFlagsMVK; +#define VK_STRUCTURE_TYPE_MACOS_SURFACE_CREATE_INFO_MVK 1000123000 + +struct wine_vk_surface +{ + macdrv_metal_device device; + macdrv_metal_view view; + VkSurfaceKHR surface; /* native surface */ +}; + +typedef struct VkMacOSSurfaceCreateInfoMVK +{ + VkStructureType sType; + const void *pNext; + VkMacOSSurfaceCreateFlagsMVK flags; + const void *pView; /* NSView */ +} VkMacOSSurfaceCreateInfoMVK; + +static VkResult (*pvkAcquireNextImageKHR)(VkDevice, VkSwapchainKHR, uint64_t, VkSemaphore, VkFence, uint32_t *); +static VkResult (*pvkCreateInstance)(const VkInstanceCreateInfo *, const VkAllocationCallbacks *, VkInstance *); +static VkResult (*pvkCreateSwapchainKHR)(VkDevice, const VkSwapchainCreateInfoKHR *, const VkAllocationCallbacks *, VkSwapchainKHR *); +static VkResult (*pvkCreateMacOSSurfaceMVK)(VkInstance, const VkMacOSSurfaceCreateInfoMVK*, const VkAllocationCallbacks *, VkSurfaceKHR *); +static void (*pvkDestroyInstance)(VkInstance, const VkAllocationCallbacks *); +static void (*pvkDestroySurfaceKHR)(VkInstance, VkSurfaceKHR, const VkAllocationCallbacks *); +static void (*pvkDestroySwapchainKHR)(VkDevice, VkSwapchainKHR, const VkAllocationCallbacks *); +static VkResult (*pvkEnumerateInstanceExtensionProperties)(const char *, uint32_t *, VkExtensionProperties *); +static void * (*pvkGetDeviceProcAddr)(VkDevice, const char *); +static void * (*pvkGetInstanceProcAddr)(VkInstance, const char *); +static VkResult (*pvkGetPhysicalDeviceSurfaceCapabilitiesKHR)(VkPhysicalDevice, VkSurfaceKHR, VkSurfaceCapabilitiesKHR *); +static VkResult (*pvkGetPhysicalDeviceSurfaceFormatsKHR)(VkPhysicalDevice, VkSurfaceKHR, uint32_t *, VkSurfaceFormatKHR *); +static VkResult (*pvkGetPhysicalDeviceSurfacePresentModesKHR)(VkPhysicalDevice, VkSurfaceKHR, uint32_t *, VkPresentModeKHR *); +static VkResult (*pvkGetPhysicalDeviceSurfaceSupportKHR)(VkPhysicalDevice, uint32_t, VkSurfaceKHR, VkBool32 *); +static VkResult (*pvkGetSwapchainImagesKHR)(VkDevice, VkSwapchainKHR, uint32_t *, VkImage *); +static VkResult (*pvkQueuePresentKHR)(VkQueue, const VkPresentInfoKHR *); + +static void *macdrv_get_vk_device_proc_addr(const char *name); +static void *macdrv_get_vk_instance_proc_addr(VkInstance instance, const char *name); + +static inline struct wine_vk_surface *surface_from_handle(VkSurfaceKHR handle) +{ + return (struct wine_vk_surface *)(uintptr_t)handle; +} + +static void *vulkan_handle; + +static BOOL WINAPI wine_vk_init(INIT_ONCE *once, void *param, void **context) +{ + if (!(vulkan_handle = wine_dlopen(SONAME_LIBMOLTENVK, RTLD_NOW, NULL, 0))) + { + ERR("Failed to load %s\n", SONAME_LIBMOLTENVK); + return TRUE; + } + +#define LOAD_FUNCPTR(f) if ((p##f = wine_dlsym(vulkan_handle, #f, NULL, 0)) == NULL) goto fail; + LOAD_FUNCPTR(vkAcquireNextImageKHR) + LOAD_FUNCPTR(vkCreateInstance) + LOAD_FUNCPTR(vkCreateSwapchainKHR) + LOAD_FUNCPTR(vkCreateMacOSSurfaceMVK) + LOAD_FUNCPTR(vkDestroyInstance) + LOAD_FUNCPTR(vkDestroySurfaceKHR) + LOAD_FUNCPTR(vkDestroySwapchainKHR) + LOAD_FUNCPTR(vkEnumerateInstanceExtensionProperties) + LOAD_FUNCPTR(vkGetDeviceProcAddr) + LOAD_FUNCPTR(vkGetInstanceProcAddr) + LOAD_FUNCPTR(vkGetPhysicalDeviceSurfaceCapabilitiesKHR) + LOAD_FUNCPTR(vkGetPhysicalDeviceSurfaceFormatsKHR) + LOAD_FUNCPTR(vkGetPhysicalDeviceSurfacePresentModesKHR) + LOAD_FUNCPTR(vkGetPhysicalDeviceSurfaceSupportKHR) + LOAD_FUNCPTR(vkGetSwapchainImagesKHR) + LOAD_FUNCPTR(vkQueuePresentKHR) +#undef LOAD_FUNCPTR + + return TRUE; + +fail: + wine_dlclose(vulkan_handle, NULL, 0); + vulkan_handle = NULL; + return TRUE; +} + +/* Helper function for converting between win32 and MoltenVK compatible VkInstanceCreateInfo. + * Caller is responsible for allocation and cleanup of 'dst'. + */ +static VkResult wine_vk_instance_convert_create_info(const VkInstanceCreateInfo *src, + VkInstanceCreateInfo *dst) +{ + unsigned int i; + const char **enabled_extensions = NULL; + + dst->sType = src->sType; + dst->flags = src->flags; + dst->pApplicationInfo = src->pApplicationInfo; + dst->pNext = src->pNext; + dst->enabledLayerCount = 0; + dst->ppEnabledLayerNames = NULL; + dst->enabledExtensionCount = 0; + dst->ppEnabledExtensionNames = NULL; + + if (src->enabledExtensionCount > 0) + { + enabled_extensions = heap_calloc(src->enabledExtensionCount, sizeof(*src->ppEnabledExtensionNames)); + if (!enabled_extensions) + { + ERR("Failed to allocate memory for enabled extensions\n"); + return VK_ERROR_OUT_OF_HOST_MEMORY; + } + + for (i = 0; i < src->enabledExtensionCount; i++) + { + /* Substitute extension with MoltenVK ones else copy. Long-term, when we + * support more extensions, we should store these in a list. + */ + if (!strcmp(src->ppEnabledExtensionNames[i], "VK_KHR_win32_surface")) + { + enabled_extensions[i] = "VK_MVK_macos_surface"; + } + else + { + enabled_extensions[i] = src->ppEnabledExtensionNames[i]; + } + } + dst->ppEnabledExtensionNames = enabled_extensions; + dst->enabledExtensionCount = src->enabledExtensionCount; + } + + return VK_SUCCESS; +} + +static void wine_vk_surface_destroy(VkInstance instance, struct wine_vk_surface *surface) +{ + /* vkDestroySurfaceKHR must handle VK_NULL_HANDLE (0) for surface. */ + if (!surface) + return; + + pvkDestroySurfaceKHR(instance, surface->surface, NULL /* allocator */); + + if (surface->view) + macdrv_view_release_metal_view(surface->view); + + if (surface->device) + macdrv_release_metal_device(surface->device); + + heap_free(surface); +} + +static VkResult macdrv_vkAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, + uint64_t timeout, VkSemaphore semaphore, VkFence fence, uint32_t *index) +{ + TRACE("%p, 0x%s, 0x%s, 0x%s, 0x%s, %p\n", device, + wine_dbgstr_longlong(swapchain), wine_dbgstr_longlong(timeout), + wine_dbgstr_longlong(semaphore), wine_dbgstr_longlong(fence), index); + + return pvkAcquireNextImageKHR(device, swapchain, timeout, semaphore, fence, index); +} + +static VkResult macdrv_vkCreateInstance(const VkInstanceCreateInfo *create_info, + const VkAllocationCallbacks *allocator, VkInstance *instance) +{ + VkInstanceCreateInfo create_info_host; + VkResult res; + TRACE("create_info %p, allocator %p, instance %p\n", create_info, allocator, instance); + + if (allocator) + FIXME("Support for allocation callbacks not implemented yet\n"); + + /* Perform a second pass on converting VkInstanceCreateInfo. Winevulkan + * performed a first pass in which it handles everything except for WSI + * functionality such as VK_KHR_win32_surface. Handle this now. + */ + res = wine_vk_instance_convert_create_info(create_info, &create_info_host); + if (res != VK_SUCCESS) + { + ERR("Failed to convert instance create info, res=%d\n", res); + return res; + } + + res = pvkCreateInstance(&create_info_host, NULL /* allocator */, instance); + + heap_free((void *)create_info_host.ppEnabledExtensionNames); + return res; +} + +static VkResult macdrv_vkCreateSwapchainKHR(VkDevice device, + const VkSwapchainCreateInfoKHR *create_info, + const VkAllocationCallbacks *allocator, VkSwapchainKHR *swapchain) +{ + VkSwapchainCreateInfoKHR create_info_host; + TRACE("%p %p %p %p\n", device, create_info, allocator, swapchain); + + if (allocator) + FIXME("Support for allocation callbacks not implemented yet\n"); + + create_info_host = *create_info; + create_info_host.surface = surface_from_handle(create_info->surface)->surface; + + return pvkCreateSwapchainKHR(device, &create_info_host, NULL /* allocator */, + swapchain); +} + +static VkResult macdrv_vkCreateWin32SurfaceKHR(VkInstance instance, + const VkWin32SurfaceCreateInfoKHR *create_info, + const VkAllocationCallbacks *allocator, VkSurfaceKHR *surface) +{ + VkResult res; + VkMacOSSurfaceCreateInfoMVK create_info_host; + struct wine_vk_surface *mac_surface; + struct macdrv_win_data *data; + + TRACE("%p %p %p %p\n", instance, create_info, allocator, surface); + + if (allocator) + FIXME("Support for allocation callbacks not implemented yet\n"); + + if (!(data = get_win_data(create_info->hwnd))) + { + FIXME("DC for window %p of other process: not implemented\n", create_info->hwnd); + return VK_ERROR_INCOMPATIBLE_DRIVER; + } + + mac_surface = heap_alloc_zero(sizeof(*mac_surface)); + if (!mac_surface) + { + release_win_data(data); + return VK_ERROR_OUT_OF_HOST_MEMORY; + } + + mac_surface->device = macdrv_create_metal_device(); + if (!mac_surface->device) + { + ERR("Failed to allocate Metal device for hwnd=%p\n", create_info->hwnd); + res = VK_ERROR_OUT_OF_HOST_MEMORY; + goto err; + } + + mac_surface->view = macdrv_view_create_metal_view(data->client_cocoa_view, mac_surface->device); + if (!mac_surface->view) + { + ERR("Failed to allocate Metal view for hwnd=%p\n", create_info->hwnd); + + /* VK_KHR_win32_surface only allows out of host and device memory as errors. */ + res = VK_ERROR_OUT_OF_HOST_MEMORY; + goto err; + } + + create_info_host.sType = VK_STRUCTURE_TYPE_MACOS_SURFACE_CREATE_INFO_MVK; + create_info_host.pNext = NULL; + create_info_host.flags = 0; /* reserved */ + create_info_host.pView = mac_surface->view; + + res = pvkCreateMacOSSurfaceMVK(instance, &create_info_host, NULL /* allocator */, &mac_surface->surface); + if (res != VK_SUCCESS) + { + ERR("Failed to create MoltenVK surface, res=%d\n", res); + goto err; + } + + *surface = (uintptr_t)mac_surface; + + release_win_data(data); + + TRACE("Created surface=0x%s\n", wine_dbgstr_longlong(*surface)); + return VK_SUCCESS; + +err: + wine_vk_surface_destroy(instance, mac_surface); + release_win_data(data); + return res; +} + +static void macdrv_vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *allocator) +{ + TRACE("%p %p\n", instance, allocator); + + if (allocator) + FIXME("Support for allocation callbacks not implemented yet\n"); + + pvkDestroyInstance(instance, NULL /* allocator */); +} + +static void macdrv_vkDestroySurfaceKHR(VkInstance instance, VkSurfaceKHR surface, + const VkAllocationCallbacks *allocator) +{ + struct wine_vk_surface *mac_surface = surface_from_handle(surface); + + TRACE("%p 0x%s %p\n", instance, wine_dbgstr_longlong(surface), allocator); + + if (allocator) + FIXME("Support for allocation callbacks not implemented yet\n"); + + wine_vk_surface_destroy(instance, mac_surface); +} + +static void macdrv_vkDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, + const VkAllocationCallbacks *allocator) +{ + TRACE("%p, 0x%s %p\n", device, wine_dbgstr_longlong(swapchain), allocator); + + if (allocator) + FIXME("Support for allocation callbacks not implemented yet\n"); + + pvkDestroySwapchainKHR(device, swapchain, NULL /* allocator */); +} + +static VkResult macdrv_vkEnumerateInstanceExtensionProperties(const char *layer_name, + uint32_t *count, VkExtensionProperties* properties) +{ + unsigned int i; + VkResult res; + + TRACE("layer_name %p, count %p, properties %p\n", debugstr_a(layer_name), count, properties); + + /* This shouldn't get called with layer_name set, the ICD loader prevents it. */ + if (layer_name) + { + ERR("Layer enumeration not supported from ICD.\n"); + return VK_ERROR_LAYER_NOT_PRESENT; + } + + /* We will return the same number of instance extensions reported by the host back to + * winevulkan. Along the way we may replace MoltenVK extensions with their win32 equivalents. + * Winevulkan will perform more detailed filtering as it knows whether it has thunks + * for a particular extension. + */ + res = pvkEnumerateInstanceExtensionProperties(layer_name, count, properties); + if (!properties || res < 0) + return res; + + for (i = 0; i < *count; i++) + { + /* For now the only MoltenVK extension we need to fixup. Long-term we may need an array. */ + if (!strcmp(properties[i].extensionName, "VK_MVK_macos_surface")) + { + TRACE("Substituting VK_MVK_macos_surface for VK_KHR_win32_surface\n"); + + snprintf(properties[i].extensionName, sizeof(properties[i].extensionName), + VK_KHR_WIN32_SURFACE_EXTENSION_NAME); + properties[i].specVersion = VK_KHR_WIN32_SURFACE_SPEC_VERSION; + } + } + + TRACE("Returning %u extensions.\n", *count); + return res; +} + +static void *macdrv_vkGetDeviceProcAddr(VkDevice device, const char *name) +{ + void *proc_addr; + + TRACE("%p, %s\n", device, debugstr_a(name)); + + if ((proc_addr = macdrv_get_vk_device_proc_addr(name))) + return proc_addr; + + return pvkGetDeviceProcAddr(device, name); +} + +static void *macdrv_vkGetInstanceProcAddr(VkInstance instance, const char *name) +{ + void *proc_addr; + + TRACE("%p, %s\n", instance, debugstr_a(name)); + + if ((proc_addr = macdrv_get_vk_instance_proc_addr(instance, name))) + return proc_addr; + + return pvkGetInstanceProcAddr(instance, name); +} + +static VkResult macdrv_vkGetPhysicalDeviceSurfaceCapabilitiesKHR(VkPhysicalDevice phys_dev, + VkSurfaceKHR surface, VkSurfaceCapabilitiesKHR *capabilities) +{ + struct wine_vk_surface *mac_surface = surface_from_handle(surface); + + TRACE("%p, 0x%s, %p\n", phys_dev, wine_dbgstr_longlong(surface), capabilities); + + return pvkGetPhysicalDeviceSurfaceCapabilitiesKHR(phys_dev, mac_surface->surface, + capabilities); +} + +static VkResult macdrv_vkGetPhysicalDeviceSurfaceFormatsKHR(VkPhysicalDevice phys_dev, + VkSurfaceKHR surface, uint32_t *count, VkSurfaceFormatKHR *formats) +{ + struct wine_vk_surface *mac_surface = surface_from_handle(surface); + + TRACE("%p, 0x%s, %p, %p\n", phys_dev, wine_dbgstr_longlong(surface), count, formats); + + return pvkGetPhysicalDeviceSurfaceFormatsKHR(phys_dev, mac_surface->surface, + count, formats); +} + +static VkResult macdrv_vkGetPhysicalDeviceSurfacePresentModesKHR(VkPhysicalDevice phys_dev, + VkSurfaceKHR surface, uint32_t *count, VkPresentModeKHR *modes) +{ + struct wine_vk_surface *mac_surface = surface_from_handle(surface); + + TRACE("%p, 0x%s, %p, %p\n", phys_dev, wine_dbgstr_longlong(surface), count, modes); + + return pvkGetPhysicalDeviceSurfacePresentModesKHR(phys_dev, mac_surface->surface, count, + modes); +} + +static VkResult macdrv_vkGetPhysicalDeviceSurfaceSupportKHR(VkPhysicalDevice phys_dev, + uint32_t index, VkSurfaceKHR surface, VkBool32 *supported) +{ + struct wine_vk_surface *mac_surface = surface_from_handle(surface); + + TRACE("%p, %u, 0x%s, %p\n", phys_dev, index, wine_dbgstr_longlong(surface), supported); + + return pvkGetPhysicalDeviceSurfaceSupportKHR(phys_dev, index, mac_surface->surface, + supported); +} + +static VkBool32 macdrv_vkGetPhysicalDeviceWin32PresentationSupportKHR(VkPhysicalDevice phys_dev, + uint32_t index) +{ + TRACE("%p %u\n", phys_dev, index); + + return VK_TRUE; +} + +static VkResult macdrv_vkGetSwapchainImagesKHR(VkDevice device, + VkSwapchainKHR swapchain, uint32_t *count, VkImage *images) +{ + TRACE("%p, 0x%s %p %p\n", device, wine_dbgstr_longlong(swapchain), count, images); + return pvkGetSwapchainImagesKHR(device, swapchain, count, images); +} + +static VkResult macdrv_vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *present_info) +{ + TRACE("%p, %p\n", queue, present_info); + return pvkQueuePresentKHR(queue, present_info); +} + +static const struct vulkan_funcs vulkan_funcs = +{ + macdrv_vkAcquireNextImageKHR, + macdrv_vkCreateInstance, + macdrv_vkCreateSwapchainKHR, + macdrv_vkCreateWin32SurfaceKHR, + macdrv_vkDestroyInstance, + macdrv_vkDestroySurfaceKHR, + macdrv_vkDestroySwapchainKHR, + macdrv_vkEnumerateInstanceExtensionProperties, + macdrv_vkGetDeviceProcAddr, + macdrv_vkGetInstanceProcAddr, + macdrv_vkGetPhysicalDeviceSurfaceCapabilitiesKHR, + macdrv_vkGetPhysicalDeviceSurfaceFormatsKHR, + macdrv_vkGetPhysicalDeviceSurfacePresentModesKHR, + macdrv_vkGetPhysicalDeviceSurfaceSupportKHR, + macdrv_vkGetPhysicalDeviceWin32PresentationSupportKHR, + macdrv_vkGetSwapchainImagesKHR, + macdrv_vkQueuePresentKHR, +}; + +static void *get_vulkan_driver_device_proc_addr(const struct vulkan_funcs *vulkan_funcs, + const char *name) +{ + if (!name || name[0] != 'v' || name[1] != 'k') + return NULL; + + name += 2; + + if (!strcmp(name, "AcquireNextImageKHR")) + return vulkan_funcs->p_vkAcquireNextImageKHR; + if (!strcmp(name, "CreateSwapchainKHR")) + return vulkan_funcs->p_vkCreateSwapchainKHR; + if (!strcmp(name, "DestroySwapchainKHR")) + return vulkan_funcs->p_vkDestroySwapchainKHR; + if (!strcmp(name, "GetDeviceProcAddr")) + return vulkan_funcs->p_vkGetDeviceProcAddr; + if (!strcmp(name, "GetSwapchainImagesKHR")) + return vulkan_funcs->p_vkGetSwapchainImagesKHR; + if (!strcmp(name, "QueuePresentKHR")) + return vulkan_funcs->p_vkQueuePresentKHR; + + return NULL; +} + +static void *macdrv_get_vk_device_proc_addr(const char *name) +{ + return get_vulkan_driver_device_proc_addr(&vulkan_funcs, name); +} + +static void *get_vulkan_driver_instance_proc_addr(const struct vulkan_funcs *vulkan_funcs, + VkInstance instance, const char *name) +{ + if (!name || name[0] != 'v' || name[1] != 'k') + return NULL; + + name += 2; + + if (!strcmp(name, "CreateInstance")) + return vulkan_funcs->p_vkCreateInstance; + if (!strcmp(name, "EnumerateInstanceExtensionProperties")) + return vulkan_funcs->p_vkEnumerateInstanceExtensionProperties; + + if (!instance) + return NULL; + + if (!strcmp(name, "CreateWin32SurfaceKHR")) + return vulkan_funcs->p_vkCreateWin32SurfaceKHR; + if (!strcmp(name, "DestroyInstance")) + return vulkan_funcs->p_vkDestroyInstance; + if (!strcmp(name, "DestroySurfaceKHR")) + return vulkan_funcs->p_vkDestroySurfaceKHR; + if (!strcmp(name, "GetInstanceProcAddr")) + return vulkan_funcs->p_vkGetInstanceProcAddr; + if (!strcmp(name, "GetPhysicalDeviceSurfaceCapabilitiesKHR")) + return vulkan_funcs->p_vkGetPhysicalDeviceSurfaceCapabilitiesKHR; + if (!strcmp(name, "GetPhysicalDeviceSurfaceFormatsKHR")) + return vulkan_funcs->p_vkGetPhysicalDeviceSurfaceFormatsKHR; + if (!strcmp(name, "GetPhysicalDeviceSurfacePresentModesKHR")) + return vulkan_funcs->p_vkGetPhysicalDeviceSurfacePresentModesKHR; + if (!strcmp(name, "GetPhysicalDeviceSurfaceSupportKHR")) + return vulkan_funcs->p_vkGetPhysicalDeviceSurfaceSupportKHR; + if (!strcmp(name, "GetPhysicalDeviceWin32PresentationSupportKHR")) + return vulkan_funcs->p_vkGetPhysicalDeviceWin32PresentationSupportKHR; + + name -= 2; + + return get_vulkan_driver_device_proc_addr(vulkan_funcs, name); +} + +static void *macdrv_get_vk_instance_proc_addr(VkInstance instance, const char *name) +{ + return get_vulkan_driver_instance_proc_addr(&vulkan_funcs, instance, name); +} + +static const struct vulkan_funcs *get_vulkan_driver(UINT version) +{ + static INIT_ONCE init_once = INIT_ONCE_STATIC_INIT; + + if (version != WINE_VULKAN_DRIVER_VERSION) + { + ERR("version mismatch, vulkan wants %u but driver has %u\n", version, WINE_VULKAN_DRIVER_VERSION); + return NULL; + } + + InitOnceExecuteOnce(&init_once, wine_vk_init, NULL, NULL); + if (vulkan_handle) + return &vulkan_funcs; + + return NULL; +} + +#else /* No vulkan */ + +static const struct vulkan_funcs *get_vulkan_driver(UINT version) +{ + ERR("Wine was built without Vulkan support.\n"); + return NULL; +} + +#endif /* SONAME_LIBMOLTENVK */ + +const struct vulkan_funcs *macdrv_wine_get_vulkan_driver(PHYSDEV dev, UINT version) +{ + const struct vulkan_funcs *ret; + + if (!(ret = get_vulkan_driver( version ))) + { + dev = GET_NEXT_PHYSDEV( dev, wine_get_vulkan_driver ); + ret = dev->funcs->wine_get_vulkan_driver( dev, version ); + } + return ret; +} diff --git a/dlls/winex11.drv/vulkan.c b/dlls/winex11.drv/vulkan.c index fdb858d93f..acb9c231aa 100644 --- a/dlls/winex11.drv/vulkan.c +++ b/dlls/winex11.drv/vulkan.c @@ -17,6 +17,9 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +/* NOTE: If making changes here, consider whether they should be reflected in + * the other drivers. */ + #include "config.h" #include "wine/port.h" -- 2.18.0

1 0

[PATCH 2/3] winemac: Implement WineMetalView class
by Andrew Eikum 13 Jul '18

13 Jul '18

From: Ken Thomases <ken(a)codeweavers.com> Signed-off-by: Ken Thomases <ken(a)codeweavers.com> Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> --- Note that this and the next patch need config.h.in to be re-generated, I don't recall if I'm supposed to do that or not. configure.ac | 7 ++ dlls/winemac.drv/Makefile.in | 2 +- dlls/winemac.drv/cocoa_window.m | 141 ++++++++++++++++++++++++++++++++ dlls/winemac.drv/macdrv_cocoa.h | 10 +++ 4 files changed, 159 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 1db5a407fa..9ba9a28cc3 100644 --- a/configure.ac +++ b/configure.ac @@ -762,6 +762,9 @@ case $host_os in darwin*|macosx*) AC_CHECK_HEADERS(libunwind.h) + AC_LANG_PUSH([Objective C]) + AC_CHECK_HEADERS(Metal/Metal.h) + AC_LANG_POP([Objective C]) LIBEXT="dylib" DLLFLAGS="$DLLFLAGS -fPIC" LDRPATH_INSTALL="-Wl,-rpath,@loader_path/\`\$(MAKEDEP) -R \${bindir} \${libdir}\`" @@ -846,6 +849,10 @@ case $host_os in then AC_SUBST(CARBON_LIBS,"-framework Carbon") fi + if test "$ac_cv_header_Metal_Metal_h" = "yes" + then + AC_SUBST(METAL_LIBS,"-framework Metal -framework QuartzCore") + fi dnl Enable Mac driver on Mac OS X 10.6 or later if test "$ac_cv_header_ApplicationServices_ApplicationServices_h" = "yes" diff --git a/dlls/winemac.drv/Makefile.in b/dlls/winemac.drv/Makefile.in index c160895c7d..33f4e2ee00 100644 --- a/dlls/winemac.drv/Makefile.in +++ b/dlls/winemac.drv/Makefile.in @@ -1,7 +1,7 @@ MODULE = winemac.drv IMPORTS = uuid user32 gdi32 advapi32 DELAYIMPORTS = ole32 shell32 imm32 -EXTRALIBS = -framework AppKit -framework Carbon -framework Security -framework OpenGL -framework IOKit -framework CoreVideo +EXTRALIBS = -framework AppKit -framework Carbon -framework Security -framework OpenGL -framework IOKit -framework CoreVideo $(METAL_LIBS) C_SRCS = \ clipboard.c \ diff --git a/dlls/winemac.drv/cocoa_window.m b/dlls/winemac.drv/cocoa_window.m index 1e10c27ce8..4c59faf1f4 100644 --- a/dlls/winemac.drv/cocoa_window.m +++ b/dlls/winemac.drv/cocoa_window.m @@ -18,8 +18,14 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include "config.h" + #import <Carbon/Carbon.h> #import <CoreVideo/CoreVideo.h> +#ifdef HAVE_METAL_METAL_H +#import <Metal/Metal.h> +#import <QuartzCore/QuartzCore.h> +#endif #import "cocoa_window.h" @@ -303,6 +309,18 @@ @interface WineBaseView : NSView @end +#ifdef HAVE_METAL_METAL_H +(a)interface WineMetalView : WineBaseView +{ + id<MTLDevice> _device; +} + + - (id) initWithFrame:(NSRect)frame device:(id<MTLDevice>)device; + +(a)end +#endif + + @interface WineContentView : WineBaseView <NSTextInputClient> { NSMutableArray* glContexts; @@ -316,6 +334,10 @@ @interface WineContentView : WineBaseView <NSTextInputClient> NSRange markedTextSelection; int backingSize[2]; + +#ifdef HAVE_METAL_METAL_H + WineMetalView *_metalView; +#endif } @property (readonly, nonatomic) BOOL everHadGLContext; @@ -327,6 +349,10 @@ - (void) updateGLContexts; - (void) wine_getBackingSize:(int*)outBackingSize; - (void) wine_setBackingSize:(const int*)newBackingSize; +#ifdef HAVE_METAL_METAL_H + - (WineMetalView*) newMetalViewWithDevice:(id<MTLDevice>)device; +#endif + @end @@ -628,6 +654,23 @@ - (void) wine_setBackingSize:(const int*)newBackingSize } } +#ifdef HAVE_METAL_METAL_H + - (WineMetalView*) newMetalViewWithDevice:(id<MTLDevice>)device + { + if (_metalView) return _metalView; + + WineMetalView* view = [[WineMetalView alloc] initWithFrame:[self bounds] device:device]; + [view setAutoresizingMask:NSViewWidthSizable | NSViewHeightSizable]; + [self setAutoresizesSubviews:YES]; + [self addSubview:view positioned:NSWindowBelow relativeTo:nil]; + _metalView = view; + + [(WineWindow*)self.window windowDidDrawContent]; + + return _metalView; + } +#endif + - (void) setRetinaMode:(int)mode { double scale = mode ? 0.5 : 2.0; @@ -693,6 +736,10 @@ - (void) willRemoveSubview:(NSView*)subview if (!view->_cachedHasGLDescendantValid || view->_cachedHasGLDescendant) [self invalidateHasGLDescendant]; } +#ifdef HAVE_METAL_METAL_H + if (subview == _metalView) + _metalView = nil; +#endif [super willRemoveSubview:subview]; } @@ -833,6 +880,53 @@ - (NSInteger) windowLevel @end +#ifdef HAVE_METAL_METAL_H +(a)implementation WineMetalView + + - (id) initWithFrame:(NSRect)frame device:(id<MTLDevice>)device + { + self = [super initWithFrame:frame]; + if (self) + { + _device = [device retain]; + self.wantsLayer = YES; + self.layerContentsRedrawPolicy = NSViewLayerContentsRedrawNever; + } + return self; + } + + - (void) dealloc + { + [_device release]; + [super dealloc]; + } + + - (void) setRetinaMode:(int)mode + { + self.layer.contentsScale = mode ? 2.0 : 1.0; + [super setRetinaMode:mode]; + } + + - (CALayer*) makeBackingLayer + { + CAMetalLayer *layer = [CAMetalLayer layer]; + layer.device = _device; + layer.framebufferOnly = YES; + layer.magnificationFilter = kCAFilterNearest; + layer.backgroundColor = CGColorGetConstantColor(kCGColorBlack); + layer.contentsScale = retina_on ? 2.0 : 1.0; + return layer; + } + + - (BOOL) isOpaque + { + return YES; + } + +(a)end +#endif + + @implementation WineWindow static WineWindow* causing_becomeKeyWindow; @@ -3492,6 +3586,7 @@ macdrv_view macdrv_create_view(CGRect rect) view = [[WineContentView alloc] initWithFrame:NSRectFromCGRect(cgrect_mac_from_win(rect))]; [view setAutoresizesSubviews:NO]; + [view setAutoresizingMask:NSViewNotSizable]; [view setHidden:YES]; [nc addObserver:view selector:@selector(updateGLContexts) @@ -3679,6 +3774,52 @@ void macdrv_remove_view_opengl_context(macdrv_view v, macdrv_opengl_context c) [pool release]; } +#ifdef HAVE_METAL_METAL_H +macdrv_metal_device macdrv_create_metal_device(void) +{ + macdrv_metal_device ret; + +#if MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_11 + if (MTLCreateSystemDefaultDevice == NULL) + return NULL; +#endif + + NSAutoreleasePool* pool = [[NSAutoreleasePool alloc] init]; + ret = (macdrv_metal_device)MTLCreateSystemDefaultDevice(); + [pool release]; + return ret; +} + +void macdrv_release_metal_device(macdrv_metal_device d) +{ + NSAutoreleasePool* pool = [[NSAutoreleasePool alloc] init]; + [(id<MTLDevice>)d release]; + [pool release]; +} + +macdrv_metal_view macdrv_view_create_metal_view(macdrv_view v, macdrv_metal_device d) +{ + id<MTLDevice> device = (id<MTLDevice>)d; + WineContentView* view = (WineContentView*)v; + __block WineMetalView *metalView; + + OnMainThread(^{ + metalView = [view newMetalViewWithDevice:device]; + }); + + return (macdrv_metal_view)metalView; +} + +void macdrv_view_release_metal_view(macdrv_metal_view v) +{ + WineMetalView* view = (WineMetalView*)v; + OnMainThread(^{ + [view removeFromSuperview]; + [view release]; + }); +} +#endif + int macdrv_get_view_backing_size(macdrv_view v, int backing_size[2]) { WineContentView* view = (WineContentView*)v; diff --git a/dlls/winemac.drv/macdrv_cocoa.h b/dlls/winemac.drv/macdrv_cocoa.h index a22b4c2917..acab5dfd92 100644 --- a/dlls/winemac.drv/macdrv_cocoa.h +++ b/dlls/winemac.drv/macdrv_cocoa.h @@ -138,6 +138,10 @@ typedef struct macdrv_opaque_event_queue* macdrv_event_queue; typedef struct macdrv_opaque_view* macdrv_view; typedef struct macdrv_opaque_opengl_context* macdrv_opengl_context; +#ifdef HAVE_METAL_METAL_H +typedef struct macdrv_opaque_metal_device* macdrv_metal_device; +typedef struct macdrv_opaque_metal_view* macdrv_metal_view; +#endif typedef struct macdrv_opaque_status_item* macdrv_status_item; struct macdrv_event; struct macdrv_query; @@ -527,6 +531,12 @@ extern void macdrv_set_window_color_key(macdrv_window w, CGFloat keyRed, CGFloat extern void macdrv_set_view_hidden(macdrv_view v, int hidden) DECLSPEC_HIDDEN; extern void macdrv_add_view_opengl_context(macdrv_view v, macdrv_opengl_context c) DECLSPEC_HIDDEN; extern void macdrv_remove_view_opengl_context(macdrv_view v, macdrv_opengl_context c) DECLSPEC_HIDDEN; +#ifdef HAVE_METAL_METAL_H +extern macdrv_metal_device macdrv_create_metal_device(void) DECLSPEC_HIDDEN; +extern void macdrv_release_metal_device(macdrv_metal_device d) DECLSPEC_HIDDEN; +extern macdrv_metal_view macdrv_view_create_metal_view(macdrv_view v, macdrv_metal_device d) DECLSPEC_HIDDEN; +extern void macdrv_view_release_metal_view(macdrv_metal_view v) DECLSPEC_HIDDEN; +#endif extern int macdrv_get_view_backing_size(macdrv_view v, int backing_size[2]) DECLSPEC_HIDDEN; extern void macdrv_set_view_backing_size(macdrv_view v, const int backing_size[2]) DECLSPEC_HIDDEN; extern uint32_t macdrv_window_background_color(void) DECLSPEC_HIDDEN; -- 2.18.0

1 0

[PATCH 1/3] winemac: Extract a new class, WineBaseView, to be the superclass of WineContentView and future view classes.
by Andrew Eikum 13 Jul '18

13 Jul '18

From: Ken Thomases <ken(a)codeweavers.com> Signed-off-by: Ken Thomases <ken(a)codeweavers.com> Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> --- dlls/winemac.drv/cocoa_window.m | 96 +++++++++++++++++++-------------- 1 file changed, 55 insertions(+), 41 deletions(-) diff --git a/dlls/winemac.drv/cocoa_window.m b/dlls/winemac.drv/cocoa_window.m index e37e071ea4..1e10c27ce8 100644 --- a/dlls/winemac.drv/cocoa_window.m +++ b/dlls/winemac.drv/cocoa_window.m @@ -299,7 +299,11 @@ static CVReturn WineDisplayLinkCallback(CVDisplayLinkRef displayLink, const CVTi @end -(a)interface WineContentView : NSView <NSTextInputClient> +(a)interface WineBaseView : NSView +(a)end + + +(a)interface WineContentView : WineBaseView <NSTextInputClient> { NSMutableArray* glContexts; NSMutableArray* pendingGlContexts; @@ -366,6 +370,52 @@ - (void) windowDidDrawContent; @end +(a)implementation WineBaseView + + - (void) setRetinaMode:(int)mode + { + for (WineBaseView* subview in [self subviews]) + { + if ([subview isKindOfClass:[WineBaseView class]]) + [subview setRetinaMode:mode]; + } + } + + - (BOOL) acceptsFirstMouse:(NSEvent*)theEvent + { + return YES; + } + + - (BOOL) preservesContentDuringLiveResize + { + // Returning YES from this tells Cocoa to keep our view's content during + // a Cocoa-driven resize. In theory, we're also supposed to override + // -setFrameSize: to mark exposed sections as needing redisplay, but + // user32 will take care of that in a roundabout way. This way, we don't + // redraw until the window surface is flushed. + // + // This doesn't do anything when we resize the window ourselves. + return YES; + } + + - (BOOL)acceptsFirstResponder + { + return [[self window] contentView] == self; + } + + - (BOOL) mouseDownCanMoveWindow + { + return NO; + } + + - (NSFocusRingType) focusRingType + { + return NSFocusRingTypeNone; + } + +(a)end + + @implementation WineContentView @synthesize everHadGLContext = _everHadGLContext; @@ -537,7 +587,7 @@ - (BOOL) _hasGLDescendant return YES; for (WineContentView* view in [self subviews]) { - if ([view hasGLDescendant]) + if ([view isKindOfClass:[WineContentView class]] && [view hasGLDescendant]) return YES; } return NO; @@ -589,38 +639,7 @@ - (void) setRetinaMode:(int)mode [self setFrame:frame]; [self updateGLContexts]; - for (WineContentView* subview in [self subviews]) - { - if ([subview isKindOfClass:[WineContentView class]]) - [subview setRetinaMode:mode]; - } - } - - - (BOOL) acceptsFirstMouse:(NSEvent*)theEvent - { - return YES; - } - - - (BOOL) preservesContentDuringLiveResize - { - // Returning YES from this tells Cocoa to keep our view's content during - // a Cocoa-driven resize. In theory, we're also supposed to override - // -setFrameSize: to mark exposed sections as needing redisplay, but - // user32 will take care of that in a roundabout way. This way, we don't - // redraw until the window surface is flushed. - // - // This doesn't do anything when we resize the window ourselves. - return YES; - } - - - (BOOL)acceptsFirstResponder - { - return [[self window] contentView] == self; - } - - - (BOOL) mouseDownCanMoveWindow - { - return NO; + [super setRetinaMode:mode]; } - (void) viewDidHide @@ -655,11 +674,6 @@ - (void) completeText:(NSString*)text [[self inputContext] discardMarkedText]; } - - (NSFocusRingType) focusRingType - { - return NSFocusRingTypeNone; - } - - (void) didAddSubview:(NSView*)subview { if ([subview isKindOfClass:[WineContentView class]]) @@ -2537,9 +2551,9 @@ - (void) setRetinaMode:(int)mode if (shape) [shape transformUsingAffineTransform:transform]; - for (WineContentView* subview in [self.contentView subviews]) + for (WineBaseView* subview in [self.contentView subviews]) { - if ([subview isKindOfClass:[WineContentView class]]) + if ([subview isKindOfClass:[WineBaseView class]]) [subview setRetinaMode:mode]; } -- 2.18.0

1 0