October 2019 - Wine-devel - list.winehq.org

[PATCH 4/6] server: Don't block when writing to named pipes in PIPE_NOWAIT mode.
by Jacek Caban 16 Oct '19

16 Oct '19

From: Brendan Shanks <bshanks(a)codeweavers.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/kernel32/tests/pipe.c | 36 ++++++++++++++++++------------------ server/named_pipe.c | 17 ++++++++++++----- 2 files changed, 30 insertions(+), 23 deletions(-)

1 0

[PATCH 3/6] server: Reselect read queue before write queue in pipe_end_write.
by Jacek Caban 16 Oct '19

16 Oct '19

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- server/named_pipe.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-)

1 0

[PATCH 1/6] kernel32/tests: Add tests for named pipes in PIPE_NOWAIT mode.
by Jacek Caban 16 Oct '19

16 Oct '19

From: Brendan Shanks <bshanks(a)codeweavers.com> Signed-off-by: Brendan Shanks <bshanks(a)codeweavers.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/kernel32/tests/pipe.c | 165 +++++++++++++++++++++++++++++++++++++ 1 file changed, 165 insertions(+)

1 0

[PATCH] testbot: Increase the job retention time to 30 days.
by Francois Gouget 16 Oct '19

16 Oct '19

The patches website points to TestBot jobs so it makes sense for the retention times to match. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/lib/WineTestBot/Config.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/lib/WineTestBot/Config.pm b/testbot/lib/WineTestBot/Config.pm index bcfa9ae82..55da6e325 100644 --- a/testbot/lib/WineTestBot/Config.pm +++ b/testbot/lib/WineTestBot/Config.pm @@ -146,7 +146,7 @@ $LDAPSearchFilter = undef; $LDAPRealNameAttribute = undef; $LDAPEMailAttribute = undef; -$JobPurgeDays = 7; +$JobPurgeDays = 30; if (!$::BuildEnv) { -- 2.20.1

1 0

[PATCH] ieframe: Implement InternetExplorer::get_Busy().
by Dmitry Timoshkov 16 Oct '19

16 Oct '19

Thanks Jacek. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/ieframe/ie.c | 7 +++++-- dlls/ieframe/tests/ie.c | 16 ++++++++++++++-- 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/dlls/ieframe/ie.c b/dlls/ieframe/ie.c index 99ec88e7c3..5d9545e95d 100644 --- a/dlls/ieframe/ie.c +++ b/dlls/ieframe/ie.c @@ -348,8 +348,11 @@ static HRESULT WINAPI InternetExplorer_get_LocationURL(IWebBrowser2 *iface, BSTR static HRESULT WINAPI InternetExplorer_get_Busy(IWebBrowser2 *iface, VARIANT_BOOL *pBool) { InternetExplorer *This = impl_from_IWebBrowser2(iface); - FIXME("(%p)->(%p)\n", This, pBool); - return E_NOTIMPL; + + TRACE("(%p)->(%p)\n", This, pBool); + + *pBool = This->doc_host.busy; + return S_OK; } static HRESULT WINAPI InternetExplorer_Quit(IWebBrowser2 *iface) diff --git a/dlls/ieframe/tests/ie.c b/dlls/ieframe/tests/ie.c index b27323cc2e..8dfe155b18 100644 --- a/dlls/ieframe/tests/ie.c +++ b/dlls/ieframe/tests/ie.c @@ -177,7 +177,7 @@ static void test_visible(IWebBrowser2 *wb) b = 0x100; hres = IWebBrowser2_get_Visible(wb, &b); ok(hres == S_OK, "get_Visible failed: %08x\n", hres); - ok(b == VARIANT_FALSE, "Visible = %x\n", hres); + ok(b == VARIANT_FALSE, "Visible = %x\n", b); hres = IWebBrowser2_put_Visible(wb, VARIANT_TRUE); ok(hres == S_OK, "put_Visible failed: %08x\n", hres); @@ -185,7 +185,7 @@ static void test_visible(IWebBrowser2 *wb) b = 0x100; hres = IWebBrowser2_get_Visible(wb, &b); ok(hres == S_OK, "get_Visible failed: %08x\n", hres); - ok(b == VARIANT_TRUE, "Visible = %x\n", hres); + ok(b == VARIANT_TRUE, "Visible = %x\n", b); hres = IWebBrowser2_put_Visible(wb, VARIANT_FALSE); ok(hres == S_OK, "put_Visible failed: %08x\n", hres); @@ -246,6 +246,17 @@ static void test_navigate(IWebBrowser2 *wb, const char *url) CHECK_CALLED(Invoke_NAVIGATECOMPLETE2); } +static void test_busy(IWebBrowser2 *wb) +{ + VARIANT_BOOL b; + HRESULT hres; + + b = 0xdead; + hres = IWebBrowser2_get_Busy(wb, &b); + ok(hres == S_OK, "get_Busy failed: %08x\n", hres); + ok(b == VARIANT_FALSE, "Busy = %x\n", b); +} + static void test_InternetExplorer(void) { IWebBrowser2 *wb; @@ -269,6 +280,7 @@ static void test_InternetExplorer(void) advise_cp(unk, TRUE); + test_busy(wb); test_visible(wb); test_html_window(wb); test_window(wb); -- 2.20.1

3 2

[PATCH] msvcrt: Return time since CRT initialization in clock function.
by Piotr Caban 16 Oct '19

16 Oct '19

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msvcrt/main.c | 1 + dlls/msvcrt/msvcrt.h | 1 + dlls/msvcrt/tests/time.c | 18 ------------------ dlls/msvcrt/time.c | 25 +++++++++++-------------- dlls/ucrtbase/tests/misc.c | 23 +++++++++++++++++++++++ 5 files changed, 36 insertions(+), 32 deletions(-)

2 1

[PATCH v2] msvcrt: Return time since CRT initialization in clock function.
by Piotr Caban 16 Oct '19

16 Oct '19

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msvcrt/main.c | 1 + dlls/msvcrt/msvcrt.h | 1 + dlls/msvcrt/tests/time.c | 18 ------------------ dlls/msvcrt/time.c | 25 +++++++++++-------------- dlls/ucrtbase/tests/misc.c | 25 +++++++++++++++++++++++++ 5 files changed, 38 insertions(+), 32 deletions(-)

1 0

[PATCH 1/2] user32/combo: Draw comboboxes with correct background
by Fabian Maurer 16 Oct '19

16 Oct '19

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46417 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> --- dlls/user32/combo.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dlls/user32/combo.c b/dlls/user32/combo.c index 59c2e6484c..a126922a74 100644 --- a/dlls/user32/combo.c +++ b/dlls/user32/combo.c @@ -1912,6 +1912,9 @@ LRESULT ComboWndProc_common( HWND hwnd, UINT message, WPARAM wParam, LPARAM lPar } else return CB_ERR; + case WM_CTLCOLORSTATIC: + case WM_CTLCOLOREDIT: + return (LRESULT)GetSysColorBrush(COLOR_WINDOW); case WM_DRAWITEM: case WM_DELETEITEM: case WM_COMPAREITEM: -- 2.23.0

3 8

[PATCH v2] wshom.ocx: Correct out parameter for _NewEnum
by Alistair Leslie-Hughes 16 Oct '19

16 Oct '19

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- dlls/wshom.ocx/shell.c | 2 +- dlls/wshom.ocx/tests/wshom.idl | 2 +- dlls/wshom.ocx/wshom.idl | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/wshom.ocx/shell.c b/dlls/wshom.ocx/shell.c index d423856ce7a..543d951ea05 100644 --- a/dlls/wshom.ocx/shell.c +++ b/dlls/wshom.ocx/shell.c @@ -698,7 +698,7 @@ static HRESULT WINAPI WshCollection_get_length(IWshCollection *iface, LONG *coun return E_NOTIMPL; } -static HRESULT WINAPI WshCollection__NewEnum(IWshCollection *iface, IUnknown *Enum) +static HRESULT WINAPI WshCollection__NewEnum(IWshCollection *iface, IUnknown **Enum) { WshCollection *This = impl_from_IWshCollection(iface); FIXME("(%p)->(%p): stub\n", This, Enum); diff --git a/dlls/wshom.ocx/tests/wshom.idl b/dlls/wshom.ocx/tests/wshom.idl index 039938c82b0..00391d52838 100644 --- a/dlls/wshom.ocx/tests/wshom.idl +++ b/dlls/wshom.ocx/tests/wshom.idl @@ -383,7 +383,7 @@ library IWshRuntimeLibrary HRESULT length([out, retval] long *out_Count); [id(DISPID_NEWENUM)] - HRESULT _NewEnum([out, retval] IUnknown *out_Enum); + HRESULT _NewEnum([out, retval] IUnknown **out_Enum); } [ diff --git a/dlls/wshom.ocx/wshom.idl b/dlls/wshom.ocx/wshom.idl index d9367215890..8d4a8f03e17 100644 --- a/dlls/wshom.ocx/wshom.idl +++ b/dlls/wshom.ocx/wshom.idl @@ -383,7 +383,7 @@ library IWshRuntimeLibrary HRESULT length([out, retval] long *out_Count); [id(DISPID_NEWENUM)] - HRESULT _NewEnum([out, retval] IUnknown *out_Enum); + HRESULT _NewEnum([out, retval] IUnknown **out_Enum); } [ -- 2.23.0

2 1

[PATCH] wineps.drv: Don't clear DM_PAPERWIDTH | DM_PAPERLENGTH flags.
by Dmitry Timoshkov 16 Oct '19

16 Oct '19

dmFields should indicate that DEVMODE has dmPaperWidth and dmPaperLength set. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/wineps.drv/driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dlls/wineps.drv/driver.c b/dlls/wineps.drv/driver.c index 173f6db7bd..c3d22cec1a 100644 --- a/dlls/wineps.drv/driver.c +++ b/dlls/wineps.drv/driver.c @@ -110,8 +110,7 @@ void PSDRV_MergeDevmodes( PSDRV_DEVMODE *dm1, const PSDRV_DEVMODE *dm2, PRINTERI dm1->dmPublic.u1.s1.dmPaperSize = dm2->dmPublic.u1.s1.dmPaperSize; dm1->dmPublic.u1.s1.dmPaperWidth = paper_size_from_points( page->PaperDimension->x ); dm1->dmPublic.u1.s1.dmPaperLength = paper_size_from_points( page->PaperDimension->y ); - dm1->dmPublic.dmFields &= ~(DM_PAPERLENGTH | DM_PAPERWIDTH); - dm1->dmPublic.dmFields |= DM_PAPERSIZE; + dm1->dmPublic.dmFields |= DM_PAPERSIZE | DM_PAPERWIDTH | DM_PAPERLENGTH; TRACE("Changing page to %s %d x %d\n", page->FullName, dm1->dmPublic.u1.s1.dmPaperWidth, dm1->dmPublic.u1.s1.dmPaperLength ); -- 2.20.1

2 1