December 2019 - Wine-devel - list.winehq.org

[PATCH] wininet/tests: Increase the maximum expected available data value.
by Francois Gouget 04 Dec '19

04 Dec '19

With each Windows version InternetQueryDataAvailable() reports a different value. 8192 from XP/2003 to Vista/2008; then 1460 from Windows 7 to Windows 10 1709; and 24000 starting with Windows 10 1809. Signed-off-by: Francois Gouget <fgouget(a)free.fr> --- This fixes a failure on Windows 10 1809. I'm not entirely sure it makes sense to check for this value. If we do, maybe we should leave a bigger margin? Like < 31000? Not that it did us much good last time... Also, shouldn't we check that it is greater than some minimum value? Like at least 1000? References: https://test.winehq.org/data/190fb605c34ac1365076dff0a6560ddb42ca1ef2/index… Look for the entries with 4 failures. https://testbot.winehq.org/JobDetails.pl?Key=60767 Look for the 'avail=' traces. dlls/wininet/tests/http.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/wininet/tests/http.c b/dlls/wininet/tests/http.c index c7472c7ea09..a72c9ed0518 100644 --- a/dlls/wininet/tests/http.c +++ b/dlls/wininet/tests/http.c @@ -5549,9 +5549,9 @@ static void test_http_read(int port) readex_expect_sync_data(req.request, IRF_NO_WAIT, &ib, sizeof(buf), "123", 0); readex_expect_async(req.request, IRF_NO_WAIT, &ib, sizeof(buf), NULL); - send_response_len_and_wait(20000, TRUE, &ib); + send_response_len_and_wait(32000, TRUE, &ib); avail = expect_data_available(req.request, -1); - ok(avail < 17000, "avail = %u\n", avail); + ok(avail < 25000, "avail = %u\n", avail); SET_WINE_ALLOW(INTERNET_STATUS_CLOSING_CONNECTION); SET_WINE_ALLOW(INTERNET_STATUS_CONNECTION_CLOSED); -- 2.20.1

3 2

[PATCH] ieframe: implement COM aggregation in WebBrowser
by Damjan Jovanovic 04 Dec '19

04 Dec '19

Wine's WebBrowser currently just ignores the "outer" it is passed. Support COM aggregation like Windows does instead. Signed-off-by: Damjan Jovanovic <damjan.jov(a)gmail.com> --- dlls/ieframe/classinfo.c | 6 +- dlls/ieframe/ieframe.h | 2 + dlls/ieframe/oleobject.c | 30 +-- dlls/ieframe/persist.c | 18 +- dlls/ieframe/tests/webbrowser.c | 42 +++++ dlls/ieframe/view.c | 12 +- dlls/ieframe/webbrowser.c | 323 ++++++++++++++++++-------------- 7 files changed, 259 insertions(+), 174 deletions(-)

3 2

[PATCH] mshtml/tests: Fix a typo in ok() message.
by Andrey Gusev 04 Dec '19

04 Dec '19

Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> --- dlls/mshtml/tests/dom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index ff7c62bdfc..3234e66cd5 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -2058,7 +2058,7 @@ static IHTMLDOMAttribute *_create_attr(unsigned line, IUnknown *unk, const char HRESULT hres; hres = IHTMLDocument5_createAttribute(doc, str, &attr); - ok_(__FILE__,line)(hres == S_OK, "createAttribute dailed: %08x\n", hres); + ok_(__FILE__,line)(hres == S_OK, "createAttribute failed: %08x\n", hres); SysFreeString(str); IHTMLDocument5_Release(doc); -- 2.23.0

2 1

[PATCH 09/10 v3] msvcrt: Create global C locale __lc_time_data struct.
by Piotr Caban 04 Dec '19

04 Dec '19

From: Jeff Smith <whydoubt(a)gmail.com> Signed-off-by: Jeff Smith <whydoubt(a)gmail.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- v3: - added missing const dlls/msvcrt/locale.c | 158 ++++++++++++++++++++++++++----------------- dlls/msvcrt/msvcrt.h | 1 + 2 files changed, 97 insertions(+), 62 deletions(-)

1 0

[PATCH 09/10 v2] msvcrt: Create global C locale __lc_time_data struct.
by Piotr Caban 04 Dec '19

04 Dec '19

From: Jeff Smith <whydoubt(a)gmail.com> Signed-off-by: Jeff Smith <whydoubt(a)gmail.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msvcrt/locale.c | 158 ++++++++++++++++++++++++++----------------- dlls/msvcrt/msvcrt.h | 1 + 2 files changed, 97 insertions(+), 62 deletions(-)

2 1

[PATCH 10/10 v2] ucrtbase: Correct behavior of strftime formats %c %r.
by Piotr Caban 04 Dec '19

04 Dec '19

From: Jeff Smith <whydoubt(a)gmail.com> Signed-off-by: Jeff Smith <whydoubt(a)gmail.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msvcrt/time.c | 14 +++++++++++++- dlls/ucrtbase/tests/misc.c | 8 ++++---- 2 files changed, 17 insertions(+), 5 deletions(-)

1 0

[PATCH 08/10 v2] msvcrt: Mark __lc_time_data strings const.
by Piotr Caban 04 Dec '19

04 Dec '19

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msvcrt/locale.c | 2 +- dlls/msvcrt/msvcrt.h | 42 +++++++++++++++++++++--------------------- 2 files changed, 22 insertions(+), 22 deletions(-)

1 0

[PATCH 07/10 v2] msvcrt: Don't depend on how __lc_time_data was allocated in _Gettnames.
by Piotr Caban 04 Dec '19

04 Dec '19

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msvcrt/locale.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)

1 0

[PATCH 06/10 v2] msvcrt: Don't depend on how __lc_time_data was allocated in _W_Getmonths.
by Piotr Caban 04 Dec '19

04 Dec '19

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msvcrt/locale.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)

1 0

[PATCH 05/10 v2] msvcrt: Don't depend on how __lc_time_data was allocated in _Getmonths.
by Piotr Caban 04 Dec '19

04 Dec '19

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msvcrt/locale.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)

1 0