February 2019 - Wine-devel - list.winehq.org

[PATCH] msvcp120/tests: Avoid using the comma operator.
by Michael Stefaniuc 27 Feb '19

27 Feb '19

Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/msvcp120/tests/msvcp120.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/msvcp120/tests/msvcp120.c b/dlls/msvcp120/tests/msvcp120.c index 70fc0c13dc..c1c7002f26 100644 --- a/dlls/msvcp120/tests/msvcp120.c +++ b/dlls/msvcp120/tests/msvcp120.c @@ -924,13 +924,13 @@ static void test_xtime_get(void) } /* Test parameter and return value */ - before.sec = 0xdeadbeef, before.nsec = 0xdeadbeef; + before.sec = 0xdeadbeef; before.nsec = 0xdeadbeef; i = p_xtime_get(&before, 0); ok(i == 0, "expect xtime_get() to return 0, got: %d\n", i); ok(before.sec == 0xdeadbeef && before.nsec == 0xdeadbeef, "xtime_get() shouldn't have modified the xtime struct with the given option\n"); - before.sec = 0xdeadbeef, before.nsec = 0xdeadbeef; + before.sec = 0xdeadbeef; before.nsec = 0xdeadbeef; i = p_xtime_get(&before, 1); ok(i == 1, "expect xtime_get() to return 1, got: %d\n", i); ok(before.sec != 0xdeadbeef && before.nsec != 0xdeadbeef, -- 2.20.1

2 1

[PATCH 7/8] server: Allow clients to get handle from kernel object pointer.
by Jacek Caban 27 Feb '19

27 Feb '19

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- server/device.c | 19 +++++++++++++++++++ server/protocol.def | 10 ++++++++++ 2 files changed, 29 insertions(+)

2 1

[PATCH 5/8] server: Make sure that IRP_MJ_CLOSE is queued only once.
by Jacek Caban 27 Feb '19

27 Feb '19

In case client opens new handles while handling close. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- server/device.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)

2 1

[PATCH 4/8] server: Allow queuing IRPs with no file associated.
by Jacek Caban 27 Feb '19

27 Feb '19

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- server/device.c | 29 +++++++++++++++++------------ 1 file changed, 17 insertions(+), 12 deletions(-)

2 1

[PATCH 8/8] ntoskrnl.exe: Support event objects created from server handle.
by Jacek Caban 27 Feb '19

27 Feb '19

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/ntoskrnl.exe/ntoskrnl.c | 14 +++++ dlls/ntoskrnl.exe/ntoskrnl_private.h | 3 ++ dlls/ntoskrnl.exe/sync.c | 76 +++++++++++++++++++++++----- dlls/ntoskrnl.exe/tests/driver.c | 36 ++++++++++++- 4 files changed, 115 insertions(+), 14 deletions(-)

1 0

[PATCH 6/8] server: Notify client about freed object so that it may free associated kernel object.
by Jacek Caban 27 Feb '19

27 Feb '19

Long term, we may consider making interface between server and device manager more generic so that it could be used for messages other than IRPs. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/ntoskrnl.exe/ntoskrnl.c | 14 +++++++++++++- server/device.c | 15 +++++++++++++++ server/protocol.def | 6 ++++++ 3 files changed, 34 insertions(+), 1 deletion(-)

1 0

[PATCH 3/8] server: Allow kernel to keep reference to server objects by pointer.
by Jacek Caban 27 Feb '19

27 Feb '19

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- At some point, I considered and prototyped storing a handle on client side as a handle. It lead into a number of problems. For example handle count was not right, breaking things like IRP_MJ_CLOSE implementation. A separated mechanism worked much better. dlls/ntoskrnl.exe/ntoskrnl.c | 45 ++++++++++++++++++++++++--- server/device.c | 60 ++++++++++++++++++++++++++++++++++++ server/protocol.def | 14 +++++++++ 3 files changed, 115 insertions(+), 4 deletions(-)

1 0

[PATCH 2/8] server: Store pointers to objects created by kernel_object_from_handle in server.
by Jacek Caban 27 Feb '19

27 Feb '19

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/ntoskrnl.exe/ntoskrnl.c | 104 ++++++++++++++++++++++++------- dlls/ntoskrnl.exe/tests/driver.c | 3 - server/device.c | 84 +++++++++++++++++++++++++ server/protocol.def | 17 +++++ 4 files changed, 182 insertions(+), 26 deletions(-)

1 0

Checking for manifest in comctl32 for custom draw
by Gabriel Ivăncescu 27 Feb '19

27 Feb '19

Trying to implement custom draw for buttons to fix https://bugs.winehq.org/show_bug.cgi?id=10531 and I have a question about the manifest as mentioned in the bug report. I notice that the tests already assume that comctl32 has these enabled, and they work on Windows, so is it really necessary to check for the manifest at all? Obviously, fixing this would only go into comctl32/button and not in user32/button because the latter doesn't have custom draw on Windows. Do I still have to check for the manifest? And if so, can someone please point me to the right direction on how to do that? I've no knowledge of this at all. Thank you.

2 2

WineConf 2019: call for volunteers
by Alexandre Julliard 27 Feb '19

27 Feb '19

Folks, It's time to start thinking about this year's Wine conference! Until now, selecting the next WineConf was a more or less ad-hoc process, but we had some discussions on the wineconf list a while ago, and it was suggested that the Wine Committee should play a more active role in the decision, especially since the chosen location impacts the financial decisions. Ideally we'd define a formal set of requirements, and issue a Call for Proposals, but it was felt that this would take too much time and thus would be more appropriate for 2020. So I thought that for this year we'd do a simple call for volunteers, and have the Wine Committee work with the volunteers to select the best proposal. So, would anybody like to volunteer to host WineConf 2019? -- Alexandre Julliard julliard(a)winehq.org

1 0