May 2019 - Wine-devel - list.winehq.org

[website] German translation for release 4.7
by Julian Rüger 27 May '19

27 May '19

Signed-off-by: Julian Rüger <jr98(a)gmx.net>

1 0

[website] German translation for release 4.6
by Julian Rüger 27 May '19

27 May '19

Signed-off-by: Julian Rüger <jr98(a)gmx.net>

1 0

[PATCH] dinput/tests: Remove unrequired if (Coverity)
by Alistair Leslie-Hughes 26 May '19

26 May '19

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- dlls/dinput/tests/keyboard.c | 2 +- dlls/dinput/tests/mouse.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/dinput/tests/keyboard.c b/dlls/dinput/tests/keyboard.c index 9254123..d6ab5b5 100644 --- a/dlls/dinput/tests/keyboard.c +++ b/dlls/dinput/tests/keyboard.c @@ -479,7 +479,7 @@ static void test_GetDeviceInfo(IDirectInputA *pDI) wine_dbgstr_guid(&instA.guidProduct), wine_dbgstr_guid(&inst3A.guidProduct) ); ok(instA.dwDevType == inst3A.dwDevType, "got %d, %d\n", instA.dwDevType, inst3A.dwDevType); - if (pKey) IUnknown_Release(pKey); + IUnknown_Release(pKey); } static void keyboard_tests(DWORD version) diff --git a/dlls/dinput/tests/mouse.c b/dlls/dinput/tests/mouse.c index c5cb684..e4d24e8 100644 --- a/dlls/dinput/tests/mouse.c +++ b/dlls/dinput/tests/mouse.c @@ -224,7 +224,7 @@ static void test_GetDeviceInfo(IDirectInputA *pDI) wine_dbgstr_guid(&instA.guidProduct), wine_dbgstr_guid(&inst3A.guidProduct) ); ok(instA.dwDevType == inst3A.dwDevType, "got %d, %d\n", instA.dwDevType, inst3A.dwDevType); - if (pMouse) IUnknown_Release(pMouse); + IUnknown_Release(pMouse); } static BOOL CALLBACK EnumAxes(const DIDEVICEOBJECTINSTANCEA *pdidoi, void *pContext) -- 1.9.1

2 1

[PATCH] amstream: Leave Critial Section on success (Coverity)
by Alistair Leslie-Hughes 26 May '19

26 May '19

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- dlls/amstream/mediastreamfilter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/amstream/mediastreamfilter.c b/dlls/amstream/mediastreamfilter.c index 2daffea..48dfc85 100644 --- a/dlls/amstream/mediastreamfilter.c +++ b/dlls/amstream/mediastreamfilter.c @@ -367,6 +367,7 @@ static HRESULT WINAPI MediaStreamFilterImpl_FindPin(IMediaStreamFilter *iface, c { CoTaskMemFree(ret_id); *out = pin; + LeaveCriticalSection(&filter->cs); return S_OK; } CoTaskMemFree(ret_id); -- 1.9.1

1 0

[PATCH] kernel32/tests: Open and close the right file handle (Coverity).
by Sven Baars 26 May '19

26 May '19

Signed-off-by: Sven Baars <sven.wine(a)gmail.com> --- dlls/kernel32/tests/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c index 9bf80f6388..b22ae19f2e 100644 --- a/dlls/kernel32/tests/file.c +++ b/dlls/kernel32/tests/file.c @@ -3735,13 +3735,13 @@ static void test_ReplaceFileA(void) /* replace file while replacement is opened */ ret = GetTempFileNameA(temp_path, prefix, 0, replacement); ok(ret != 0, "GetTempFileNameA error (replacement) %d\n", GetLastError()); - CreateFileA(replacement, GENERIC_READ | SYNCHRONIZE, FILE_SHARE_READ | FILE_SHARE_DELETE, NULL, OPEN_EXISTING, 0, 0); + hReplacementFile = CreateFileA(replacement, GENERIC_READ | SYNCHRONIZE, FILE_SHARE_READ | FILE_SHARE_DELETE, NULL, OPEN_EXISTING, 0, 0); ok(hReplacementFile != INVALID_HANDLE_VALUE, "unexpected error, replacement file should be able to be opened %d\n", GetLastError()); ret = pReplaceFileA(replaced, replacement, NULL, 0, 0, 0); ok(!ret, "expect failure\n"); ok(GetLastError() == ERROR_SHARING_VIOLATION, "expect ERROR_SHARING_VIOLATION, got %#x.\n", GetLastError()); - CloseHandle(hReplacedFile); + CloseHandle(hReplacementFile); /* replacement file still exists, make pass w/o "replaced" */ ret = DeleteFileA(replaced); -- 2.17.1

2 1

Wine staging 4.9 release
by Alistair Leslie-Hughes 26 May '19

26 May '19

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 4.9 (831 patches are applied to wine vanilla) NOTE: FAudio will not be supported until distro's have FAudio library as part of their standard repositories. Upstreamed (Either directly from staging or fixed with a similar patch). * dinput: Allow Enumeration of joysticks with DirectX 3. * windowscodecs: Improve compatibility of IMILBitmapSource interface. * windowscodecs: Add support for IMILBitmapScaler interface. * amstream: Avoid implicit cast of interface pointer. Added: * [47018] gdi32: Paint 32-bpp bitmaps with an alpha channel using GdiAlphaBlend. * [47235] ncrypt: Steep (Uplay) crashes on unimplemented function ncrypt.dll.BCryptSecretAgreement Updated: * ntdll-Junction_Points * bcrypt-BCryptSecretAgreement * winebuild-Fake_Dlls Where can you help * Run Steam/Battle.net/UPlay. * Try you favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

2 1

[PATCH v2 1/6] advapi32/tests: Add more RegLoadMUIString tests.
by Akihiro Sagawa 26 May '19

26 May '19

In v2, fix test failures on Vista. Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/advapi32/tests/Makefile.in | 2 ++ dlls/advapi32/tests/registry.c | 79 ++++++++++++++++++++++++++++++++++++++++- dlls/advapi32/tests/rsrc.rc | 22 ++++++++++++ 3 files changed, 102 insertions(+), 1 deletion(-) create mode 100644 dlls/advapi32/tests/rsrc.rc

2 1

[PATCH v2 6/6] advapi32: Cache result of LoadString.
by Akihiro Sagawa 26 May '19

26 May '19

Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/advapi32/registry.c | 144 ++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 135 insertions(+), 9 deletions(-)

1 0

[PATCH v2 5/6] advapi32: Fix the error code on load failure.
by Akihiro Sagawa 26 May '19

26 May '19

Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/advapi32/registry.c | 12 ++++++------ dlls/advapi32/tests/registry.c | 8 +++----- 2 files changed, 9 insertions(+), 11 deletions(-)

1 0

[PATCH v2 4/6] advapi32: Fix the error code on parse failure.
by Akihiro Sagawa 26 May '19

26 May '19

Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/advapi32/registry.c | 2 +- dlls/advapi32/tests/registry.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)

1 0