May 2019 - Wine-devel - list.winehq.org

[PATCH 4/4] hid: Set button values in HidP_SetUsages function.
by Piotr Caban 13 May '19

13 May '19

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/hid/hidp.c | 20 ++++++++++---------- include/ddk/hidpi.h | 3 +++ 2 files changed, 13 insertions(+), 10 deletions(-)

3 2

[PATCH 3/4] hidclass.sys: Support descriptors with over 10 individual usages in feature.
by Piotr Caban 13 May '19

13 May '19

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/hidclass.sys/descriptor.c | 300 +++++++++++++++------------------ 1 file changed, 137 insertions(+), 163 deletions(-)

3 2

[PATCH 2/4] hidclass.sys: Remove no longer used features list.
by Piotr Caban 13 May '19

13 May '19

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/hidclass.sys/descriptor.c | 29 +++++++++++------------------ 1 file changed, 11 insertions(+), 18 deletions(-)

3 2

[PATCH 1/4] hid: Change format of preparsed data.
by Piotr Caban 13 May '19

13 May '19

Advantages of this format: - all table elements have constant size, that makes iterating table easier - allow report lookup by report ID in O(1) time - doesn't sort reports, it makes it possible to preserve original order of elements making output of functions more similar to native - preparsed data is created from collection, this will allow to add support for multiple top-most collections Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/hid/hidp.c | 239 +++++++----------- dlls/hid/parse.h | 39 ++- dlls/hidclass.sys/descriptor.c | 437 +++++++++++---------------------- dlls/hidclass.sys/device.c | 4 +- dlls/hidclass.sys/parse.h | 25 +- 5 files changed, 250 insertions(+), 494 deletions(-)

3 2

[PATCH 1/8] winbase: added missing Process Creation Flags
by Roman Stingler 13 May '19

13 May '19

From: romanstingler <roman.stingler(a)gmail.com> Signed-off-by: romanstingler <roman.stingler(a)gmail.com> Signed-off-by: Roman Stingler <roman.stingler(a)gmail.com> --- include/winbase.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/winbase.h b/include/winbase.h index 314a8b7f60..3fdfec3d57 100644 --- a/include/winbase.h +++ b/include/winbase.h @@ -694,6 +694,11 @@ typedef struct _TIME_ZONE_INFORMATION{ #define PROFILE_USER 0x10000000 #define PROFILE_KERNEL 0x20000000 #define PROFILE_SERVER 0x40000000 +#define CREATE_PROTECTED_PROCESS 0x00040000 +#define CREATE_PRESERVE_CODE_AUTHZ_LEVEL 0x02000000 +#define CREATE_SECURE_PROCESS 0x00400000 +#define EXTENDED_STARTUPINFO_PRESENT 0x00080000 +#define INHERIT_PARENT_AFFINITY 0x00010000 /* File object type definitions -- 2.21.0

2 9

[PATCH 1/6] dwrite/layout: Use a helper to update layout metrics.
by Nikolay Sivov 13 May '19

13 May '19

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- dlls/dwrite/layout.c | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/dlls/dwrite/layout.c b/dlls/dwrite/layout.c index d101a5a197..40621ce170 100644 --- a/dlls/dwrite/layout.c +++ b/dlls/dwrite/layout.c @@ -3592,17 +3592,21 @@ static HRESULT WINAPI dwritetextlayout_GetLineMetrics(IDWriteTextLayout3 *iface, return max_count >= This->metrics.lineCount ? S_OK : E_NOT_SUFFICIENT_BUFFER; } +static HRESULT layout_update_metrics(struct dwrite_textlayout *layout) +{ + return layout_compute_effective_runs(layout); +} + static HRESULT WINAPI dwritetextlayout_GetMetrics(IDWriteTextLayout3 *iface, DWRITE_TEXT_METRICS *metrics) { - struct dwrite_textlayout *This = impl_from_IDWriteTextLayout3(iface); - DWRITE_TEXT_METRICS1 metrics1; + struct dwrite_textlayout *layout = impl_from_IDWriteTextLayout3(iface); HRESULT hr; - TRACE("(%p)->(%p)\n", This, metrics); + TRACE("%p, %p.\n", iface, metrics); - hr = IDWriteTextLayout3_GetMetrics(iface, &metrics1); + hr = layout_update_metrics(layout); if (hr == S_OK) - memcpy(metrics, &metrics1, sizeof(*metrics)); + memcpy(metrics, &layout->metrics, sizeof(*metrics)); return hr; } @@ -3932,17 +3936,15 @@ static HRESULT WINAPI dwritetextlayout1_GetCharacterSpacing(IDWriteTextLayout3 * static HRESULT WINAPI dwritetextlayout2_GetMetrics(IDWriteTextLayout3 *iface, DWRITE_TEXT_METRICS1 *metrics) { - struct dwrite_textlayout *This = impl_from_IDWriteTextLayout3(iface); + struct dwrite_textlayout *layout = impl_from_IDWriteTextLayout3(iface); HRESULT hr; - TRACE("(%p)->(%p)\n", This, metrics); + TRACE("%p, %p.\n", iface, metrics); - hr = layout_compute_effective_runs(This); - if (FAILED(hr)) - return hr; + if (SUCCEEDED(hr = layout_update_metrics(layout))) + *metrics = layout->metrics; - *metrics = This->metrics; - return S_OK; + return hr; } static HRESULT WINAPI dwritetextlayout2_SetVerticalGlyphOrientation(IDWriteTextLayout3 *iface, DWRITE_VERTICAL_GLYPH_ORIENTATION orientation) -- 2.20.1

1 5

[PATCH] winedbg: Avoid truncating a 32 bit exception code as exit code
by Martin Storsjo 13 May '19

13 May '19

On unix, traditionally only the lower 8 bits of the exit code are returned. In case ExceptionCode is EXCEPTION_WINE_STUB, 80000100, the observed exit code outside is zero, which would indicate successful execution. Therefore, just return a one, instead of trying to pass on the whole exception code, of which only a quarter is returned on unix. Signed-off-by: Martin Storsjo <martin(a)martin.st> --- programs/winedbg/tgt_active.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/programs/winedbg/tgt_active.c b/programs/winedbg/tgt_active.c index 5385d0effa..0a4453f8d6 100644 --- a/programs/winedbg/tgt_active.c +++ b/programs/winedbg/tgt_active.c @@ -977,7 +977,7 @@ static BOOL tgt_process_active_close_process(struct dbg_process* pcs, BOOL kill) DWORD exit_code = 0; if (pcs == dbg_curr_process && dbg_curr_thread->in_exception) - exit_code = dbg_curr_thread->excpt_record.ExceptionCode; + exit_code = 1; TerminateProcess(pcs->handle, exit_code); } -- 2.17.1

3 2

[PATCH] msvcrt: Hook up _setjmpex for arm64 as well
by Martin Storsjo 13 May '19

13 May '19

Signed-off-by: Martin Storsjo <martin(a)martin.st> --- dlls/msvcrt/msvcrt.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/msvcrt/msvcrt.spec b/dlls/msvcrt/msvcrt.spec index 7958a7a047..952de55b49 100644 --- a/dlls/msvcrt/msvcrt.spec +++ b/dlls/msvcrt/msvcrt.spec @@ -902,7 +902,7 @@ @ cdecl _seterrormode(long) @ cdecl -arch=i386,x86_64,arm,arm64 -norelay _setjmp(ptr) MSVCRT__setjmp @ cdecl -arch=i386 -norelay _setjmp3(ptr long) MSVCRT__setjmp3 -@ cdecl -arch=x86_64,arm -norelay _setjmpex(ptr ptr) MSVCRT__setjmpex +@ cdecl -arch=x86_64,arm,arm64 -norelay _setjmpex(ptr ptr) MSVCRT__setjmpex @ cdecl _setmaxstdio(long) MSVCRT__setmaxstdio @ cdecl _setmbcp(long) @ cdecl _setmode(long long) MSVCRT__setmode -- 2.17.1

2 1

[PATCH] po: Update Asturian translation.
by Enol Puente 13 May '19

13 May '19

2 1

[PATCH] services: Allow reading binary registry values as DWORDs
by Tim Schumacher 12 May '19

12 May '19

Some programs/services actually save those values as a registry value of the type REG_BINARY. As long as the size matches it shouldn't be a problem to just interpret it as a DWORD type, but warn anyways in case someone runs into issues. --- This fixes the following: Bug 47178 - Grand Prix Legends: Service papycpu2 doesn't load --- programs/services/utils.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/programs/services/utils.c b/programs/services/utils.c index c59b003e58..6f6ae42730 100644 --- a/programs/services/utils.c +++ b/programs/services/utils.c @@ -149,11 +149,15 @@ DWORD load_reg_dword(HKEY hKey, LPCWSTR szValue, DWORD *output) return ERROR_SUCCESS; goto failed; } - if (type != REG_DWORD || size != sizeof(DWORD)) + if ((type != REG_DWORD && type != REG_BINARY) || size != sizeof(DWORD)) { err = ERROR_INVALID_DATATYPE; goto failed; } + + if (type == REG_BINARY) + WINE_WARN("Read binary value as a DWORD. szValue: %s, output: %d\n", wine_dbgstr_w(szValue), *output); + return ERROR_SUCCESS; failed: -- 2.21.0

1 1