February 2020 - Wine-devel - list.winehq.org

[PATCH 04/10] stdio.h: Add ucrt printf and vprintf declarations.
by Jacek Caban 21 Feb '20

21 Feb '20

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- include/msvcrt/stdio.h | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-)

1 0

[PATCH 03/10] stdio.h: Add ucrt fprintf and fprintf_s declarations.
by Jacek Caban 21 Feb '20

21 Feb '20

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- include/msvcrt/stdio.h | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-)

1 0

[PATCH 02/10] stdio.h: Add ucrt _snprintf_s declaration.
by Jacek Caban 21 Feb '20

21 Feb '20

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- include/msvcrt/stdio.h | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)

1 0

[PATCH 01/10] stdio.h: Add ucrt _scprintf declaration.
by Jacek Caban 21 Feb '20

21 Feb '20

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/msvcp90/msvcp_main.c | 10 ---------- include/msvcrt/stdio.h | 15 +++++++++++++-- 2 files changed, 13 insertions(+), 12 deletions(-)

1 0

[PATCH v2 1/3] winegcc: Recognize -rtlib as linker argument.
by Jacek Caban 21 Feb '20

21 Feb '20

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- tools/winegcc/winegcc.c | 3 +++ 1 file changed, 3 insertions(+)

1 0

[PATCH 3/3] winegcc: Clean up output file on error.
by Jacek Caban 21 Feb '20

21 Feb '20

Based on winebuild. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- tools/winegcc/winegcc.c | 10 ++++++++++ 1 file changed, 10 insertions(+)

1 0

[PATCH 2/3] winegcc: Treat -target argument as an alias to --target for clang compatibility.
by Jacek Caban 21 Feb '20

21 Feb '20

clang uses -target for the same thing as we do. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- tools/winegcc/winegcc.c | 10 ++++++++++ 1 file changed, 10 insertions(+)

1 0

[PATCH 1/3] winegcc: Recognize -rtlib as linker argument.
by Jacek Caban 21 Feb '20

21 Feb '20

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- tools/winegcc/winegcc.c | 3 +++ 1 file changed, 3 insertions(+)

1 0

[PATCH v2] user32/caret.c: Avoid SetSystemTimer / KillSystemTimer with null hwnd.
by Robert Schlicht 21 Feb '20

21 Feb '20

This patch (ID 178871) has been superseded by the patch with ID 179405 [PATCH] server: Make set_caret_info fail if there is no caret window. Signed-off-by: Robert Schlicht <patch(a)rschlicht.eu>

1 0

[PATCH] server: Make set_caret_info fail if there is no caret window.
by Robert Schlicht 21 Feb '20

21 Feb '20

Additional experimenting on Windows shows that if there is not caret window, then ShowCaret, HideCaret, SetCaretPos and DestroyCaret fail with ERROR_ACCESS_DENIED. This is true even though the caret position is preserved and returned by GetCaretPos. The current Wine implementation causes calls such as ShowCaret(0) to proceed as if a caret window would exist. This is an issue because the call leaks a timer when the hide count has its initial value 1 since SetSystemTimer( hwnd, TIMERID, Caret.timeout, CARET_Callback ); (user32/caret.c) does not use TIMERID if hwnd is null. This happens, for example, when a menu is closing (see MENU_ExitTracking() in user32/menu.c). The patch makes the set_caret_info request fail (except for GetCaretPos) if there is no caret window so that the caret functions do not manipulate timers and properly return failure. This patch supersedes the patch with ID 178871. Signed-off-by: Robert Schlicht <patch(a)rschlicht.eu> --- server/queue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/queue.c b/server/queue.c index b5e17be18f..07f43d2c82 100644 --- a/server/queue.c +++ b/server/queue.c @@ -3025,9 +3025,9 @@ DECL_HANDLER(set_caret_info) reply->old_hide = input->caret_hide; reply->old_state = input->caret_state; - if (req->handle && get_user_full_handle(req->handle) != input->caret) + if (!input->caret || (req->handle && get_user_full_handle(req->handle) != input->caret)) { - set_error( STATUS_ACCESS_DENIED ); + if (req->flags) set_error( STATUS_ACCESS_DENIED ); return; } if (req->flags & SET_CARET_POS) -- 2.17.1

1 0