March 2020 - Wine-devel - list.winehq.org

[PATCH 6/8] dbghelp: Use local declaratin for 64-bit macho nlist.
by Jacek Caban 29 Mar '20

29 Mar '20

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/dbghelp/image_private.h | 9 +++++++++ dlls/dbghelp/macho_module.c | 2 +- dlls/dbghelp/stabs.c | 17 ++--------------- 3 files changed, 12 insertions(+), 16 deletions(-)

1 0

[PATCH 5/8] dbghelp: Use local stab_nlist declaration in macho_module.c.
by Jacek Caban 29 Mar '20

29 Mar '20

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/dbghelp/image_private.h | 9 +++++++++ dlls/dbghelp/macho_module.c | 2 +- dlls/dbghelp/stabs.c | 10 +--------- 3 files changed, 11 insertions(+), 10 deletions(-)

1 0

[PATCH 4/8] dbghelp: Clear N_PEXT flag of stab type in macho files.
by Jacek Caban 29 Mar '20

29 Mar '20

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/dbghelp/stabs.c | 3 +++ 1 file changed, 3 insertions(+)

1 0

[PATCH 3/8] dbghelp: Provide N_PEXT and N_SECT defines when not available.
by Jacek Caban 29 Mar '20

29 Mar '20

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/dbghelp/stabs.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)

1 0

[PATCH 2/8] dbghelp: Use DWARF registry mapping quirk only for actual macho modules.
by Jacek Caban 29 Mar '20

29 Mar '20

Fixes handling DWARF in PE on macOS. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/dbghelp/cpu_i386.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

1 0

[PATCH 1/8] dbghelp: Pass module to map_dwarf_register.
by Jacek Caban 29 Mar '20

29 Mar '20

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/dbghelp/cpu_arm.c | 2 +- dlls/dbghelp/cpu_arm64.c | 2 +- dlls/dbghelp/cpu_i386.c | 2 +- dlls/dbghelp/cpu_ppc.c | 2 +- dlls/dbghelp/cpu_x86_64.c | 2 +- dlls/dbghelp/dbghelp_private.h | 2 +- dlls/dbghelp/dwarf.c | 84 +++++++++++++++++----------------- 7 files changed, 48 insertions(+), 48 deletions(-)

1 0

[PATCH 2/2] ddraw: Don't fail with DDSCAPS_TEXTURE|DDSCAPS_3DDEVICE when creating managed textures.
by Akihiro Sagawa 29 Mar '20

29 Mar '20

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48844 Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/ddraw/surface.c | 1 + dlls/ddraw/tests/ddraw4.c | 1 - dlls/ddraw/tests/ddraw7.c | 1 - 3 files changed, 1 insertion(+), 2 deletions(-)

1 0

[PATCH 1/2] kernel32/tests: Add more tests for deleting and replacing open files.
by Zebediah Figura 28 Mar '20

28 Mar '20

Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> --- dlls/kernel32/tests/file.c | 70 +++++++++++++++++++++++++++++++++++--- 1 file changed, 66 insertions(+), 4 deletions(-) diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c index 90338f52d1c..41d03c14fa2 100644 --- a/dlls/kernel32/tests/file.c +++ b/dlls/kernel32/tests/file.c @@ -1795,7 +1795,8 @@ static void test_DeleteFileA( void ) { BOOL ret; char temp_path[MAX_PATH], temp_file[MAX_PATH]; - HANDLE hfile; + HANDLE hfile, mapping; + char **argv; ret = DeleteFileA(NULL); ok(!ret && (GetLastError() == ERROR_INVALID_PARAMETER || @@ -1842,6 +1843,28 @@ static void test_DeleteFileA( void ) "Expected ERROR_ACCESS_DENIED, got error %d\n", GetLastError()); ret = RemoveDirectoryA("testdir"); ok(ret, "Remove a directory failed, got error %d\n", GetLastError()); + + winetest_get_mainargs(&argv); + + ret = CopyFileA(argv[0], temp_file, FALSE); + ok(ret, "got error %u\n", GetLastError()); + hfile = CreateFileA(temp_file, GENERIC_READ, FILE_SHARE_READ | FILE_SHARE_DELETE, NULL, OPEN_EXISTING, 0, 0); + ok(hfile != INVALID_HANDLE_VALUE, "got error %u\n", GetLastError()); + + mapping = CreateFileMappingA(hfile, NULL, PAGE_READONLY | SEC_IMAGE, 0, 0, NULL); + ok(!!mapping, "got error %u\n", GetLastError()); + + SetLastError(0xdeadbeef); + ret = DeleteFileA(temp_file); + ok(!ret, "expected failure\n"); + ok(GetLastError() == ERROR_ACCESS_DENIED, "got error %u\n", GetLastError()); + + CloseHandle(mapping); + + ret = DeleteFileA(temp_file); + ok(ret, "got error %u\n", GetLastError()); + + CloseHandle(hfile); } static void test_DeleteFileW( void ) @@ -3540,7 +3563,7 @@ static BOOL check_file_time( const FILETIME *ft1, const FILETIME *ft2, UINT tole static void test_ReplaceFileA(void) { char replaced[MAX_PATH], replacement[MAX_PATH], backup[MAX_PATH]; - HANDLE hReplacedFile, hReplacementFile, hBackupFile; + HANDLE hReplacedFile, hReplacementFile, hBackupFile, mapping; static const char replacedData[] = "file-to-replace"; static const char replacementData[] = "new-file"; static const char backupData[] = "backup-file"; @@ -3549,6 +3572,7 @@ static void test_ReplaceFileA(void) char temp_path[MAX_PATH]; DWORD ret; BOOL retok, removeBackup = FALSE; + char **argv; if (!pReplaceFileA) { @@ -3786,6 +3810,43 @@ static void test_ReplaceFileA(void) broken(GetLastError() == ERROR_ACCESS_DENIED), /* win2k */ "DeleteFileA: error (backup) %d\n", GetLastError()); } + + ret = GetTempFileNameA(temp_path, prefix, 0, replaced); + ok(ret, "got error %u\n", GetLastError()); + hReplacedFile = CreateFileA(replaced, 0, 0, NULL, OPEN_EXISTING, 0, 0); + ok(hReplacedFile != INVALID_HANDLE_VALUE, "got error %u\n", GetLastError()); + + ret = GetTempFileNameA(temp_path, prefix, 0, replacement); + ok(ret, "got error %u\n", GetLastError()); + + ret = ReplaceFileA(replaced, replacement, NULL, 0, 0, 0); + ok(ret, "got error %u\n", GetLastError()); + + CloseHandle(hReplacedFile); + ret = DeleteFileA(replaced); + ok(ret, "got error %u\n", GetLastError()); + + winetest_get_mainargs(&argv); + + ret = CopyFileA(argv[0], replaced, FALSE); + ok(ret, "got error %u\n", GetLastError()); + hReplacedFile = CreateFileA(replaced, GENERIC_READ, + FILE_SHARE_READ | FILE_SHARE_DELETE, NULL, OPEN_EXISTING, 0, 0); + ok(hReplacedFile != INVALID_HANDLE_VALUE, "got error %u\n", GetLastError()); + + mapping = CreateFileMappingA(hReplacedFile, NULL, PAGE_READONLY | SEC_IMAGE, 0, 0, NULL); + ok(!!mapping, "got error %u\n", GetLastError()); + + ret = GetTempFileNameA(temp_path, prefix, 0, replacement); + ok(ret, "got error %u\n", GetLastError()); + + ret = ReplaceFileA(replaced, replacement, NULL, 0, 0, 0); + todo_wine ok(ret, "got error %u\n", GetLastError()); + + CloseHandle(mapping); + CloseHandle(hReplacedFile); + ret = DeleteFileA(replaced); + todo_wine ok(ret, "got error %u\n", GetLastError()); } /* @@ -3847,9 +3908,10 @@ static void test_ReplaceFileW(void) ok(ret || GetLastError() == ERROR_ACCESS_DENIED, "SetFileAttributesW: error setting to read only %d\n", GetLastError()); + SetLastError(0xdeadbeef); ret = pReplaceFileW(replaced, replacement, backup, 0, 0, 0); - ok(ret != ERROR_UNABLE_TO_REMOVE_REPLACED, - "ReplaceFileW: unexpected error %d\n", GetLastError()); + ok(!ret, "expected failure\n"); + ok(GetLastError() == ERROR_ACCESS_DENIED, "got error %u\n", GetLastError()); ret = SetFileAttributesW(replaced, FILE_ATTRIBUTE_NORMAL); ok(ret || GetLastError() == ERROR_ACCESS_DENIED, "SetFileAttributesW: error setting to normal %d\n", GetLastError()); -- 2.25.1

2 2

Wine staging 5.5 release
by Alistair Leslie-Hughes 28 Mar '20

28 Mar '20

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 5.5 (853 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * wined3d: Multiple games need WINED3D_TEXF_ANISOTROPIC filter mode. * wineqtdecoder: Fix compilation. * d3d11/tests: Add basic dual source blend test. * wined3d: Implement dual source blending. * server: When combining root and name, make sure there is only one slash. Added: * [41275] Winemenubuilder should respect existing defaults for filetype associations. * [48832] winmm: Use _lopen to avoid the 128 character path limit. Updated: * xactengine-initial * ddraw-Rendering_Targets * wined3d-SWVP-shaders * wined3d-Indexed_Vertex_Blending * ntdll-RtlIpv4StringToAddress Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Unstripped wine-gecko trouble
by Francois Gouget 28 Mar '20

28 Mar '20

So when using the unstripped shared Gecko install, I get a lot of test failures. For instance mshtml:activex: https://test.winehq.org/data/ab0a3cb2ff5378f6ab5dd79712547dc43a484100/linux… activex.c:2766: Test failed: Too old IE I replaced the unstripped build with the regular one and that seems to have fixed these failures: https://test.winehq.org/data/123c0543e0bb4c99fbee0a568e786405ff886a93/linux… I installed the shared unstripped Gecko with: mkdir ../gecko cd ../gecko wget https://dl.winehq.org/wine/wine-gecko/2.47.1/wine-gecko-2.47.1-x86-unstripp… tar xfj wine-gecko-2.47.1-x86-unstripped.tar.bz2 Did I do something wrong? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ $live{free} || die "";

2 1