April 2020 - Wine-devel - list.winehq.org

[PATCH 2/3] windowscodecs: Add stub implementation for IWICDdsDecoder.
by Ziqing Hui 27 Apr '20

27 Apr '20

see: https://docs.microsoft.com/en-us/windows/win32/api/wincodec/nn-wincodec-iwi… Signed-off-by: Ziqing Hui <zhui(a)codeweavers.com> --- dlls/windowscodecs/ddsformat.c | 60 +++++++++++++++++++++++++++++++--- include/wincodec.idl | 45 +++++++++++++++++++++++++ 2 files changed, 100 insertions(+), 5 deletions(-)

1 0

[PATCH v2 1/2] rpcrt4: NdrServerCallAll() is 64-bit only.
by Serge Gautherie 26 Apr '20

26 Apr '20

Signed-off-by: Serge Gautherie <winehq-git_serge_180711(a)gautherie.fr> --- Cherry-pick https://git.reactos.org/?p=reactos.git;a=commit;h=a16a37fd2d0506fed4006cb97… --- dlls/rpcrt4/rpcrt4.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/rpcrt4/rpcrt4.spec b/dlls/rpcrt4/rpcrt4.spec index 0492776..c7e792d 100644 --- a/dlls/rpcrt4/rpcrt4.spec +++ b/dlls/rpcrt4/rpcrt4.spec @@ -276,7 +276,7 @@ @ stdcall NdrSendReceive(ptr ptr) @ stdcall NdrServerCall2(ptr) @ stdcall NdrServerCall(ptr) -@ stdcall NdrServerCallAll(ptr) +@ stdcall -arch=win64 NdrServerCallAll(ptr) @ stdcall NdrServerContextMarshall(ptr ptr ptr) @ stdcall NdrServerContextNewMarshall(ptr ptr ptr ptr) # wxp @ stdcall NdrServerContextNewUnmarshall(ptr ptr) # wxp -- 2.10.0.windows.1

2 2

[PATCH v2 2/2] rpcrt4/tests: Add a bare test for NdrServerCallAll().
by Serge Gautherie 26 Apr '20

26 Apr '20

Signed-off-by: Serge Gautherie <winehq-git_serge_180711(a)gautherie.fr> --- dlls/rpcrt4/tests/rpc.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/dlls/rpcrt4/tests/rpc.c b/dlls/rpcrt4/tests/rpc.c index d3a3aee..492f84b 100644 --- a/dlls/rpcrt4/tests/rpc.c +++ b/dlls/rpcrt4/tests/rpc.c @@ -568,6 +568,29 @@ static void test_I_RpcMapWin32Status(void) } } +static void test_NdrServerCallAll(void) +{ + void *pNdrServerCallAll = + (void *)GetProcAddress(GetModuleHandleA("rpcrt4.dll"), + "NdrServerCallAll"); + + if (!pNdrServerCallAll) + { +#ifdef _WIN64 + ok(FALSE, "NdrServerCallAll not exported\n"); +#else + ok(TRUE, ""); +#endif + return; + } + +#ifndef _WIN64 + ok(FALSE, "NdrServerCallAll is exported\n"); +#else + ok(TRUE, ""); +#endif +} + static void test_RpcStringBindingParseA(void) { static unsigned char valid_binding[] = "00000000-0000-0000-c000-000000000046(a)ncacn_np:.[endpoint=\\pipe\\test]"; @@ -1197,6 +1220,7 @@ START_TEST( rpc ) TestDceErrorInqText(); test_towers(); test_I_RpcMapWin32Status(); + test_NdrServerCallAll(); test_RpcStringBindingParseA(); test_RpcExceptionFilter("I_RpcExceptionFilter"); test_RpcExceptionFilter("RpcExceptionFilter"); -- 2.10.0.windows.1

2 2

[PATCH v2] include: Improve _CrtDbgBreak macro.
by Jacek Caban 26 Apr '20

26 Apr '20

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- v2: Fixed a typo spotted by Dmitry. Thanks! include/msvcrt/crtdbg.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

1 0

[PATCH 3/4] include: Improve _CrtDbgBreak macro.
by Jacek Caban 26 Apr '20

26 Apr '20

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- include/msvcrt/crtdbg.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

3 2

[PATCH] http.sys: Avoid touching the IRP structure after queueing it.
by Zebediah Figura 26 Apr '20

26 Apr '20

Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> --- dlls/http.sys/http.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dlls/http.sys/http.c b/dlls/http.sys/http.c index 90bef71399..82af6a5be6 100644 --- a/dlls/http.sys/http.c +++ b/dlls/http.sys/http.c @@ -1233,6 +1233,7 @@ static NTSTATUS http_receive_request(struct request_queue *queue, IRP *irp) } else { + IoMarkIrpPending(irp); InsertTailList(&queue->irp_queue, &irp->Tail.Overlay.ListEntry); ret = STATUS_PENDING; } @@ -1362,8 +1363,6 @@ static NTSTATUS WINAPI dispatch_ioctl(DEVICE_OBJECT *device, IRP *irp) irp->IoStatus.Status = ret; IoCompleteRequest(irp, IO_NO_INCREMENT); } - else - IoMarkIrpPending(irp); return ret; } -- 2.26.2

1 0

[PATCH] rpcrt4: Remove inexistent CreateServerInterfaceFromStub().
by Serge Gautherie 26 Apr '20

26 Apr '20

Signed-off-by: Serge Gautherie <winehq-git_serge_180711(a)gautherie.fr> --- See https://testbot.winehq.org/JobDetails.pl?Key=70632. I confirm it does not exist on XP/Vista x86. It was added on cbd5afd843526450a548be977920b4369c4bb4ba. --- dlls/rpcrt4/rpcrt4.spec | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/rpcrt4/rpcrt4.spec b/dlls/rpcrt4/rpcrt4.spec index 0492776..135beab 100644 --- a/dlls/rpcrt4/rpcrt4.spec +++ b/dlls/rpcrt4/rpcrt4.spec @@ -9,7 +9,6 @@ @ stdcall CStdStubBuffer_Invoke(ptr ptr ptr) @ stdcall CStdStubBuffer_IsIIDSupported(ptr ptr) @ stdcall CStdStubBuffer_QueryInterface(ptr ptr ptr) -@ stub CreateServerInterfaceFromStub # wxp @ stdcall DceErrorInqTextA (long ptr) @ stdcall DceErrorInqTextW (long ptr) @ stdcall -private DllRegisterServer() -- 2.10.0.windows.1

1 0

[PATCH] rpcrt4: Don't use GetExceptionCode outside __except block.
by Jacek Caban 26 Apr '20

26 Apr '20

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/rpcrt4/rpc_epmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

1 0

[PATCH 7/7] riched20: Use __ASM_USE_THISCALL_WRAPPER macro.
by Jacek Caban 26 Apr '20

26 Apr '20

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/riched20/editor.h | 2 +- dlls/riched20/editstr.h | 2 +- dlls/riched20/txthost.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)

1 0

[PATCH 6/7] riched20/tests: Don't use thiscall wrappers on clang MSVC target.
by Jacek Caban 26 Apr '20

26 Apr '20

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/riched20/tests/txtsrv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

1 0