June 2020 - Wine-devel - list.winehq.org

[resend PATCH 1/3] Avoid undefined result in ntdll_wcstoumbs() in case of error.
by Paul Gofman 26 Jun '20

26 Jun '20

Undefined result is due to RtlUnicodeToUTF8N() not setting output length on error which is a correct behaviour according to existing tests. 'Planet Zoo' is affected which passes NULL object name buffer to NtCreateFile(). Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> --- Supersedes 187879 - 187880. dlls/ntdll/locale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ntdll/locale.c b/dlls/ntdll/locale.c index d6bde700e42..4f03e3881f0 100644 --- a/dlls/ntdll/locale.c +++ b/dlls/ntdll/locale.c @@ -769,7 +769,7 @@ DWORD ntdll_umbstowcs( const char *src, DWORD srclen, WCHAR *dst, DWORD dstlen ) */ int ntdll_wcstoumbs( const WCHAR *src, DWORD srclen, char *dst, DWORD dstlen, BOOL strict ) { - DWORD i, reslen; + DWORD i, reslen = 0; if (!unix_table.CodePage) RtlUnicodeToUTF8N( dst, dstlen, &reslen, src, srclen * sizeof(WCHAR) ); -- 2.26.2

2 3

[RFC PATCH 0/5] Add MPEG video parser to MPEG splitter filter.
by Akihiro Sagawa 26 Jun '20

26 Jun '20

This is my work in progress patchset which adds MPEG video parser to MPEG splitter filter. Mainly, fix for bug 9127. Before moving on the farther step, I'd like to request for comments on this implementation (function name, patch order, GStreamer usage, etc.). I'll work on MPEG video decoder filter, next. Because, at this point, we can't build a pipeline for MPEG video files with the MPEG splitter. After finishing up the decoder, I'll submit both of patchset. Supporting system stream (audio+video) will be the subsequent development. Akihiro Sagawa (5): quartz/tests: Factor out MP3 audio tests. winegstreamer: Implement listing of sink media types. winegstreamer: Pass the AM_MEDIA_TYPE parameter to the handler. winegstreamer: Add MPEG video parser to MPEG splitter. quartz/tests: Add MPEG video parser tests for MPEG splitter. dlls/quartz/tests/mpegsplit.c | 894 +++++++++++++++++++++++++--------- dlls/quartz/tests/rsrc.rc | 4 + dlls/quartz/tests/video.mpg | Bin 0 -> 617 bytes dlls/winegstreamer/gstdemux.c | 192 +++++++- 4 files changed, 838 insertions(+), 252 deletions(-) create mode 100644 dlls/quartz/tests/video.mpg -- 2.25.1

3 4

[resend PATCH 1/2] Avoid undefined result in ntdll_wcstoumbs() in case of error.
by Paul Gofman 26 Jun '20

26 Jun '20

Undefined result is due to RtlUnicodeToUTF8N() not setting output length on error which is a correct behaviour according to existing tests. 'Planet Zoo' is affected which passes NULL object name buffer to NtCreateFile(). Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> --- dlls/ntdll/locale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ntdll/locale.c b/dlls/ntdll/locale.c index d6bde700e42..4f03e3881f0 100644 --- a/dlls/ntdll/locale.c +++ b/dlls/ntdll/locale.c @@ -769,7 +769,7 @@ DWORD ntdll_umbstowcs( const char *src, DWORD srclen, WCHAR *dst, DWORD dstlen ) */ int ntdll_wcstoumbs( const WCHAR *src, DWORD srclen, char *dst, DWORD dstlen, BOOL strict ) { - DWORD i, reslen; + DWORD i, reslen = 0; if (!unix_table.CodePage) RtlUnicodeToUTF8N( dst, dstlen, &reslen, src, srclen * sizeof(WCHAR) ); -- 2.26.2

2 2

[PATCH 10/10] msi: Add MsiDatabaseApplyTransformA MSITRANSFORM_ERROR_VIEWTRANSFORM test.
by Piotr Caban 26 Jun '20

26 Jun '20

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msi/tests/db.c | 82 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 82 insertions(+)

2 1

[PATCH 09/10] msi: Support DELETE when MSITRANSFORM_ERROR_VIEWTRANSFORM flag is used.
by Piotr Caban 26 Jun '20

26 Jun '20

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msi/table.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 51 insertions(+), 2 deletions(-)

2 1

[PATCH 08/10] msi: Support DROP when MSITRANSFORM_ERROR_VIEWTRANSFORM flag is used.
by Piotr Caban 26 Jun '20

26 Jun '20

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msi/table.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+)

2 1

[PATCH 07/10] msi: Support INSERT INTO when MSITRANSFORM_ERROR_VIEWTRANSFORM flag is used.
by Piotr Caban 26 Jun '20

26 Jun '20

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msi/table.c | 39 +++++++++++++++++++++++++++++++++++++-- 1 file changed, 37 insertions(+), 2 deletions(-)

2 1

[PATCH 06/10] msi: Support ALTER TABLE when MSITRANSFORM_ERROR_VIEWTRANSFORM flag is used.
by Piotr Caban 26 Jun '20

26 Jun '20

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msi/table.c | 152 ++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 149 insertions(+), 3 deletions(-)

2 1

[PATCH 05/10] msi: Support CREATE when MSITRANSFORM_ERROR_VIEWTRANSFORM flag is used.
by Piotr Caban 26 Jun '20

26 Jun '20

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msi/table.c | 73 +++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 69 insertions(+), 4 deletions(-)

2 1

[PATCH 04/10] msi: Support UPDATE when MSITRANSFORM_ERROR_VIEWTRANSFORM flag is used.
by Piotr Caban 26 Jun '20

26 Jun '20

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msi/table.c | 183 ++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 173 insertions(+), 10 deletions(-)

2 1