November 2021 - Wine-devel - list.winehq.org

[PATCH 9/9] winex11: Use UpdateDisplayDevices driver entry point for registering devices.
by Jacek Caban 25 Nov '21

25 Nov '21

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/winex11.drv/Makefile.in | 2 +- dlls/winex11.drv/display.c | 537 ++------------------------------- dlls/winex11.drv/init.c | 1 + dlls/winex11.drv/x11drv.h | 2 + dlls/winex11.drv/x11drv_main.c | 2 +- 5 files changed, 32 insertions(+), 512 deletions(-)

1 0

[PATCH 8/9] user32: Invalidate cache in update_monitor_cache when modification time matches current time.
by Jacek Caban 25 Nov '21

25 Nov '21

Also preserve the last error. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- This fixes a pre-existing problem with current code that we start to hit in monitor tests with the next patch. My plan is to get rid of update_monitor_cache and entire monitor cache in user32. This will ultimitely solve the problem, but I don't want to make this series longer. dlls/user32/sysparams.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

1 0

[PATCH 7/9] win32u: Implement NtUserEnumDisplayDevices.
by Jacek Caban 25 Nov '21

25 Nov '21

And use it in user32. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/user32/sysparams.c | 335 +---------------------------------- dlls/win32u/dc.c | 6 - dlls/win32u/gdiobj.c | 1 + dlls/win32u/ntgdi_private.h | 1 - dlls/win32u/sysparams.c | 71 ++++++++ dlls/win32u/win32u.spec | 2 +- dlls/win32u/win32u_private.h | 33 +++- dlls/win32u/wrappers.c | 10 +- include/ntuser.h | 2 + 9 files changed, 112 insertions(+), 349 deletions(-)

1 0

[PATCH 6/9] winex11: Use gdi driver types for display device handler.
by Jacek Caban 25 Nov '21

25 Nov '21

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/winex11.drv/desktop.c | 18 ++++++------ dlls/winex11.drv/display.c | 24 ++++++++-------- dlls/winex11.drv/x11drv.h | 55 +++++-------------------------------- dlls/winex11.drv/xinerama.c | 20 +++++++------- dlls/winex11.drv/xrandr.c | 47 +++++++++++++++---------------- 5 files changed, 62 insertions(+), 102 deletions(-)

1 0

[PATCH 3/9] win32u: Implement GPU registration.
by Jacek Caban 25 Nov '21

25 Nov '21

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/win32u/font.c | 10 +- dlls/win32u/sysparams.c | 459 ++++++++++++++++++++++++++++++++++- dlls/win32u/win32u_private.h | 6 + 3 files changed, 467 insertions(+), 8 deletions(-)

1 0

[PATCH 1/9] win32u: Implement NtUserGetDisplayConfigBufferSizes.
by Jacek Caban 25 Nov '21

25 Nov '21

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- This ports device cache from user32. dlls/win32u/Makefile.in | 1 + dlls/win32u/font.c | 4 +- dlls/win32u/gdiobj.c | 1 + dlls/win32u/sysparams.c | 466 +++++++++++++++++++++++++++++++++++ dlls/win32u/win32u.spec | 2 +- dlls/win32u/win32u_private.h | 4 + dlls/win32u/wrappers.c | 6 + include/ntuser.h | 2 + 8 files changed, 483 insertions(+), 3 deletions(-) create mode 100644 dlls/win32u/sysparams.c

1 0

[PATCH] server: Allow using \Device\NamedPipe file as RootDirectory for creating named pipes.
by Jinoh Kang 24 Nov '21

24 Nov '21

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> --- dlls/ntdll/tests/om.c | 30 ++++++++++++++++++++++++++++++ server/named_pipe.c | 9 ++++++++- 2 files changed, 38 insertions(+), 1 deletion(-) diff --git a/dlls/ntdll/tests/om.c b/dlls/ntdll/tests/om.c index 77eb58a23b5..1b6d9d2d2d1 100644 --- a/dlls/ntdll/tests/om.c +++ b/dlls/ntdll/tests/om.c @@ -197,6 +197,35 @@ static void test_namespace_pipe(void) pNtClose(pipe); } +static void test_pipe_device_file_as_root(void) +{ + OBJECT_ATTRIBUTES attr; + UNICODE_STRING str; + IO_STATUS_BLOCK iosb; + NTSTATUS status; + LARGE_INTEGER timeout; + HANDLE pipe, root, h; + + pRtlInitUnicodeString(&str, L"\\Device\\NamedPipe"); + InitializeObjectAttributes(&attr, &str, 0, 0, NULL); + status = pNtOpenFile(&root, GENERIC_READ, &attr, &iosb, FILE_SHARE_READ|FILE_SHARE_WRITE, 0); + ok(status == STATUS_SUCCESS, "NtOpenFile should have succeeded got %08x\n", status); + + pRtlInitUnicodeString(&str, L"test2\\pipe"); + InitializeObjectAttributes(&attr, &str, 0, root, NULL); + status = pNtCreateNamedPipeFile(&pipe, GENERIC_READ|GENERIC_WRITE, &attr, &iosb, FILE_SHARE_READ|FILE_SHARE_WRITE, + FILE_CREATE, FILE_PIPE_FULL_DUPLEX, FALSE, FALSE, FALSE, 1, 256, 256, &timeout); + ok(status == STATUS_SUCCESS, "Failed to create NamedPipe(%08x)\n", status); + + h = CreateFileA("\\\\.\\pipe\\test2\\pipe", GENERIC_READ, FILE_SHARE_READ|FILE_SHARE_WRITE, NULL, + OPEN_EXISTING, 0, 0 ); + ok(h != INVALID_HANDLE_VALUE, "Failed to open NamedPipe (%u)\n", GetLastError()); + + pNtClose(h); + pNtClose(pipe); + pNtClose(root); +} + #define check_create_open_dir(parent, name, status) check_create_open_dir_(__LINE__, parent, name, status) static void check_create_open_dir_( int line, HANDLE parent, const WCHAR *name, NTSTATUS expect ) { @@ -2434,6 +2463,7 @@ START_TEST(om) test_case_sensitive(); test_namespace_pipe(); + test_pipe_device_file_as_root(); test_name_collisions(); test_name_limits(); test_directory(); diff --git a/server/named_pipe.c b/server/named_pipe.c index 1bbf7f17a3a..22971c4752f 100644 --- a/server/named_pipe.c +++ b/server/named_pipe.c @@ -1278,13 +1278,20 @@ static struct pipe_end *create_pipe_client( struct named_pipe *pipe, data_size_t static int named_pipe_link_name( struct object *obj, struct object_name *name, struct object *parent ) { - struct named_pipe_device *dev = (struct named_pipe_device *)parent; + struct named_pipe_device *dev; + + if (parent->ops == &named_pipe_device_file_ops) + { + parent = &((struct named_pipe_device_file *)parent)->device->obj; + } if (parent->ops != &named_pipe_device_ops) { set_error( STATUS_OBJECT_NAME_INVALID ); return 0; } + + dev = (struct named_pipe_device *)parent; namespace_add( dev->pipes, name ); name->parent = grab_object( parent ); return 1; -- 2.31.1

2 1

[PATCH] dmloader: Drop ifdef'ed out dead code
by Michael Stefaniuc 24 Nov '21

24 Nov '21

Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/dmloader/loader.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/dlls/dmloader/loader.c b/dlls/dmloader/loader.c index b90584b09a0..00170f42937 100644 --- a/dlls/dmloader/loader.c +++ b/dlls/dmloader/loader.c @@ -538,13 +538,6 @@ static HRESULT WINAPI IDirectMusicLoaderImpl_SetObject(IDirectMusicLoader8 *ifac return DMUS_E_LOADER_FAILEDOPEN; } - /* *sigh*... some ms objects have lousy implementation of ParseDescriptor that clears input descriptor :( */ -#ifdef NOW_WE_ARE_FREE - /* parse descriptor: we actually use input descriptor; fields that aren't available from stream remain, - otherwise real info is set */ - IDirectMusicObject_ParseDescriptor (pObject, pStream, pDesc); -#endif - /* hmph... due to some trouble I had with certain tests, we store current position and then set it back */ DM_STRUCT_INIT(&Desc); if (FAILED(IDirectMusicObject_ParseDescriptor (pObject, pStream, &Desc))) { IStream_Release(pStream); -- 2.31.1

1 0

RE: TestBot job 102673 results: [PATCH 1/2] msxml3/tests: Add test saving XML with non-english characters.
by Daniel Lehman 24 Nov '21

24 Nov '21

> === debiant2 (64 bit WoW report) === > > msxml3: > Unhandled exception: page fault on read access to 0x00000000ffffffff in 64-bit code (0x0000000001488308). existing crash: https://test.winehq.org/data/28c35689d2d9193cbf7ce5f523fecbaf377ae273/linux… https://test.winehq.org/data/28c35689d2d9193cbf7ce5f523fecbaf377ae273/linux… https://test.winehq.org/data/28c35689d2d9193cbf7ce5f523fecbaf377ae273/linux…

1 0

[PATCH] mscms: Fix uninitialized variable warning.
by Daniel Lehman 24 Nov '21

24 Nov '21

1 0