March 2021 - Wine-devel - list.winehq.org

[PATCH] wldap32: Remove redundant NULL check before heap_free()
by Michael Stefaniuc 14 Mar '21

14 Mar '21

Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/wldap32/page.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/dlls/wldap32/page.c b/dlls/wldap32/page.c index a16ea52409e..07f29be0d50 100644 --- a/dlls/wldap32/page.c +++ b/dlls/wldap32/page.c @@ -241,11 +241,8 @@ ULONG CDECL ldap_get_paged_count( WLDAP32_LDAP *ld, PLDAPSearch search, return WLDAP32_LDAP_SUCCESS; } - if (search->cookie) - { - heap_free( search->cookie ); - search->cookie = NULL; - } + heap_free( search->cookie ); + search->cookie = NULL; ret = ldap_parse_page_controlW( ld, server_ctrls, count, &search->cookie ); if (ret == WLDAP32_LDAP_SUCCESS) -- 2.26.2

1 0

Wine staging 6.4 release
by Alistair Leslie-Hughes 14 Mar '21

14 Mar '21

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 6.4 (686 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * kernel32: Implement K32GetMappedFileName. * wow64cpu: Add stub dll. * ntdll: Add a stub implementation of Wow64Transition. * aclui: Add basic ACE viewer. * ntdll: Implement RtlQueryRegistryValuesEx * setupapi/tests: Add more tests for SPFILENOTIFY_FILEINCABINET handler. * setupapi: Fix CabinetName passed to SPFILENOTIFY_CABINETINFO handler. * setupapi/tests: Add tests for cabinet name passed to SPFILENOTIFY_FILEEXTRACTED. * setupapi: Fix parameters of SPFILENOTIFY_FILEINCABINET handler. * ddraw: Create rendering targets in video memory if possible. Added: * [50624] Waves Central 12.0.5 fails to start. Updated: * ntdll-NtAlertThreadByThreadId * ntdll-Junction_Points Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Re: [PATCH] ntdll: Implement RtlGetCallersAddress function.
by Vijay Kiran Kamuju 14 Mar '21

14 Mar '21

Sorry its RtlCaptureStackBackTrace instead of RtlCaptureBackTrace On Sun, Mar 14, 2021 at 7:13 PM Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote: > From the openrce found that it calls the RtlCaptureBackTrace, found > explanation on www.codewarrior.cn website regarding the function. Checked > the MSDN documentation for RtlCaptureBackTrace > > Lastly inspired by the reactos implementation. > > I tried to put it in exception.c, where in it could not find the RtlCaptureBackTrace, > will check in the headers. > > Thanks, > Vijay > > > On Sun, 14 Mar 2021, 19:00 Nikolay Sivov, <nsivov(a)codeweavers.com> wrote: > >> Where does this implementation come from? You probably don't have to >> duplicate exactly the same function in every arch file. >> >>

1 0

[PATCH v2] ntdll: Implement RtlGetCallersAddress function.
by Vijay Kiran Kamuju 14 Mar '21

14 Mar '21

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50726 Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com>

1 0

[PATCH] ntdll: Implement RtlGetCallersAddress function.
by Vijay Kiran Kamuju 14 Mar '21

14 Mar '21

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50726 Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com>

2 1

[PATCH] po: Update on Spanish translation
by Roberto Pungartnik 14 Mar '21

14 Mar '21

1 0

[PATCH] po: Update on Brazilian Portuguese translation
by Roberto Pungartnik 14 Mar '21

14 Mar '21

1 0

[PATCH] ntdll: Map top-down if DllCharacteristics include DYNAMIC_BASE.
by Myah Caron 13 Mar '21

13 Mar '21

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=44893 Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=48641 Signed-off-by: Myah Caron <qsniyg(a)protonmail.com> --- A test is available here: https://github.com/qsniyg/wine_dll_load_test/tree/b2b64bc8d7d1589cbfeb1dbb5… (D1 should load with a high 0x7fff... address) If --dynamicbase is added to the linker options, it will map the DLL top-down rather than bottom-up (tested under Windows 10). This patch fixes the SKSE issue, as it requires its base address to be > 0x180000000. While the linked issue may be "invalid" due to it an application bug, it does nonetheless demonstrate a bug in wine, so I believe it's worth fixing this issue. dlls/ntdll/loader.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c index a7e6d712df1..5f4b78e133c 100644 --- a/dlls/ntdll/loader.c +++ b/dlls/ntdll/loader.c @@ -2279,8 +2279,9 @@ static NTSTATUS load_native_dll( LPCWSTR load_path, const UNICODE_STRING *nt_nam { void *module = NULL; SIZE_T len = 0; + ULONG alloc_type = (image_info->DllCharacteristics & IMAGE_DLLCHARACTERISTICS_DYNAMIC_BASE) ? MEM_TOP_DOWN : 0; NTSTATUS status = NtMapViewOfSection( mapping, NtCurrentProcess(), &module, 0, 0, NULL, &len, - ViewShare, 0, PAGE_EXECUTE_READ ); + ViewShare, alloc_type, PAGE_EXECUTE_READ ); if (status == STATUS_IMAGE_NOT_AT_BASE) status = STATUS_SUCCESS; #ifdef _WIN64 -- 2.30.2

2 2

[PATCH 1/2] winepulse.drv: Make timer thread time-critical.
by Torge Matthies 12 Mar '21

12 Mar '21

Signed-off-by: Torge Matthies <openglfreak(a)googlemail.com> --- These two patches help applications that need very low audio latency. They make sense individually, but are related so I'm sending them as one set. This first patch does nothing on vanilla Wine, but helps on Wine Staging and other patched Wine versions. dlls/winepulse.drv/mmdevdrv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dlls/winepulse.drv/mmdevdrv.c b/dlls/winepulse.drv/mmdevdrv.c index 417067f0bf8..4609b2851ed 100644 --- a/dlls/winepulse.drv/mmdevdrv.c +++ b/dlls/winepulse.drv/mmdevdrv.c @@ -2045,8 +2045,10 @@ static HRESULT WINAPI AudioClient_Start(IAudioClient3 *iface) This->started = TRUE; This->just_started = TRUE; - if(!This->timer) + if(!This->timer) { This->timer = CreateThread(NULL, 0, pulse_timer_cb, This, 0, NULL); + SetThreadPriority(This->timer, THREAD_PRIORITY_TIME_CRITICAL); + } } pthread_mutex_unlock(&pulse_lock); return hr; -- 2.30.1

2 3

[PATCH 2/2] jscript: Improve interp_local debug traces.
by Jacek Caban 12 Mar '21

12 Mar '21

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/jscript/engine.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)

1 0