December 2022 - Wine-devel - list.winehq.org

Regarding Coverity
by Fabian Maurer 12 Dec '22

12 Dec '22

Hello, I'm sometimes working through the issues Coverity scan reported, and I come across a lot of issues that I consider false positives. I however am not 100% comfortable marking them as such, just in case I am wrong... What's the policy on that? Are those getting reviewed by other devs? Should I just mark them as false positives if I think they are? Regards, Fabian Maurer

2 1

Code freeze plans
by Alexandre Julliard 12 Dec '22

12 Dec '22

Folks, As you know, we are now in code freeze towards 8.0. This means that only reasonably small, targeted bug fixes can be accepted. As far as possible, please mention the bug number that the fix is for. We currently have 242 open regressions (cf. https://source.winehq.org/regressions) I'm hoping that we can release 8.0 with fewer open regressions than 7.0, which means we have to bring that number down to 150. All help is welcome! Fixes to the tests can always be accepted since they can't break apps, so this is also a good opportunity to fix some long-standing failures. The rc releases will be a bit more spread out than usual, because I'll be out during the Christmas break. My plan is to have rc2 on December 21, rc3 on January 6, and then resume weekly rc releases, with a final 8.0 towards the end of January. -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine staging 8.0-rc1 release
by Alistair Leslie-Hughes 12 Dec '22

12 Dec '22

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 8.0-rc1 (473 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * winegstreamer: Implement MF_SD_LANGUAGE. Added: * None Updated: * none Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

3 3

Wine Source build on native wchar_t 4 bytes
by Mahin Pandya 05 Dec '22

05 Dec '22

Hello All, We are trying to build Wine Source on Linux with native wchar_t size 4 bytes (instead of 2 bytes), is there any way it can be done? I started with doing following changes: diff --git a/tools/winapi/winapi_test b/tools/winapi/winapi_test index b9628e8..91daac3 100644 --- a/tools/winapi/winapi_test +++ b/tools/winapi/winapi_test @@ -206,7 +206,11 @@ sub _find_align_kind_size($) { $align = 2; $kind = "signed"; $size = 2; - } elsif (/^(?:char16_t|wchar_t|USHORT|WCHAR|WORD)$/) { + } elsif (/^(?:wchar_t|WCHAR)$/) { + $align = 4; + $kind = "unsigned"; + $size = 4; + } elsif (/^(?:char16_t|USHORT|WORD|WCHAR_nt)$/) { $align = 2; $kind = "unsigned"; $size = 2; Also started changing some of headers e.g. winnt.h - removed "typedef unsigned short WCHAR;" Any pointers/suggestion are welcome. Thanking you. regards, Mahin

6 11

Re: [PATCH 1/1] mstask: Don't assume a ONCE trigger is on the current day.
by Dmitry Timoshkov 02 Dec '22

02 Dec '22

Sven Baars <wine(a)gitlab.winehq.org> wrote: > - if (CompareFileTime(&begin_ft, &trigger_ft) <= 0 && CompareFileTime(&trigger_ft, &end_ft) < 0) > + if (CompareFileTime(&trigger_ft, &current_ft) >= 0) > { > if (!have_best_time || CompareFileTime(&trigger_ft, &best_ft) < 0) > { Removing the trigger end time check doesn't look right. -- Dmitry.

1 0

Using comdlg32 functions in shell32
by Alex Henrie 02 Dec '22

02 Dec '22

Hello, Does anyone know why shell32 uses LoadLibrary and GetProcAddress to get pointers to GetOpenFileName[AW] in comdlg32, rather than simply importing the library? https://gitlab.winehq.org/wine/wine/-/blob/wine-7.22/dlls/shell32/shellord.… https://gitlab.winehq.org/wine/wine/-/blob/wine-7.22/dlls/shell32/dialogs.c… I was about to rip this code out, but I want to make sure that it exists only by historical accident and no longer has a purpose. -Alex

2 1