February 2022 - Wine-devel - list.winehq.org

[PATCH] ntdll: Map ETXTBSY to STATUS_SHARING_VIOLATION.
by Jinoh Kang 08 Feb '22

08 Feb '22

This complements commit c75edd04c2c (server: Map ETXTBSY to STATUS_SHARING_VIOLATION., 2007-09-11). Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> --- dlls/ntdll/unix/file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/ntdll/unix/file.c b/dlls/ntdll/unix/file.c index a29b5cbb980..dbd9063e025 100644 --- a/dlls/ntdll/unix/file.c +++ b/dlls/ntdll/unix/file.c @@ -318,6 +318,7 @@ NTSTATUS errno_to_status( int err ) TRACE( "errno = %d\n", err ); switch (err) { + case ETXTBSY: case EAGAIN: return STATUS_SHARING_VIOLATION; case EBADF: return STATUS_INVALID_HANDLE; case EBUSY: return STATUS_DEVICE_BUSY; -- 2.34.1

1 0

[PATCH 1/5] user32/tests: Add more tests for windows destroyed by thread exit.
by Jacek Caban 08 Feb '22

08 Feb '22

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/user32/tests/msg.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)

3 6

[PATCH 8/8] server: Don't allow creating children of orphaned windows.
by Jacek Caban 08 Feb '22

08 Feb '22

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/user32/tests/win.c | 33 +++++++++++++++++++++++++++++++-- server/window.c | 10 +++++++++- 2 files changed, 40 insertions(+), 3 deletions(-)

1 0

[PATCH 7/8] server: Orphan child windows when unlinking them from parent.
by Jacek Caban 08 Feb '22

08 Feb '22

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/user32/tests/win.c | 34 ++++++++++++++++++++++++++++++++++ server/window.c | 5 ++++- 2 files changed, 38 insertions(+), 1 deletion(-)

1 0

[PATCH 6/8] server: Don't allow orphaned windows in set_parent request.
by Jacek Caban 08 Feb '22

08 Feb '22

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/user32/tests/win.c | 3 --- dlls/user32/win.c | 2 +- server/window.c | 10 +++++++++- 3 files changed, 10 insertions(+), 5 deletions(-)

1 0

[PATCH 5/8] user32/tests: Add a test for child window destruction on thread exit.
by Jacek Caban 08 Feb '22

08 Feb '22

From: Rémi Bernon <rbernon(a)codeweavers.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/user32/tests/win.c | 235 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 235 insertions(+)

1 0

[PATCH 4/8] server: Don't immediately destroy child windows belonging to different thread in free_window_handle.
by Jacek Caban 08 Feb '22

08 Feb '22

Notify their thread instead. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/user32/user_private.h | 18 ------------------ dlls/user32/win.c | 12 +----------- include/ntuser.h | 19 +++++++++++++++++++ server/window.c | 14 +++++++++----- 4 files changed, 29 insertions(+), 34 deletions(-)

1 0

[PATCH 3/8] server: Keep a reference to parent in window objects.
by Jacek Caban 08 Feb '22

08 Feb '22

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- server/window.c | 29 ++++++++++++++++++++++------- 1 file changed, 22 insertions(+), 7 deletions(-)

1 0

[PATCH 2/8] server: Make window struct a server object.
by Jacek Caban 08 Feb '22

08 Feb '22

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- Tests show that orphaned windows' parents handles are no longer valid, but a number of operations of children still need to work, even things like MoveWindow(). For that to work, we still need to have parent object around. Following patches will use that for ref-counting, while having full server object is nice for things like leak detection. We could avoid making window object ref-counted by detecting if we're the last child alive when freeing its handle (and then destroying parent), but that doesn't seem cleaner. server/user.h | 2 +- server/window.c | 106 +++++++++++++++++++++++++++++++++----------- server/winstation.c | 4 +- 3 files changed, 83 insertions(+), 29 deletions(-)

1 0

[PATCH 1/3] winhttp/tests: Remove unused include.
by Hans Leidekker 08 Feb '22

08 Feb '22

Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> --- dlls/winhttp/tests/winhttp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/winhttp/tests/winhttp.c b/dlls/winhttp/tests/winhttp.c index 053f8315fec..21af2761323 100644 --- a/dlls/winhttp/tests/winhttp.c +++ b/dlls/winhttp/tests/winhttp.c @@ -32,7 +32,6 @@ #include <httprequestid.h> #include "wine/test.h" -#include "wine/heap.h" DEFINE_GUID(GUID_NULL,0,0,0,0,0,0,0,0,0,0,0); -- 2.30.2

2 1