August 2022 - Wine-devel - list.winehq.org

Re: [PATCH v2 1/2] mshtml: Semi-implement non-string primitive data for postMessage.
by Marvin 09 Aug '22

09 Aug '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120782 Your paranoid android. === w10pro64 (64 bit report) === mshtml: htmldoc.c:350: Test failed: expected Exec_SETTITLE htmldoc.c:2859: Test failed: unexpected call Exec_SETTITLE

1 0

WinRt activable class registration
by Kacper rączy 09 Aug '22

09 Aug '22

Hi everyone, First of all, I’m not really familiar with Windows dev environment and tools outside of wine. I’m building custom implementation of some Windows Runtime modules (separate project outside of wine-tree). Similarly to windows.gaming.input in wine, I’ve created classes.idl with `#pragma makedep register`, and using widl to compile it into classes_r.res script file. Then I’m using windres to convert to coff and link it against my dll. Then the runtime classes implemented by dll have to registered. So far I was adding registry entries with DllPath manually in regedit (in HKLM.Software.Microsoft.WindowsRuntime.ActivatableClassId.[CLASS_NAME]) for testing purposes, because I don’t really know how utilize registration script that’s already embedded in dll. So my question is, how do I register Dll for activable winrt classes? Is there a tool for that? Thanks, Kacper Rączy

1 0

Re: [PATCH 2/2] ntdll: Fix leak of mach_host_self port.
by Marvin 08 Aug '22

08 Aug '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120698 Your paranoid android. === debian11 (32 bit WoW report) === ntdll: change.c:277: Test failed: should be ready

1 0

Re: [PATCH v2 1/2] mf: Handle timer time behind clock time in present_clock_schedule_timer().
by Marvin 08 Aug '22

08 Aug '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120690 Your paranoid android. === w7u_el (32 bit report) === mf: mf: Timeout

1 0

[PATCH] srvsvc: Add LanmanServer stub service.
by Dmitry Timoshkov 08 Aug '22

08 Aug '22

wine.inf already has an entry for it. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- configure.ac | 1 + dlls/srvsvc/Makefile.in | 5 +++ dlls/srvsvc/srvsvc.c | 87 +++++++++++++++++++++++++++++++++++++++++ dlls/srvsvc/srvsvc.spec | 1 + loader/wine.inf.in | 4 +- 5 files changed, 96 insertions(+), 2 deletions(-) create mode 100644 dlls/srvsvc/Makefile.in create mode 100644 dlls/srvsvc/srvsvc.c create mode 100644 dlls/srvsvc/srvsvc.spec diff --git a/configure.ac b/configure.ac index dd4abd39e32..bec0513c46d 100644 --- a/configure.ac +++ b/configure.ac @@ -3035,6 +3035,7 @@ WINE_CONFIG_MAKEFILE(dlls/spoolss/tests) WINE_CONFIG_MAKEFILE(dlls/sppc) WINE_CONFIG_MAKEFILE(dlls/srclient) WINE_CONFIG_MAKEFILE(dlls/srvcli) +WINE_CONFIG_MAKEFILE(dlls/srvsvc) WINE_CONFIG_MAKEFILE(dlls/sspicli) WINE_CONFIG_MAKEFILE(dlls/stdole2.tlb) WINE_CONFIG_MAKEFILE(dlls/stdole32.tlb) diff --git a/dlls/srvsvc/Makefile.in b/dlls/srvsvc/Makefile.in new file mode 100644 index 00000000000..f9c68fd12aa --- /dev/null +++ b/dlls/srvsvc/Makefile.in @@ -0,0 +1,5 @@ +MODULE = srvsvc.dll +IMPORTS = advapi32 + +C_SRCS = \ + srvsvc.c diff --git a/dlls/srvsvc/srvsvc.c b/dlls/srvsvc/srvsvc.c new file mode 100644 index 00000000000..3b2b563bc6c --- /dev/null +++ b/dlls/srvsvc/srvsvc.c @@ -0,0 +1,87 @@ +/* + * LanmanServer Service + * + * Copyright 2022 Dmitry Timoshkov + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include <stdarg.h> + +#include "windef.h" +#include "winbase.h" +#include "winsvc.h" +#include "wine/debug.h" + +WINE_DEFAULT_DEBUG_CHANNEL(lanman); + +static SERVICE_STATUS_HANDLE svc_handle; +static HANDLE done_event; + +static void svc_update_status(DWORD state) +{ + SERVICE_STATUS status; + + status.dwServiceType = SERVICE_WIN32; + status.dwControlsAccepted = SERVICE_ACCEPT_STOP | SERVICE_ACCEPT_SHUTDOWN; + status.dwWin32ExitCode = 0; + status.dwServiceSpecificExitCode = 0; + status.dwCheckPoint = 0; + status.dwWaitHint = 0; + status.dwCurrentState = state; + + SetServiceStatus(svc_handle, &status); +} + +static void WINAPI svc_handler(DWORD control) +{ + TRACE("%#lx\n", control); + + switch (control) + { + case SERVICE_CONTROL_STOP: + case SERVICE_CONTROL_SHUTDOWN: + svc_update_status(SERVICE_STOP_PENDING); + SetEvent(done_event); + break; + + default: + svc_update_status(SERVICE_RUNNING); + break; + } +} + +void WINAPI ServiceMain(DWORD argc, LPWSTR *argv) +{ + TRACE("Starting LanmanServer\n"); + + svc_handle = RegisterServiceCtrlHandlerW(L"LanmanServer", svc_handler); + if (!svc_handle) + { + ERR("RegisterServiceCtrlHandler error %ld\n", GetLastError()); + return; + } + + svc_update_status(SERVICE_START_PENDING); + done_event = CreateEventW(NULL, TRUE, FALSE, NULL); + + svc_update_status(SERVICE_RUNNING); + WaitForSingleObject(done_event, INFINITE); + CloseHandle(done_event); + + svc_update_status(SERVICE_STOPPED); + + TRACE("Exiting LanmanServer\n"); +} diff --git a/dlls/srvsvc/srvsvc.spec b/dlls/srvsvc/srvsvc.spec new file mode 100644 index 00000000000..daa88578f7f --- /dev/null +++ b/dlls/srvsvc/srvsvc.spec @@ -0,0 +1 @@ +@ stdcall -private ServiceMain(long ptr) diff --git a/loader/wine.inf.in b/loader/wine.inf.in index e7b435ed0f0..d686e0b4f2f 100644 --- a/loader/wine.inf.in +++ b/loader/wine.inf.in @@ -2396,12 +2396,12 @@ Description="Lanman Server" DisplayName="Lanman Server" ServiceBinary="%11%\svchost.exe -k netsvcs" ServiceType=32 -StartType=4 +StartType=3 ErrorControl=1 [LanmanServerServiceKeys] HKR,Parameters,"ServiceDll",,"%11%\srvsvc.dll" -;; HKLM,%CurrentVersionNT%\SvcHost,"netsvcs",0x00010008,"lanmanserver" +HKLM,%CurrentVersionNT%\SvcHost,"netsvcs",0x00010008,"lanmanserver" [FontCacheService] AddReg=FontCacheServiceKeys -- 2.37.1

1 0

[PATCH] wevtsvc: Remove duplicate dwControlsAccepted initialization.
by Dmitry Timoshkov 08 Aug '22

08 Aug '22

dwControlsAccepted is initialized a few lines earlier. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/wevtsvc/wevtsvc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/wevtsvc/wevtsvc.c b/dlls/wevtsvc/wevtsvc.c index 2e303045740..78c68bac69b 100644 --- a/dlls/wevtsvc/wevtsvc.c +++ b/dlls/wevtsvc/wevtsvc.c @@ -40,7 +40,6 @@ static void eventlog_update_status(DWORD state) status.dwServiceSpecificExitCode = 0; status.dwCheckPoint = 0; status.dwWaitHint = 0; - status.dwControlsAccepted = 0; status.dwCurrentState = state; SetServiceStatus(svc_handle, &status); -- 2.37.1

1 0

[PATCH] schedsvc: Remove duplicate dwControlsAccepted initialization.
by Dmitry Timoshkov 08 Aug '22

08 Aug '22

dwControlsAccepted is initialized a few lines earlier. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/schedsvc/svc_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/schedsvc/svc_main.c b/dlls/schedsvc/svc_main.c index 7681a220592..2250854e953 100644 --- a/dlls/schedsvc/svc_main.c +++ b/dlls/schedsvc/svc_main.c @@ -281,7 +281,6 @@ static void schedsvc_update_status(DWORD state) status.dwServiceSpecificExitCode = 0; status.dwCheckPoint = 0; status.dwWaitHint = 0; - status.dwControlsAccepted = 0; status.dwCurrentState = state; SetServiceStatus(schedsvc_handle, &status); -- 2.37.1

1 0

Re: [PATCH v8 2/5] winegstreamer: Implement IWMOutputMediaProps_SetMediaType.
by Marvin 08 Aug '22

08 Aug '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120665 Your paranoid android. === debian11 (32 bit report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit Arabic:Morocco report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit German report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit French report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit Hebrew:Israel report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit Hindi:India report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit Japanese:Japan report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit Chinese:China report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit WoW report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (64 bit WoW report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2.

1 0

Wine-Contribution
by Alan 07 Aug '22

07 Aug '22

Hello There i need some help regarding to start applying patches to wine and start contributing the problem is I don't know where to start? I went to the wine website and started reading. I didn't get much useful stuff but There was some good documentation about the codebase and the structure of it , but if I want to start applying patches to wine, where should I start besides the website ? Should I start reading the codebase ? If so, where should I start reading the codebase from ? or should I just go and try to patch the bugs that's on the forks issue section? Thanks For your Time Alan

2 1

Re: [PATCH v4 09/10] mciqtz32: Hide the default video window when switching to another one.
by Marvin 06 Aug '22

06 Aug '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120640 Your paranoid android. === w10pro64_en_AE_u8 (64 bit report) === winmm: mci.c:1291: Test failed: sysinfo quantity open expected 0 after auto-close, got: 1

1 0