- Wine-devel - list.winehq.org

[PATCH] wevtsvc: Remove duplicate dwControlsAccepted initialization.
by Dmitry Timoshkov 08 Aug '22

08 Aug '22

dwControlsAccepted is initialized a few lines earlier. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/wevtsvc/wevtsvc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/wevtsvc/wevtsvc.c b/dlls/wevtsvc/wevtsvc.c index 2e303045740..78c68bac69b 100644 --- a/dlls/wevtsvc/wevtsvc.c +++ b/dlls/wevtsvc/wevtsvc.c @@ -40,7 +40,6 @@ static void eventlog_update_status(DWORD state) status.dwServiceSpecificExitCode = 0; status.dwCheckPoint = 0; status.dwWaitHint = 0; - status.dwControlsAccepted = 0; status.dwCurrentState = state; SetServiceStatus(svc_handle, &status); -- 2.37.1

1 0

[PATCH] schedsvc: Remove duplicate dwControlsAccepted initialization.
by Dmitry Timoshkov 08 Aug '22

08 Aug '22

dwControlsAccepted is initialized a few lines earlier. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/schedsvc/svc_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/schedsvc/svc_main.c b/dlls/schedsvc/svc_main.c index 7681a220592..2250854e953 100644 --- a/dlls/schedsvc/svc_main.c +++ b/dlls/schedsvc/svc_main.c @@ -281,7 +281,6 @@ static void schedsvc_update_status(DWORD state) status.dwServiceSpecificExitCode = 0; status.dwCheckPoint = 0; status.dwWaitHint = 0; - status.dwControlsAccepted = 0; status.dwCurrentState = state; SetServiceStatus(schedsvc_handle, &status); -- 2.37.1

1 0

Re: [PATCH v8 2/5] winegstreamer: Implement IWMOutputMediaProps_SetMediaType.
by Marvin 08 Aug '22

08 Aug '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120665 Your paranoid android. === debian11 (32 bit report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit Arabic:Morocco report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit German report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit French report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit Hebrew:Israel report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit Hindi:India report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit Japanese:Japan report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit Chinese:China report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit WoW report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (64 bit WoW report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2.

1 0

Wine-Contribution
by Alan 07 Aug '22

07 Aug '22

Hello There i need some help regarding to start applying patches to wine and start contributing the problem is I don't know where to start? I went to the wine website and started reading. I didn't get much useful stuff but There was some good documentation about the codebase and the structure of it , but if I want to start applying patches to wine, where should I start besides the website ? Should I start reading the codebase ? If so, where should I start reading the codebase from ? or should I just go and try to patch the bugs that's on the forks issue section? Thanks For your Time Alan

2 1

Re: [PATCH v4 09/10] mciqtz32: Hide the default video window when switching to another one.
by Marvin 06 Aug '22

06 Aug '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120640 Your paranoid android. === w10pro64_en_AE_u8 (64 bit report) === winmm: mci.c:1291: Test failed: sysinfo quantity open expected 0 after auto-close, got: 1

1 0

Wine web-based translation using Weblate
by Óvári 06 Aug '22

06 Aug '22

Hello, Can Wine please be available for translation using a browser (eg Firefox) at Weblate? https://hosted.weblate.org/ Thank you On Tue, 19 Jul 2022: [...] > I would have to reassess to be exact but the requirement that caused > issues with most of the systems I investigated was that wine requires > all patches, even translations, to be clearly accredited to a user by > full real name and email. I remember that being the main issue too. But their attribution FAQ says every change is committed under the translators name: https://docs.weblate.org/fr/latest/faq.html#how-does-weblate-credit-transla… | Every change made in Weblate is committed into VCS under the | translators name. This way every single change has proper authorship, | and you can track it down using the standard VCS tools you use for | code. It sounds like this would fulfil Wine's requirement. Also this should probably be posted on wine-devel since it concerns the whole community and would broaden the pool of people who can move forward on this.

1 0

Re: [PATCH v7 1/5] wmvcore/tests: Add some IWMOutputMediaProps_SetMediaType tests.
by Marvin 05 Aug '22

05 Aug '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120582 Your paranoid android. === debian11 (32 bit report) === wmvcore: wmvcore.c:1345: Test succeeded inside todo block: Stream 0: Got hr 0. wmvcore.c:1324: Test succeeded inside todo block: Stream 1: Got hr 0. wmvcore.c:1332: Test succeeded inside todo block: Stream 1: Got hr 0. wmvcore.c:2631: Test succeeded inside todo block: Output 0: Got hr 0. wmvcore.c:2610: Test succeeded inside todo block: Output 1: Got hr 0. wmvcore.c:2618: Test succeeded inside todo block: Output 1: Got hr 0. === debian11 (32 bit Arabic:Morocco report) === wmvcore: wmvcore.c:1345: Test succeeded inside todo block: Stream 0: Got hr 0. wmvcore.c:1324: Test succeeded inside todo block: Stream 1: Got hr 0. wmvcore.c:1332: Test succeeded inside todo block: Stream 1: Got hr 0. wmvcore.c:2631: Test succeeded inside todo block: Output 0: Got hr 0. wmvcore.c:2610: Test succeeded inside todo block: Output 1: Got hr 0. wmvcore.c:2618: Test succeeded inside todo block: Output 1: Got hr 0. === debian11 (32 bit German report) === wmvcore: wmvcore.c:1345: Test succeeded inside todo block: Stream 0: Got hr 0. wmvcore.c:1324: Test succeeded inside todo block: Stream 1: Got hr 0. wmvcore.c:1332: Test succeeded inside todo block: Stream 1: Got hr 0. wmvcore.c:2631: Test succeeded inside todo block: Output 0: Got hr 0. wmvcore.c:2610: Test succeeded inside todo block: Output 1: Got hr 0. wmvcore.c:2618: Test succeeded inside todo block: Output 1: Got hr 0. === debian11 (32 bit French report) === wmvcore: wmvcore.c:1345: Test succeeded inside todo block: Stream 0: Got hr 0. wmvcore.c:1324: Test succeeded inside todo block: Stream 1: Got hr 0. wmvcore.c:1332: Test succeeded inside todo block: Stream 1: Got hr 0. wmvcore.c:2631: Test succeeded inside todo block: Output 0: Got hr 0. wmvcore.c:2610: Test succeeded inside todo block: Output 1: Got hr 0. wmvcore.c:2618: Test succeeded inside todo block: Output 1: Got hr 0. === debian11 (32 bit Hebrew:Israel report) === wmvcore: wmvcore.c:1345: Test succeeded inside todo block: Stream 0: Got hr 0. wmvcore.c:1324: Test succeeded inside todo block: Stream 1: Got hr 0. wmvcore.c:1332: Test succeeded inside todo block: Stream 1: Got hr 0. wmvcore.c:2631: Test succeeded inside todo block: Output 0: Got hr 0. wmvcore.c:2610: Test succeeded inside todo block: Output 1: Got hr 0. wmvcore.c:2618: Test succeeded inside todo block: Output 1: Got hr 0. === debian11 (32 bit Hindi:India report) === wmvcore: wmvcore.c:1345: Test succeeded inside todo block: Stream 0: Got hr 0. wmvcore.c:1324: Test succeeded inside todo block: Stream 1: Got hr 0. wmvcore.c:1332: Test succeeded inside todo block: Stream 1: Got hr 0. wmvcore.c:2631: Test succeeded inside todo block: Output 0: Got hr 0. wmvcore.c:2610: Test succeeded inside todo block: Output 1: Got hr 0. wmvcore.c:2618: Test succeeded inside todo block: Output 1: Got hr 0. === debian11 (32 bit Japanese:Japan report) === wmvcore: wmvcore.c:1345: Test succeeded inside todo block: Stream 0: Got hr 0. wmvcore.c:1324: Test succeeded inside todo block: Stream 1: Got hr 0. wmvcore.c:1332: Test succeeded inside todo block: Stream 1: Got hr 0. wmvcore.c:2631: Test succeeded inside todo block: Output 0: Got hr 0. wmvcore.c:2610: Test succeeded inside todo block: Output 1: Got hr 0. wmvcore.c:2618: Test succeeded inside todo block: Output 1: Got hr 0. === debian11 (32 bit Chinese:China report) === wmvcore: wmvcore.c:1345: Test succeeded inside todo block: Stream 0: Got hr 0. wmvcore.c:1324: Test succeeded inside todo block: Stream 1: Got hr 0. wmvcore.c:1332: Test succeeded inside todo block: Stream 1: Got hr 0. wmvcore.c:2631: Test succeeded inside todo block: Output 0: Got hr 0. wmvcore.c:2610: Test succeeded inside todo block: Output 1: Got hr 0. wmvcore.c:2618: Test succeeded inside todo block: Output 1: Got hr 0. === debian11 (32 bit WoW report) === wmvcore: wmvcore.c:1345: Test succeeded inside todo block: Stream 0: Got hr 0. wmvcore.c:1324: Test succeeded inside todo block: Stream 1: Got hr 0. wmvcore.c:1332: Test succeeded inside todo block: Stream 1: Got hr 0. wmvcore.c:2631: Test succeeded inside todo block: Output 0: Got hr 0. wmvcore.c:2610: Test succeeded inside todo block: Output 1: Got hr 0. wmvcore.c:2618: Test succeeded inside todo block: Output 1: Got hr 0. === debian11 (64 bit WoW report) === wmvcore: wmvcore.c:1345: Test succeeded inside todo block: Stream 0: Got hr 0. wmvcore.c:1324: Test succeeded inside todo block: Stream 1: Got hr 0. wmvcore.c:1332: Test succeeded inside todo block: Stream 1: Got hr 0. wmvcore.c:2631: Test succeeded inside todo block: Output 0: Got hr 0. wmvcore.c:2610: Test succeeded inside todo block: Output 1: Got hr 0. wmvcore.c:2618: Test succeeded inside todo block: Output 1: Got hr 0.

1 0

Re: [PATCH vkd3d v3 13/17] vkd3d-shader/hlsl: Replace register offsets with index paths in resource loads initialization.
by Francisco Casas 04 Aug '22

04 Aug '22

Ah, I finally see, the hlsl_src_from_node(&deref->offset, other->offset.node); indeed is a noop. I will fix it. On 25-07-22 04:11, Giovanni Mascellani wrote: > Hi, > > Il 22/07/22 20:36, Francisco Casas ha scritto: >>>> diff --git a/libs/vkd3d-shader/hlsl.c b/libs/vkd3d-shader/hlsl.c >>>> index 2d5fe40a..a4d594b7 100644 >>>> --- a/libs/vkd3d-shader/hlsl.c >>>> +++ b/libs/vkd3d-shader/hlsl.c >>>> @@ -862,6 +862,28 @@ static bool type_is_single_reg(const struct >>>> hlsl_type *type) >>>> return type->type == HLSL_CLASS_SCALAR || type->type == >>>> HLSL_CLASS_VECTOR; >>>> } >>>> +static bool deref_copy(struct hlsl_ctx *ctx, struct hlsl_deref >>>> *deref, struct hlsl_deref *other) >>>> +{ >>>> + unsigned int i; >>>> + >>>> + memset(deref, 0, sizeof(*deref)); >>>> + >>>> + if (!other) >>>> + return true; >>>> + >>>> + assert(!other->offset.node); >>>> + >>>> + if (!init_deref(ctx, deref, other->var, other->path_len)) >>>> + return false; >>>> + >>>> + for (i = 0; i < deref->path_len; ++i) >>>> + hlsl_src_from_node(&deref->path[i], other->path[i].node); >>>> + >>>> + hlsl_src_from_node(&deref->offset, other->offset.node); >>> >>> You just asserted that other->offset.node is NULL and *deref was >>> initialized to zero, so that seems to be a noop, doesn't it? >>> >> >> Hmm, sorry, I am not sure I understand. >> Initializing *deref to zero shouldn't affect >> >> assert(!other->offset.node); >> >> The idea of this assertion is to ensure that the "other" deref is in >> the index path format instead of the register offset format. > > My point is that, given that you just asserted that other->offset.node > is NULL, the effect of "hlsl_src_from_node(&deref->offset, > other->offset.node)" would be to set deref->offset.node to NULL, but > that's already ensured by the memset(). Or maybe I am getting confused > on something trivial? > > Giovanni.

1 0

[PATCH vkd3d v3 05/17] vkd3d-shader/hlsl: Introduce add_load_component().
by Francisco Casas 04 Aug '22

04 Aug '22

Signed-off-by: Francisco Casas <fcasas(a)codeweavers.com> Signed-off-by: Giovanni Mascellani <gmascellani(a)codeweavers.com> --- v3: * Using hlsl_get_string_buffer() and hlsl_release_string_buffer(). Signed-off-by: Francisco Casas <fcasas(a)codeweavers.com> --- libs/vkd3d-shader/hlsl.y | 99 +++++++++++++++++++++++++++------------- 1 file changed, 68 insertions(+), 31 deletions(-) diff --git a/libs/vkd3d-shader/hlsl.y b/libs/vkd3d-shader/hlsl.y index bfafd981..3b3d3582 100644 --- a/libs/vkd3d-shader/hlsl.y +++ b/libs/vkd3d-shader/hlsl.y @@ -272,8 +272,8 @@ static bool implicit_compatible_data_types(struct hlsl_type *t1, struct hlsl_typ return false; } -static struct hlsl_ir_load *add_load(struct hlsl_ctx *ctx, struct list *instrs, struct hlsl_ir_node *var_node, - struct hlsl_ir_node *offset, struct hlsl_type *data_type, const struct vkd3d_shader_location loc); +static struct hlsl_ir_load *add_load_component(struct hlsl_ctx *ctx, struct list *instrs, struct hlsl_ir_node *var_node, + unsigned int comp, const struct vkd3d_shader_location *loc); static struct hlsl_ir_node *add_cast(struct hlsl_ctx *ctx, struct list *instrs, struct hlsl_ir_node *node, struct hlsl_type *dst_type, const struct vkd3d_shader_location *loc) @@ -311,8 +311,8 @@ static struct hlsl_ir_node *add_cast(struct hlsl_ctx *ctx, struct list *instrs, for (dst_idx = 0; dst_idx < dst_type->dimx * dst_type->dimy; ++dst_idx) { - struct hlsl_type *src_scalar_type, *dst_scalar_type; - unsigned int src_idx, src_offset, dst_offset; + struct hlsl_type *dst_scalar_type; + unsigned int src_idx, dst_offset; struct hlsl_ir_store *store; struct hlsl_ir_constant *c; @@ -335,13 +335,8 @@ static struct hlsl_ir_node *add_cast(struct hlsl_ctx *ctx, struct list *instrs, } dst_offset = hlsl_compute_component_offset(ctx, dst_type, dst_idx, &dst_scalar_type); - src_offset = hlsl_compute_component_offset(ctx, src_type, src_idx, &src_scalar_type); - - if (!(c = hlsl_new_uint_constant(ctx, src_offset, loc))) - return NULL; - list_add_tail(instrs, &c->node.entry); - if (!(load = add_load(ctx, instrs, node, &c->node, src_scalar_type, *loc))) + if (!(load = add_load_component(ctx, instrs, node, src_idx, loc))) return NULL; if (!(cast = hlsl_new_cast(ctx, &load->node, dst_scalar_type, loc))) @@ -668,6 +663,63 @@ static struct hlsl_ir_load *add_load(struct hlsl_ctx *ctx, struct list *instrs, return load; } +static struct hlsl_ir_load *add_load_component(struct hlsl_ctx *ctx, struct list *instrs, struct hlsl_ir_node *var_node, + unsigned int comp, const struct vkd3d_shader_location *loc) +{ + struct hlsl_type *comp_type; + struct hlsl_ir_node *offset; + struct hlsl_ir_constant *c; + struct hlsl_ir_load *load; + unsigned int comp_offset; + struct hlsl_ir_var *var; + + comp_offset = hlsl_compute_component_offset(ctx, var_node->data_type, comp, &comp_type); + + if (!(c = hlsl_new_uint_constant(ctx, comp_offset, loc))) + return NULL; + list_add_tail(instrs, &c->node.entry); + + offset = &c->node; + + if (var_node->type == HLSL_IR_LOAD) + { + const struct hlsl_deref *src = &hlsl_ir_load(var_node)->src; + struct hlsl_ir_node *add; + + var = src->var; + if (src->offset.node) + { + if (!(add = hlsl_new_binary_expr(ctx, HLSL_OP2_ADD, src->offset.node, &c->node))) + return NULL; + list_add_tail(instrs, &add->entry); + offset = add; + } + } + else + { + struct vkd3d_string_buffer *name; + struct hlsl_ir_store *store; + + if (!(name = hlsl_get_string_buffer(ctx))) + return NULL; + vkd3d_string_buffer_printf(name, "<deref-%p>", var_node); + var = hlsl_new_synthetic_var(ctx, name->buffer, var_node->data_type, var_node->loc); + hlsl_release_string_buffer(ctx, name); + if (!var) + return NULL; + + if (!(store = hlsl_new_simple_store(ctx, var, var_node))) + return NULL; + list_add_tail(instrs, &store->node.entry); + } + + if (!(load = hlsl_new_load(ctx, var, offset, comp_type, *loc))) + return NULL; + list_add_tail(instrs, &load->node.entry); + + return load; +} + static bool add_record_load(struct hlsl_ctx *ctx, struct list *instrs, struct hlsl_ir_node *record, unsigned int idx, const struct vkd3d_shader_location loc) { @@ -1766,22 +1818,17 @@ static void initialize_var_components(struct hlsl_ctx *ctx, struct list *instrs, for (k = 0; k < src_comp_count; ++k) { - struct hlsl_type *dst_comp_type, *src_comp_type; - unsigned int dst_reg_offset, src_reg_offset; + struct hlsl_type *dst_comp_type; + unsigned int dst_reg_offset; struct hlsl_ir_store *store; struct hlsl_ir_constant *c; struct hlsl_ir_load *load; struct hlsl_ir_node *conv; - dst_reg_offset = hlsl_compute_component_offset(ctx, dst->data_type, *store_index, &dst_comp_type); - src_reg_offset = hlsl_compute_component_offset(ctx, src->data_type, k, &src_comp_type); - - if (!(c = hlsl_new_uint_constant(ctx, src_reg_offset, &src->loc))) + if (!(load = add_load_component(ctx, instrs, src, k, &src->loc))) return; - list_add_tail(instrs, &c->node.entry); - if (!(load = add_load(ctx, instrs, src, &c->node, src_comp_type, src->loc))) - return; + dst_reg_offset = hlsl_compute_component_offset(ctx, dst->data_type, *store_index, &dst_comp_type); if (!(conv = add_implicit_conversion(ctx, instrs, &load->node, dst_comp_type, &src->loc))) return; @@ -2218,20 +2265,10 @@ static bool intrinsic_mul(struct hlsl_ctx *ctx, struct hlsl_ir_load *value1, *value2; struct hlsl_ir_node *mul; - offset = hlsl_compute_component_offset(ctx, cast_type1, j * cast_type1->dimx + k, &scalar_type); - if (!(c = hlsl_new_uint_constant(ctx, offset, loc))) - return false; - list_add_tail(params->instrs, &c->node.entry); - - if (!(value1 = add_load(ctx, params->instrs, cast1, &c->node, scalar_type, *loc))) - return false; - - offset = hlsl_compute_component_offset(ctx, cast_type2, k * cast_type2->dimx + i, &scalar_type); - if (!(c = hlsl_new_uint_constant(ctx, offset, loc))) + if (!(value1 = add_load_component(ctx, params->instrs, cast1, j * cast1->data_type->dimx + k, loc))) return false; - list_add_tail(params->instrs, &c->node.entry); - if (!(value2 = add_load(ctx, params->instrs, cast2, &c->node, scalar_type, *loc))) + if (!(value2 = add_load_component(ctx, params->instrs, cast2, k * cast2->data_type->dimx + i, loc))) return false; if (!(mul = add_binary_arithmetic_expr(ctx, params->instrs, HLSL_OP2_MUL, &value1->node, &value2->node, loc))) -- 2.34.1

5 31

Re: [PATCH v8 2/2] win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows.
by Marvin 04 Aug '22

04 Aug '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120511 Your paranoid android. === w10pro64 (32 bit report) === user32: win.c:10984: Test failed: pos = 014a015e

1 0