- Wine-devel - list.winehq.org

Merge requests documentation
by Alexandre Julliard 11 Jul '22

11 Jul '22

Folks, I've now updated the Submitting_Patches and Git_Wine_Tutorial to document the new merge request process. Reviews and improvements are welcome. As you can see in the docs, and as discussed previously, signoffs are no longer required on merge requests. This is replaced by the requirement to explicitly approve your own merge request if it contains commits authored by someone else (if it's all your own work, explicit approval is not necessary). Also note that the real name requirement on commits now extends to Gitlab as well. Please make sure to use your real name in your Gitlab profile so that it matches your commits. If you haven't switched to sending merge requests yet, please try to do so in the near future. Mailing patches to wine-devel is now officially discouraged (except for vkd3d which hasn't been moved over yet). If you encounter things that you can't figure out and that the documentation doesn't address, please report them so that we can improve the docs (or even better, update the Wiki yourself...) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 6/6] imm32: Use default IME window WM_DESTROY to call imm_couninit_thread.
by Marvin 11 Jul '22

11 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118690 Your paranoid android. === w10pro64 (64 bit report) === user32: win.c:4558: Test failed: hwnd 00000000000B0234/00000000000B0234 message 0200 win.c:4563: Test failed: hwnd 00000000000B0234/00000000000B0234 message 0203 win.c:4567: Test failed: message 0202 available === w10pro64_ar (64 bit report) === user32: win.c:4558: Test failed: hwnd 00000000000200D2/00000000000200D2 message 0200 win.c:4563: Test failed: hwnd 00000000000200D2/00000000000200D2 message 0203 win.c:4567: Test failed: message 0202 available

1 0

Re: [PATCH 1/1] user32/tests: Check that a message window brought topmost does not defocus other windows.
by Marvin 11 Jul '22

11 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118684 Your paranoid android. === w7u_adm (32 bit report) === user32: win.c:1237: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0149017A fg 00050124 in hook HCBT_MINMAX === w1064 (32 bit report) === user32: win.c:10890: Test failed: pos = 014a015e === w10pro64_ar (64 bit report) === user32: win.c:4419: Test failed: message 0200 available win.c:4642: Test failed: hwnd 00000000000801FA/00000000000801FA message 0200 win.c:4644: Test failed: wparam 0 win.c:4655: Test failed: hwnd 00000000000801FA/00000000000801FA message 0203 win.c:4659: Test failed: message 0202 available

1 0

Re: [PATCH v2 3/3] mfplat/tests: Merge and reorganize image format tests.
by Marvin 11 Jul '22

11 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118670 Your paranoid android. === w7u_el (32 bit report) === mfplat: 0884:mfplat: unhandled exception c0000005 at 71EC7D1C

1 0

Re: [PATCH v2 1/3] mfplat/tests: Mark some tests as broken on Win 8 and 10 v1507.
by Marvin 11 Jul '22

11 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118668 Your paranoid android. === w7u_el (32 bit report) === mfplat: 0854:mfplat: unhandled exception c0000005 at 722C7D1C

1 0

Re: [PATCH v2 3/3] riched20: Add font fallback support.
by Marvin 11 Jul '22

11 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118666 Your paranoid android. === w10pro64_ar (64 bit report) === riched20: editor.c:5552: Test failed: test paste: strcmp = 99, actual = 'cut' editor.c:5558: Test failed: test paste: strcmp = 1, actual = 'testing' editor.c:5573: Test failed: test paste: strcmp = 1, actual = 'testing'

1 0

Re: [PATCH 2/2] mfplat/tests: Merge and reorganize image format tests.
by Marvin 11 Jul '22

11 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118663 Your paranoid android. === w7u_el (32 bit report) === mfplat: 086c:mfplat: unhandled exception c0000005 at 72497D1C

1 0

Re: [PATCH 3/3] riched20: Add font fallback support.
by Marvin 11 Jul '22

11 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118661 Your paranoid android. === w7u_2qxl (32 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w7u_adm (32 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w7u_el (32 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w8 (32 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w8adm (32 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w864 (32 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w1064v1507 (32 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w1064v1809 (32 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w1064 (32 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w1064_tsign (32 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w10pro64 (32 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w864 (64 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w1064v1507 (64 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w1064v1809 (64 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w1064 (64 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w1064_2qxl (64 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w1064_adm (64 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w1064_tsign (64 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w10pro64 (64 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w10pro64_en_AE_u8 (64 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w10pro64_ar (64 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w10pro64_ja (64 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === w10pro64_zh_CN (64 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === debian11 (32 bit report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === debian11 (32 bit Arabic:Morocco report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === debian11 (32 bit German report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === debian11 (32 bit French report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === debian11 (32 bit Hebrew:Israel report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === debian11 (32 bit Hindi:India report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === debian11 (32 bit Japanese:Japan report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === debian11 (32 bit Chinese:China report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === debian11 (32 bit WoW report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??". === debian11 (64 bit WoW report) === riched20: editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"????". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"???". editor.c:9068: Test failed: Got wrong string L"sh??".

1 0

Re: [PATCH 3/3] win32u: Read and cache adapter modes from the registry.
by Marvin 10 Jul '22

10 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118639 Your paranoid android. === debian11 (build log) === ../wine/dlls/win32u/sysparams.c:576:32: error: ‘mode_countW’ undeclared (first use in this function) ../wine/dlls/win32u/sysparams.c:578:32: error: ‘driver_extraW’ undeclared (first use in this function); did you mean ‘driver_extra’? ../wine/dlls/win32u/sysparams.c:587:18: error: too many arguments to function ‘read_adapter_mode’ Task: The win32 Wine build failed === debian11 (build log) === ../wine/dlls/win32u/sysparams.c:576:32: error: ‘mode_countW’ undeclared (first use in this function) ../wine/dlls/win32u/sysparams.c:578:32: error: ‘driver_extraW’ undeclared (first use in this function); did you mean ‘driver_extra’? ../wine/dlls/win32u/sysparams.c:587:18: error: too many arguments to function ‘read_adapter_mode’ Task: The wow64 Wine build failed

1 0

Re: [PATCH 4/4] ntoskrnl: Enumerate child devices on a separate thread.
by Marvin 10 Jul '22

10 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118636 Your paranoid android. === debian11 (32 bit report) === ntoskrnl.exe: driver_pnp.c:703: Test failed: Got 1 remove events. === debian11 (32 bit Arabic:Morocco report) === ntoskrnl.exe: driver_pnp.c:703: Test failed: Got 1 remove events. === debian11 (32 bit Chinese:China report) === ntoskrnl.exe: driver_pnp.c:703: Test failed: Got 1 remove events.

1 0