- Wine-devel - list.winehq.org

Re: Bug #321: dlls/msvct/vf[w]printf functions (Patch 2)
by Shachar Shemesh 29 Oct '02

29 Oct '02

Jaco Greeff wrote: >On Tue, 29 Oct 2002 21:10:52 +0100, Andreas Mohr ><andi(a)rhlx01.fht-esslingen.de> wrote : > > >>[insert some rant about certain highly non-rewarding functions here...] >> >>Still, you're doing some pretty essential work, so let me just say thanks >>for your (annoying ?) work ! >> >> > >Annoying? Sometimes. Boring? Never. I'm enjoying every minute of it, as long >as I don't get to frustrate myself with idiotic mistakes. (Of which I've had >a couple in the last week, the last one just took the prize :)) > I don't know. My personal best is to spend two weeks chasing a one wrong character bug. What's more, it was introduced after adding ~20 lines of code, and I knew it. Beat that! To my credit I will say that this was assembly (68000), and that the problem manifested itself in such an unrelated area of the program, that I overruled my own judgment and searched the problem in the vicinity of where it happened. As life would have it, the real problem was a missing "#" (which means "use immediate value X", so instead it read "Take value from address X"). > O, well, >maybe I just need some extra sleep. > >Thanks a lot, encouragement is always appreciated. > > > >

1 0

Bug in SYSDEPS_CallOnStack()?
by Juraj Hercek 29 Oct '02

29 Oct '02

Hi, When I was trying to get wine working on sparc solaris, I experienced troubles with exception handling. I always got error (after Ctrl + C): err:seh:EXC_DefaultHandling Exception frame is not in stack limits => unable to dispatch exception. After deeper insight into wine's guts I've figured out that problem lies in SYSDEPS_CallOnStack function (scheduler/sysdeps.c:236), which doesn't switch thread stack on sparcs -> I'll try to implement this soon. I also looked at implementation of this function for __i386__ (since it was just a couple of lines above... :o) ) and I think there is a mistake in implementation for _MSC_VER compiler. Original: ... __asm mov edx, 8[esp]; __asm mov fs:[0x04], esp; <--- __asm push edx; ... I think it should look like this: ... __asm mov edx, 8[esp]; __asm mov esp, fs:[0x04]; <--- __asm push edx; ... Just some questions: Is anyone compiling wine with microsoft compiler? If so, what are the reasons? Next, current snapshot from cvs doesn't compile on solaris, is anyone compiling wine on solaris? Regards, Juraj

4 3

Re: dlls/advapi32/RegFlushKey (Patch 2)
by Jaco Greeff 29 Oct '02

29 Oct '02

On 29 Oct 2002 12:38:10 -0800, Alexandre Julliard <julliard(a)winehq.com> wrote : > I'm afraid this can't possibly work. Registry keys don't have an > associated file descriptor. Bingo. That was my understanding as well, until I looked at the RegCloseKey and was thrown totally off-track: /* RegCloseKey */ ... return RtlNtStatusToDosError( NtClose( hkey ) ); which translates more or less to: /* NtClose */ ... SERVER_START_REQ( close_handle ) { req->handle = Handle; ret = wine_server_call( req ); if (!ret && reply->fd != -1) close( reply->fd ); } SERVER_END_REQ; ... Basically leading to the belief that there is actually an fd. (Ignoring the fact that we need to keep things general) Which, looking at the arch doesn't make much sense... lots of little files would do nobody good. Next time I'll ask before I'm lead to believe what I shouldn't. Greetings, Jaco

1 0

Re: dlls/advapi32/RegFlushKey (Patch 2)
by Alexandre Julliard 29 Oct '02

29 Oct '02

"Jaco Greeff" <jaco(a)puxedo.org> writes: > * dlls/advapi32/registry.c: Jaco Greeff <jaco(a)puxedo.org> > - Implemented the RegFlushKey function I'm afraid this can't possibly work. Registry keys don't have an associated file descriptor. -- Alexandre Julliard julliard(a)winehq.com

1 0

RE: winapi update
by Patrik Stridvall 29 Oct '02

29 Oct '02

I run the swedish version... > You can change the number of the line wrapping. Tools -> > Options -> Mail > Formating -> ... but I'm with you here. > Internet Format -> Plain Text Options. No, I have no such option. I run Microsoft Outlook 2000...

3 2

RE: winapi update
by Rolf Kalbermatter 29 Oct '02

29 Oct '02

From: Patrik Stridvall <ps(a)leissner.se> >> You can change the number of the line wrapping. Tools -> >> Options -> Mail >> Formating -> > >... but I'm with you here. > >> Internet Format -> Plain Text Options. > >No, I have no such option. > >I run Microsoft Outlook 2000... Try "Tools -> Options -> Mail Format. Select "Plain Text" in the "Message Format" and click the "Settings" button. Rolf Kalbermatter CIT Engineering Nederland BV tel: +31 (070) 415 9190 Treubstraat 7H fax: +31 (070) 415 9191 2288 EG Rijswijk http://www.citengineering.com Netherlands mailto:rolf.kalbermatter(a)citeng.com

1 0

Re: Bug #321: dlls/msvct/vf[w]printf functions (Patch 2)
by Jaco Greeff 29 Oct '02

29 Oct '02

On 29 Oct 2002 10:53:32 -0800, Alexandre Julliard <julliard(a)winehq.com> wrote : > Still, this only works for vfprintf, vfwprintf > has to output in Unicode so you cannot convert to ASCII or use the > system printf for that. It would probably be easier to grab a printf > implementation from somewhere and convert it to Unicode. Can I swear on this mailing list? Please, I need to. And one would think I've never used the vfwprintf function before the way I'm making all these wrong assumptions. Damnit, I know the Win32 API. *sigh* Luckily my wife got most of the frustrations at my stupidity... On your suggestion: I've looked at the glibc one. No comments. I'll refrain and look a bit more... I do feel that we are making progress however, albeit slowly ;) Do you think it a good idea just doing the ASCII version now and get it into CVS without the W version. (Ripping out the vfwprintf for now.) I can then proceed to make this ASCII implementation into a full "real-prntf" implementation and subsequently, when we are all happy do the Unicode conversion. Basically I'm suggesting breaking it up into small(er) steps. Comments? Greetings, Jaco

2 1

Wineconsole feature request
by György 'Nog' Jeney 29 Oct '02

29 Oct '02

Would it be possible for someone to add a feature to wineconsole so that when the child process exits the console isnt torn down immediatly? This would be very nice because some dos apps dont work when not run through the console and so it is impossible to see their command line syntax. nog.

2 1

Re: Bug #321: dlls/msvct/vf[w]printf functions (Patch 2)
by Alexandre Julliard 29 Oct '02

29 Oct '02

"Jaco Greeff" <jaco(a)puxedo.org> writes: > I'm not sure if I should send the whole patch or just do increments for the > new stuff. At this point it is everything, including cleanups of the test > case and use of correct WideCharToMultiByte as suggested by Dimitri. In > additions the configure.ac patch for the dlls/msvcrt/tests/Makefile.in is added. > > As always, comments are very welcome to get this thing bedded down finally. - you can't use the libc printf to print unicode chars, the format is not the same - WideCharToMultiByte can output several characters for a single unicode char, you need to take that into account for buffer sizes - you cannot cast a WCHAR* into a CHAR* to convert the format to ASCII - there's no point in using strncat if you don't pass it the real size of the buffer - please don't copy code from MSDN, it is copyrighted by Microsoft. -- Alexandre Julliard julliard(a)winehq.com

3 4

RE: winapi update
by Patrik Stridvall 29 Oct '02

29 Oct '02

> > Why not, instead of complaining to people who doesn't > > (or only partly) listens, write some sort of mail "filter" > > the reformats the mail to one or more mail of a more > > appropriate format. Inline attachments and that sort of things... > > Oh, come on man, this _is_ silly. You are the only one sending > multiple patches per email, for crying out loud! :) Perhaps. Haven't checked. Anyway, I can't inline my patches the because Microsoft Outlook wraps the lines and I sure a lot of other people that use attachments have similar problems. So an attachment inliner might be useful nether the less...

2 1