- Wine-devel - list.winehq.org

Re: wine/ dlls/gdi/Makefile.in dlls/gdi/bidi16.c d ...
by Dimitrie O. Paun 16 Aug '02

16 Aug '02

On August 15, 2002 08:42 pm, Alexandre Julliard wrote: [...] > Log message: > Moved a large number of 16-bit functions to a separate gdi16.c file. This is a great idea that I've been advocating for a loooong time now <g>. I think moving 16 bit code into separate files is cool: -- runtime efficiency: If 16 bit code is not invoked, it's not going to be paged in during execution -- code neatness: developers working on the 32-bit code (which is _the_ code in Wine) will not get distracted by silly 16-to-32-to-16 bit conversions. -- helps correctness: 16-bit code is in general a simple: 16-to-32 bit conversion call the 32-bit equivalent function 32-to-16 bit conversion Which means there is a lot of repetition, template-like coding. Any departure from the usual pattern is a *lot* more easily spotted by the naked eye if it's present in a file that does just that. -- 16-to-32 bit: we can more easily see (and fix) cases where 32 bit code calls 16 bit code. For all these reasons, I think we should have _all_ 16-bit code into separate files. Always. Who knows, maybe we can have makefiles done such a way that we can avoid compiling 16 bit code altogether! :) Even if only as a simple check that no 32 bit code calls down to 16 bit... And again, the _same_ rationale applies to xxxW & xxxA functions, but I'll not pursue this point for now ;). -- Dimi.

1 0

Re: window parent/owner handling
by Dmitry Timoshkov 16 Aug '02

16 Aug '02

"Medland, Bill" <Bill.Medland(a)accpac.com> wrote: > Includes my previous patch for SetWindowLong (for Bug 825) Seems that your investigations are correct, at least test succeeds under win2000. I would suggest to apply tiny patch (attached) to catch some additional problems. -- Dmitry.

1 0

RE: Some observations on window parentage etc.
by Medland, Bill 15 Aug '02

15 Aug '02

> -----Original Message----- > From: Medland, Bill [mailto:Bill.Medland(a)accpac.com] > Sent: Thursday, August 15, 2002 8:59 AM > To: Wine devel (E-mail) > Subject: Some observations on window parentage etc. > > > Here are some observations with regard to Window > parentage/ownership etc. snip > > More to follow. > > Bill > OK guys; who can justify the claim in the server (set_window_owner) that the owner and the window must have the same parent? I think it is untrue, but I don't know what it should be. I believe we need to extend the WIN_SetOwner to return the previous owner. Should we take that out of the structure on the user side or should we modify the server reply to return it? I guess modifying the server reply is the safer option and should have no performance penalty. So here is what I am looking at doing. (I'd prefer comments here rather than after I submit the patch) 1. Modify the set_window_owner reply to return both the new full handle and the previous full handle. (p.s. what is this full handle anyway? Why is it different from the one passed in the request?) 2. Modify the set_window_owner handler to fill in the reply and also remove the parent test (or replace it with anything you guys think makes sense) 3. Modify WIN_SetOwner to return the value 4. Leave GetParent as it is 5. Modify GetWindowLong (GWL_HWNDPARENT to return the parent if a WS_CHILD and the owner otherwise (even if not a WS_POPUP) 6. Modify GetAncestor (GA_ROOTWINDOW) to return the same as recursing on GetParent. 7. Write a test set. Comments? Bill

1 0

RE: Re:can windows be reparented?
by Medland, Bill 15 Aug '02

15 Aug '02

> -----Original Message----- > From: Dmitry Timoshkov [mailto:dmitry(a)baikal.ru] > Sent: Thursday, August 15, 2002 10:00 AM > To: Medland, Bill > Cc: wine-devel(a)winehq.com > Subject: Re: Re:can windows be reparented? > > > "Medland, Bill" <Bill.Medland(a)accpac.com> wrote: > > > (Do you want the test case code?) > > Why not? :-) > > -- > Dmitry. > > > First is without WS_POPUP, second is with

1 0

RE: Re:can windows be reparented?
by Medland, Bill 15 Aug '02

15 Aug '02

> -----Original Message----- > From: Dmitry Timoshkov [mailto:dmitry(a)baikal.ru] > Sent: Thursday, August 15, 2002 9:17 AM > To: Medland, Bill > Cc: wine-devel(a)winehq.com > Subject: Re: Re:can windows be reparented? > > > "Medland, Bill" <Bill.Medland(a)accpac.com> wrote: > > > Honest question : how do you know the parent is changing? > by calling > > GetWindowLong (GWL_HWNDPARENT)? > > Yes, and verifying the result in Spy++. (As discussed in my other email) I guess Spy++ is displaying the result of GetWindowLong > > > I believe that it is the owner that is changing and the > parent (as returned > > by getAncestor (GA_PARENT) willl be unchanged. > > Hmm, I didn't try GetAncestor(), only GetWindowLong() and GetParent(). (Do you want the test case code?) > > -- > Dmitry. > > >

2 1

RE: Re:can windows be reparented?
by Medland, Bill 15 Aug '02

15 Aug '02

> -----Original Message----- > From: Dmitry Timoshkov [mailto:dmitry(a)baikal.ru] > Sent: Tuesday, August 13, 2002 6:33 PM > To: us(a)the-edmeades.demon.co.uk > Cc: wine-devel(a)winehq.com > Subject: Re: Re:can windows be reparented? > snip > Could you please test patch posted by Bill Medland to > wine-patches today? It's > not entirely correct though. My tests show that > SetWindowLong(GWL_HWNDPARENT) > call changes simultaneously both parent and owner for top > level windows and > returns old value (not sure old owner or parent it is). Honest question : how do you know the parent is changing? by calling GetWindowLong (GWL_HWNDPARENT)? I believe that it is the owner that is changing and the parent (as returned by getAncestor (GA_PARENT) willl be unchanged. snip Bill

2 1

Some observations on window parentage etc.
by Medland, Bill 15 Aug '02

15 Aug '02

Here are some observations with regard to Window parentage/ownership etc. Clearlt Microsoft documentation is quite out of date and contradictory on the subject these days so we are going to have to experiment and find out what actually happens. We also are going to have to be careful about terminology and not jumping to conclusions. I mean what ther heck are we supposed to think when Spy++ shows a window as a top-level window (by which I mean just below the desktop in the listview that Spy++ uses), tells us that its parent is its owner (a different top-level window) but that "parent" says it has no children. So. 1. GetParent does not necessarily return the same value as GetWindowLong (GWL_HWNDPARENT). I have seen GetParent returning 0 while GetWindowLong returns the same non zero value as GetWindow (GW_OWNER). 2. GetAncestor (GA_PARENT) seems to be the best way to get the "true parent". 3. WIN_CreateWindowEx is currently slightly wrong. I know MSDN says don't mix WS_POPUP and WS_CHILD but if you do then the result is wrong, I believe. However I am loth to fix it and submit the patch because that really messes everything else up so I guess we need a bigger patch first. (Heck, even under windows 98 you can get the kernel to fall over rather easily this way). 4. I don't like the look of GetAncestor (GA_ROOTOWNER). The MSDN documentation suggests that it should return the result of recursively calling GetParent (or should it be recursively calling GetWindowLong (GWL_HWNDPARENT) whereas GetAncestor (GA_ROOT) should return the result of recursively calling GetAncestor (GA_PARENT) (each stopping just before the desktop, of course). (And of course that is definition, not necessarily mechanism) More to follow. Bill

1 0

RE: what's with WS_OVERLAPPED?
by Medland, Bill 15 Aug '02

15 Aug '02

> -----Original Message----- > From: Ove Kaaven [mailto:ovehk(a)ping.uio.no] > Sent: Wednesday, August 14, 2002 11:08 AM > To: Medland, Bill > Cc: Wine devel (E-mail) > Subject: Re: what's with WS_OVERLAPPED? > > > > On Wed, 14 Aug 2002, Medland, Bill wrote: > > > (Regarding the whole issue of windows reparenting) > > > > MSDN keeps going on about windows with the WS_OVERLAPPED > style. However > > surely (since WS_OVERLAPPED=0) every window has such a > style these days. > > > > Is there something I don't understand? > > WS_OVERLAPPED is in practice considered the absence of the > WS_POPUP and > WS_CHILD flags, I believe. > Thanks Ove; that'll do for a working hypothesis. (I wish Microsoft would be consistant) Just for the record it is clearly more complex than that. I guess since Microsoft wrote it we can trust Spy++ a little. I have seen spy++ declare that a "tooltips" class window (style 0x84800000/00000088) has style WS_OVERLAPPED whereas a "tooltips_class32" class window (style 0x84800003/00000088) doesn't. Bill

1 0

ListView Patch
by Steve Whine 15 Aug '02

15 Aug '02

Hi all, I should maybe have posted this to the patches list, but I would like your comments first. I have fixed a few problems with the ListView control when using icons larger than the sizes returned by the system metrics. This (attached) patch also causes LISTVIEW_Arrange (which was previously a stub) to call the LISTVIEW_AlignTop/Left when appropriate. Please let me know what you think. This is my first time doing any of this, so let me know what I'm doing wrong/right. Cheers Steve

1 0

ListView Issues
by Steve Whine 14 Aug '02

14 Aug '02

Hi, I've just started looking into getting a project of wine running on Linux via Wine, and I'm very impressed so far! However, there are a few (mostly minor) problems with the ListView control: - When using icons bigger than the sizes returned by SystemParametersInfo(SPI_GETICONMETRICS), the text for the items is not displayed correctly at the bottom of the icon. - When running a program created by C++ Builder 5, clicking on an item in the listview causes an access violation in C++ Builder's VCL library code - it is obviously getting passed an unexpected value. - The amount of text displayed is often far less than is displayed in Windows, making the listbox difficult to use. I have been looking into the ListView code and have hacked a fix for the first and third problem, but I am having a little difficulty understanding the code - the LISTVIEW_INFO struct has both an nItemWidth/nItemHeight pair describing the width/height of each item, and an iconSpacing SIZE struct that seems to do the same. What is the difference in these, where should one be used and where should the other be used? Is anyone actively maintaining the listview code, or should I just carry on hacking until I'm happy with it, and post the changes here? I have created a small test program to demonstrate these problems which I can post if anyone is interested. I must say it's very nice to be able to wade into the code to fix these problems myself rather than waiting for someone else (not) to do it! Cheers Steve __________________________________________________ Do You Yahoo!? Everything you'll ever need on one web page from News and Sport to Email and Music Charts http://uk.my.yahoo.com

3 2