- Wine-devel - list.winehq.org

Re: Updown fix
by Guy L. Albertelli 18 Jul '02

18 Jul '02

----- Original Message ----- From: "Dimitrie O. Paun" <dpaun(a)rogers.com> To: "Wine Patches" <wine-patches(a)winehq.com> Sent: Tuesday, July 16, 2002 9:26 PM Subject: Updown fix > Changelog: > Allow the application to subclass a buddy edit > (spotted by Guy L. Albertelli). > > Index: dlls/comctl32/updown.c [snip] Yes this fixes the problem reported. I like it a lot better also. Thanks, Dimi. Guy

1 0

VirtualQuery problem... maybe
by Max 17 Jul '02

17 Jul '02

After 2 weeks debugging between window$ and wine (sigh), I found a different behaviour of VirtualQuery function : The app queries info about some pages in its code (really dunno why....); in PROTECT field of BASIC_MEMORY_INFO, windows returns a 0x20 value (EXECUTE_READ), but wine returns 0x08 (WRITE_COPY), causing app to hang. I guess there's an error somewhere, as the required info belongs to executable code, so at least should be active some EXECUTE flag; btw, my app checks only that the page has not active NO_ACCESS, WRITECOPY and PAGE_GUARD flags, and behaves badly if find one of them. As a check, I only add an *protect = *protect & 0xffff7fff to GetWin32Prot code, taking so off the WRITECOPY flag only, and the app began starting. As I don't know about anything of linux memory protections (sigh), the question is : is there someone with wnough skllls that want to check it ? :-) Regards Max

1 0

CxxFrameHandler problem
by Steven Edwards 17 Jul '02

17 Jul '02

If anyone is working on the CxxFrameHandler I have two applications I have been working on that may help in testing/tracking down the problems. Currently both WinCVS and geoshell suffer from this problem. Both applications are GPL so if you need to look at the source to find out what is going on you can. fixme:msvcrt:__CxxFrameHandler (0x40473df4,0x40585e54,0x40473a80,0x40473a1c):stub? fixme:msvcrt:__CxxFrameHandler (0x40473a20,0x40585e54,0x404736ac,0x40473648):stub? fixme:msvcrt:__CxxFrameHandler (0x4047364c,0x40585e54,0x404732d8,0x40473274):stub? fixme:msvcrt:__CxxFrameHandler (0x40473278,0x40585e54,0x40472f04,0x40472ea0):stub? fixme:msvcrt:__CxxFrameHandler (0x40472ea4,0x40585e54,0x40472b30,0x40472acc):stub? fixme:msvcrt:__CxxFrameHandler (0x40472ad0,0x40585e54,0x4047275c,0x404726f8):stub? fixme:msvcrt:__CxxFrameHandler (0x404726fc,0x40585e54,0x40472388,0x40472324):stub? fixme:msvcrt:__CxxFrameHandler (0x40472328,0x40585e54,0x40471fb4,0x40471f50):stub? fixme:msvcrt:__CxxFrameHandler (0x40471f54,0x40585e54,0x40471be0,0x40471b7c):stub? __________________________________________________ Do You Yahoo!? Yahoo! Autos - Get free new car price quotes http://autos.yahoo.com

7 11

Re: solaris configure strangeness
by Warren_Baird＠cimmetry.com 17 Jul '02

17 Jul '02

> configure: WARNING: net/if.h: present but cannot be compiled > configure: WARNING: net/if.h: check for missing prerequisite headers? > configure: WARNING: net/if.h: proceeding with the preprocessor's result > > [...] > > Can anyone explain what this means? Well, to directly answer your question - no, I'm not sure what it means. But I see the same thing when I compile on sparc, and it doesn't seem to have any obvious impact on things... Warren

1 0

fix for bug #24
by Michael Stefaniuc 17 Jul '02

17 Jul '02

Hello, at least the attached patch fixes the problem described in the summary of bug #24 (in the description there are some other problems described too. That's why i CC wine-devel to let one of the bugzilla guru's decide how to proceed with that bug report). ImageList_Remove when called to remove all images on an empty ImageList returns TRUE. Checked with the ControlSpy on Windows 98SE (MSDN wasn't helpfull in this case). Changelog: - Michael Stefaniuc <mstefani(a)redhat.com> ImageList_Remove returns TRUE when removing all images of an empty ImageList bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

3 4

programs/winetest/wine.xs - alloc_thunk()
by Gregg Mattinson 17 Jul '02

17 Jul '02

In programs/winetest/wine.xs, there is a function alloc_thunk(). Currently, there is only an implementation for i386. I have created an implementation for sparc, but I can't figure out how to test it. Does anyone know how this function gets called, or if it is still used? I tried "wine winetest.exe.so tests/wine.pl" and that calls some of the other functions in wine.xs, but not alloc_thunk(). Any help would be appreciated. Thanks, Gregg Mattinson Co-op Developer Sun Microsystems of Canada

1 0

RE: winapi update
by Patrik Stridvall 17 Jul '02

17 Jul '02

> "Patrik Stridvall" <ps(a)leissner.se> wrote: > > > RCS file: /home/wine/wine/objects/font.c,v > > retrieving revision 1.76 > > diff -u -u -r1.76 font.c > > --- wine/objects/font.c 22 Jun 2002 01:19:29 -0000 1.76 > > +++ wine/objects/font.c 16 Jul 2002 21:45:23 -0000 > > @@ -2262,7 +2262,7 @@ > > resultsW.lpOutString = NULL; > > ret = GetCharacterPlacementW(hdc, lpStringW, uCountW, > nMaxExtent, &resultsW, dwFlags); > > - > > +v > ^^^^ > > A typo? I forgot pressing control when scrolling down in Emacs. Usually I detect this myself. This time obviously not. Thanks.

1 0

Re: autoconf 2.52
by Alexandre Julliard 17 Jul '02

17 Jul '02

Jon Griffiths <jon_p_griffiths(a)yahoo.com> writes: > I have a feeling this isn't the way to do this, but this allows > configure to be regenerated with autoconf 2.52. With this version of > autoconf the PACKAGE_ defines are left commented out in > include/config.h after regenerating and running configure. > > Is there a better way to do this? Upgrade your autoconf? <g> Seriously, the reason we have the generated configure in CVS is so that most people never need to worry about autoconf at all. Conversely, I think it's quite reasonable to ask the few developers that need to change configure to install the latest autoconf, so that we don't have to worry about compatibility. -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: Bug Fix: WM_GETTEXT should return NULL string if LB_GETCURSEL is LB_ERR
by Shachar Shemesh 17 Jul '02

17 Jul '02

+ LPWSTR lpText = (LPWSTR)lParam; + lpText[0] = '\0'; Shouldn't it be + LPWSTR lpText = (LPWSTR)lParam; + lpText[0] = L'\0'; ? Carl Sopchak wrote: >I found this while trying to get Quicken 2000 Deluxe to run under wine. Q2k >was crashing when adding a new security (stock) if nothing was seleted in the >Asset Class ListBox. (It doesn't do this under "real Win NT"...) It turns >out that Q2k seems to keep processing the value returned by WM_GETTEXT >regardless of the number of characters WM_GETTEXT returns. Since wine's >WM_GETTEXT was not returning a NULL string (='\0'), a subsequent strcpy (or >some such) was choking because the string was not null terminated. > >The attached patch sets the return string to '\0' if LB_GETCURSEL returns >LB_ERR. (Although this behaviour is not specified on msdn.microsoft.com, I >figure it can't hurt, since the program calling WM_GETTEXT should be >expecting the buffer to get changed by the call...) I don't know (and have >not checked) to see if other *_GETTEXT message handlers need to do the >same... > >One last point: I'm fairly new at C coding. If there's a better way to do >what this patch does, feel free to improve upon it... <grin> > >Carl > > >------------------------------------------------------------------------ > >Index: controls/combo.c >=================================================================== >RCS file: /home/wine/wine/controls/combo.c,v >retrieving revision 1.85 >diff -u -r1.85 combo.c >--- controls/combo.c 10 Jul 2002 23:11:28 -0000 1.85 >+++ controls/combo.c 15 Jul 2002 17:02:47 -0000 >@@ -1603,6 +1603,15 @@ > return (LRESULT)n; > } > } >+ /* LB_GETCURSEL returned LB_ERR - truncate string, return zero */ >+ if (unicode) >+ { >+ LPWSTR lpText = (LPWSTR)lParam; >+ lpText[0] = '\0'; >+ } else { >+ LPSTR lpText = (LPSTR)lParam; >+ lpText[0] = '\0'; >+ } > return 0; > } > > >

6 14

Re: winapi update
by Dmitry Timoshkov 17 Jul '02

17 Jul '02

"Patrik Stridvall" <ps(a)leissner.se> wrote: > RCS file: /home/wine/wine/objects/font.c,v > retrieving revision 1.76 > diff -u -u -r1.76 font.c > --- wine/objects/font.c 22 Jun 2002 01:19:29 -0000 1.76 > +++ wine/objects/font.c 16 Jul 2002 21:45:23 -0000 > @@ -2262,7 +2262,7 @@ > resultsW.lpOutString = NULL; > ret = GetCharacterPlacementW(hdc, lpStringW, uCountW, nMaxExtent, &resultsW, dwFlags); > - > +v ^^^^ A typo? -- Dmitry.

1 0