- Wine-devel - list.winehq.org

FW: argc/argv issue - More info, hack and questions...
by Ann and Jason Edmeades 01 May '02

01 May '02

Hi, I havent had any replies to the attached issue I was debugging - Can anyone assist, or should I just submit the patch. I know the patch works but I feel it is just masking a compatibility problem between two of the wine internal routines. Jason -----Original Message----- Hello, I am still investigating this argv/argc issue. The sequence of events as far as I can tell: CreateProcessA(NULL, "regsvr32 comdlg32.ocx",....) Process_CREATE calls fork_and_exec( NULL, "regsvr32 comdlg32.ocx", ...) This sees there is no explicitly specified filename so inserts wine and -- into the command line (now "wine -- regsvr32 comdlg32.ocx") Eventually the new process starts with the wine -- regsvr32 comdlg32.ocx as the command line, so it needs to strip off the inserted fields, and in PROCESS_InitWine, main_exe_name is correct (path\regsvr32.exe) but the argc/argv includes these new fields. At the top it states: (Scheduler/process.c, lines 491/492): app_argv++; /* remove argv[0] (wine itself) */ app_argc--; This obviously leaves behine the -- and things go downhill from there onwards. Interestingly wine -- regsvr32 comdlg32.ocx works fine, so there must be command line processing here which doesnt occur during the CreateProcess route. Question: Should fork_and_exec insert the -- into the command line? If it should, should PROCESS_InitWine check for it, ie: app_argv++; /* remove argv[0] (wine itself) */ app_argc--; if (app_argc && strcmp(app_argv[0], "--") == 0) { app_argv++; /* remove argv[1] ('--' inserted by fork_and_exec) */ app_argc--; } However, what implications are of doing this (it works, of course). This feels like hacking around an imcompatibility within wine but I am happy to submit a patch as it definitely resolves a problem for me. Regards, Jason

3 3

Re: patches for DInput and getting memory size when running FreeBSD
by Francois Gouget 01 May '02

01 May '02

On Wed, 1 May 2002, Olivier Houchard wrote: > Hi, > > Here are a few patches. > The first one is to be applied on dlls/dinput/keyboard/main.c. It is ugly but that's the only way I found to get games that use SetEventNotification for keyboard to work. > The second one is to be applied on memory/global.c. It is not the best way to get memory size on FreeBSD I guess, but it is still better than 16*1024*1024 :) Maybe a couple of configure checks would be better? You could check for sys/sysctl.h and sysctlbyname for instance. For Linux we cannot check for anything because it uses normal functions and simply tries to read stuff in /proc. But on FreeBSD, the return of the first sysctlbyname("hw.physmem"...) may be used as a basis of an if, placed inside and #ifdef, and before the Linux one. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Advice is what we ask for when we already know the answer but wish we didn't -- Eric Jong

1 0

Re: patch for cups printers
by Marcus Meissner 01 May '02

01 May '02

> --- winehq/dlls/gdi/printdrv.c Thu Mar 28 17:22:05 2002 > +++ wine/dlls/gdi/printdrv.c Mon Apr 29 15:29:42 2002 > @@ -482,6 +482,8 @@ > > if (!strncmp("LPR:",pszOutput,4)) > sprintf(psCmd,"|lpr -P%s",pszOutput+4); > + if (!strncmp("CUPS:",pszOutput,4)) > + sprintf(psCmd,"|lp -d%s",pszOutput+4); > else > { > HKEY hkey; This is wrong, the else { } is handled in the LPR: case too so you break /etc/printcap based printing. Ciao, Marcus

4 6

wineconsole (Eric?) problem
by Ann and Jason Edmeades 01 May '02

01 May '02

Hi again, Another bug I have spotted can be demonstrated clearly by dir /s /w on wcmd on a small set of directories a couple of times (once my patch for /w is on). The first time it writes to the screen without scrolling and all is ok, the second time as it scrolls, it misses off 'Total files listed' and 'bytes free' two lines near the bottom. Basically the wineconsole is not being updated 100% correctly and skips some lines. Looking closely at the wineconsole code (by dumping out the screen at each event) I have worked out what is going on, but am not 100% sure about the 'proper' way to fix it. The problem is the console routines generally generate a sequence of events (assume an n line screen) v-scroll(x) (Make the xth line of the buffer the top line) update(x+n, x+n) (Write to the new bottom line of the screen) In the failing case I see v-scroll(x) (Make the xth line of the buffer the top line) update(x+n, x+n) (Write to the new bottom line of the screen) update(x+n+2, x+n+3) (Write beyond the bottom line of the screen) Although the data is retrieved correctly, it never gets displayed (An invalidaterect appears to happen) A simple way of avoiding this is to update wineconsole as follows: case CONSOLE_RENDERER_UPDATE_EVENT: Trace(1, " update(%d,%d)", evts[i].u.update.top, evts[i].u.update.bottom); /* test fix - Force updates to occur on visible screen */ if ((data->curcfg.win_pos.Y+data->curcfg.win_height) < evts[i].u.update.bottom) { Trace(1, " Forced vscroll \n"); data->fnScroll(data, evts[i].u.update.bottom - data->curcfg.win_height, FALSE); data->fnPosCursor(data); } else if (data->curcfg.win_pos.Y > evts[i].u.update.top) { Trace(1, " Forced vscroll2 \n"); data->fnScroll(data, evts[i].u.update.top, FALSE); data->fnPosCursor(data); } WINECON_FetchCells(data, evts[i].u.update.top, evts[i].u.update.bottom); The question is, is this correct, or is the server generating incorrect events, is the refresh not occurring properly etc? Thoughts please? Regards, Jason jason @ the-edmeades.demon.co.uk

2 4

clipping message
by Medland, Bill 01 May '02

01 May '02

Did someone want to know about this one? err:clipping:CLIPPING_UpdateGCRegion hVisRgn is zero. Please report this. (Our application printing a Crystal reports report from a DB2 database. I don't know if it's relevant but the data is read and under windows the preview display includes a treeview on the left with a couple of empty labels) If no-one else is interested I'll look into it later. Bill

1 0

Statusbar broken?
by Medland, Bill 01 May '02

01 May '02

I've just noticed that in the past few days all the stuff that normally appears in the statusbar etc at the bottom of our application has disappeared. Is this a known regression that someone is looking into or is it up to me? Bill

1 0

Bugzilla: A Call to Arms
by Andriy Palamarchuk 01 May '02

01 May '02

We already had discussion on wine-devel about importance of polishing Wine, making a set of applications to work very well. Cruicial in this process is prioritizing of the issues, work distribution between developers. The companies already have internal testing and bug fixing process. Of course, each company has their own product-specific work, but most of the problems are general for Wine. I suggest to share this work more actively using Bugzilla. Recently there was some work done in cleaning the issues database and it is in pretty much usable condition. To start using bugzilla more actively I suggest following steps: 1) define subsystem/direction owners. The owners will get their system-specific bugs. They won't necessary fix the bugs themselfs, but will have complete picture about all the issues in their subsystems and coordinate the bug fixing. Developers, please let me know your areas of expertese. I can overview Wine applications. 2) more formally define process of bugs handling and use this process. There is no high qualification needed to filter out bad bug reports, duplicates, request users for more information, attach relay trace to the bug, etc, etc. Result - developers will have to spend less time on discussion trivial bugs with users, will have better bug reports to work on, users will be more involved with more active feedback. Some users are very cooperative and some bug reports are really excellent! I see that Tony Lambregts, Michael Cardenas, others do a great work with the Bugzilla database. I'm also going to contribute some time for this. 3) Prioritize bugs. This is, probably, part of (2). Some bugs, while relatively easy to fix provide very big value for the end user. Often developers do not choose such issues to work on, exactly because these issues do not present challenge to them. BTW, I do not see a field "Priority" in the bugs entries. 4) Ask users to submit there problems in Bugzilla. Submitting Bugzilla report allows us to involve users more actively, persist their bug reports. Bugzilla is a more scalable approach than using mailing list only. Of course we still will discuss bugs on the mailing lists, bug big part of communication will be unloaded. There is a lot to do and discuss. For me the goal is to have this process not worse than in Mozilla project. This is impressive: http://webtools.mozilla.org/miscstats/ http://mothra.mozilla.org/webtools/miscstats/ I also like their bug report form: http://www.mozilla.org/quality/help/bugzilla-helper.html And this is for 1 application only! I'm sure Wine can generate much bigger volume of bug reports ;-) Look forward for your comments. Andriy __________________________________________________ Do You Yahoo!? Yahoo! Health - your guide to health and wellness http://health.yahoo.com

6 8

Ntddk.h wcstol question
by Steven Edwards 01 May '02

01 May '02

On some of the dlls this is a problem. Wine - include/ntddk.h INT __cdecl wcstol(LPCWSTR,LPWSTR*,INT); Mingw - stdlib.h long wcstol (const wchar_t*, wchar_t**, int); ReactOS - msvcrt/stdlib.h long wcstol (const wchar_t* wsNumber, wchar_t** pwsAfterNumber, int nBase); Anyone have a idea about what to do here? Thanks Steven "Every revolution was once a thought in one man's mind" - Ralph Waldo Emerson

1 0

Re: SafeDisc FAQs
by Tels 01 May '02

01 May '02

-----BEGIN PGP SIGNED MESSAGE----- Moin, On 30-Apr-02 Tels carved into stone: > And even if it did, what could non-americans care about that? http://www.theregister.co.uk/content/4/25088.html Ouch! Seems we Europeans are in for much worse things :-( Cheers, Te"I wanna move - to the Mars"ls - -- "Why do you go so slowly? Do you think this is some kind of game?" PGP key available on http://bloodgate.com/tels.asc or via email. perl -MDev::Bollocks -e'print Dev::Bollocks->rand(),"\n"' confidentially deliver eligible mindshares -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: When cryptography is outlawed, bayl bhgynjf jvyy unir cevinpl. iQEVAwUBPM8lO3cLPEOTuEwVAQEPZAf+O4FH8K6alJQRo3HYwWktedcZ7j+co6as RlN1AH3f94c2mVRZ33gzNKZlXnCgpmNYXlxPI69dgiKuxTLs/zwUj13lIPviR79H PLzp/jJde6Rb1TSkoCbLTwx2OXJClFNyb6ElhpxKDMgNKK8m22RFfuFDjoz64q4e kPJrl5lBEPDggo0ppGpn5iN0QswhP1F5XmNv6l+qlq3mnYGk4w7K9xYFxSvEVaiE iAxP89rzuE7pODsNhK0JwMyorxea7dzHrVtqYc9ryWVuva7Ab3yVwMDoIYJhri7L DQqM6Q/NIQsmdcVXRMkxljfaNBoKVhCVn1pZoE5NT5nwoYdvmcVz5Q== =AadL -----END PGP SIGNATURE-----

1 0

Re: wine/win32 editline.c
by Eric Pouech 30 Apr '02

30 Apr '02

Alexandre Julliard a écrit : > Modified files: > win32 : editline.c > > Log message: > Jason Edmeades <us(a)the-edmeades.demon.co.uk> > - Added f8 (history retrieval from partial command) support > - Delete key deletes current character > - Ctrl + end deletes to end of line > - Ctrl + right stopped before the word itself <patch excerpt> static KeyEntry EmacsKeyMapCtrl[] = { { CTRL('@'), WCEL_SetMark }, @@ -617,6 +664,7 @@ {/*VK_END*/ 0x23, WCEL_MoveToEnd }, {/*VK_UP*/ 0x26, WCEL_MoveToPrevHist }, {/*VK_DOWN*/ 0x28, WCEL_MoveToNextHist }, + {/*VK_DEL*/ 0x2e, WCEL_FindPrevInHist /*L_DeleteCurrChar*/ }, { 0, NULL } }; </patch excerpt> there's a typo in the patch. the VK_DEL entry should point to WCEL_DeleteCurrChar and not to WCEL_FindPrevInHist A+

1 0