- Wine-devel - list.winehq.org

RE: more bracket evilness
by Medland, Bill 01 Feb '02

01 Feb '02

> -----Original Message----- > From: Andreas Mohr [mailto:andi(a)rhlx01.fht-esslingen.de] > Sent: Friday, February 01, 2002 9:54 AM > To: Wine Patches > Subject: more bracket evilness > > > Hi all, > > you knew that I had to do this ;-) > > - fix more evil bracket stuff in some other files > > (I know, it's not really problematic, just makes a lot more sense) In what way is it not problematic? It was wrong. > > -- > Andreas Mohr Stauferstr. 6, D-71272 > Renningen, Germany >

3 3

Re: CreateProcess API - undocumented use
by Eric Pouech 01 Feb '02

01 Feb '02

> Nope. > Either you implement it (which might be useful in order to get a grasp of > what Wine is all about) or if nobody else wants to implement it, > then I'll certainly do it (should be a quick thing anyway). not that easy, if you actually implement what those parameters are for. it's not only, as I wrote, a matter of passing a bit more of info between father and child process, but to use it in child... moreover, since this covers mostly the console stuff, and since it's somehow on my todo list, I'd rather keep it so. > Raising a tempest in a teapot and then saying "let's freeze it" > won't do much good ;-) --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) The future will be better tomorrow, Vice President Dan Quayle ____________________________________________________________ Faites un voeu et puis Voila ! www.voila.fr Avec Voila Mail, consultez vos e-mails sur votre mobile Wap.

3 2

Re: treeview2.c
by Huw D M Davies 01 Feb '02

01 Feb '02

On Thu, Jan 31, 2002 at 03:40:04PM -0600, Aric Stewart wrote: > Why where we setting the items text to NULL on GetItemW. > > This appears to implement what the person was trying to do within the if > 0 block. > > Changelog: fix to GetItemW to stop whipping out the items text > > -aric > Index: dlls/comctl32/treeview.c > =================================================================== > RCS file: /home/wine/wine/dlls/comctl32/treeview.c,v > retrieving revision 1.95 > diff -u -u -r1.95 treeview.c > --- dlls/comctl32/treeview.c 2001/12/11 00:15:11 1.95 > +++ dlls/comctl32/treeview.c 2002/01/31 19:38:37 > @@ -1970,18 +1970,19 @@ ... > + MultiByteToWideChar(CP_ACP, 0, wineItem->pszText, > + strlen(wineItem->pszText), tvItem->pszText, > + tvItem->cchTextMax); Hi Aric, This won't copy the terminating '\0'. It'd be better to use -1 instead of the strlen. Huw.

2 1

Re: CreateProcess API - undocumented use
by Eric Pouech 01 Feb '02

01 Feb '02

> The file1.dat is passed as a parameter using the dwFillAttribute of the > pgm2. just for understanding, what do you actually pass in dwFillAttribute ? (I assume it's the number '1' in your example, and then pgm2 recreates the name with a template like file%lu.dat) another point, if you do what Andi suggested, then please also code what dwFillAttribute is meant for: - setting the default color attribute for a console program (dwFillAttribute is not meant for passing values between programs) A+ --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) The future will be better tomorrow, Vice President Dan Quayle ____________________________________________________________ Faites un voeu et puis Voila ! www.voila.fr Avec Voila Mail, consultez vos e-mails sur votre mobile Wap.

3 2

Bug in MoveFileEx
by Gerhard W. Gruber 01 Feb '02

01 Feb '02

I just played around with Thandor trying to install it and see what the differences are between Win98 and Wine because I noticed a slightly different behaviour. Now I discovered that MoveFileEx is not even available in Windows 98 but wine supplies it nevertheless. I suspect that the Setup doesn't check the windows version, but rather calls MoveFileEx and if that fails with not implemented returncode continues with other code to supply the functionality. I wrote a small test app to confirm this and this returns an error code when calling MoveFileEx on a native win98 whiel wine executes it. How shall I fix this? Shall I simply call GetVersion() to determine if MoveFileEx should be allowed or is there a different way with wine to determine which functions are available for which version (a global variable or such)? I looked through the sources but I couldn't find anywhere something where a versioncheck has been used to switch code but then again I don't know much functions where I know for sure that they are available in one version and not in the other. -- Bye, Gerhard If you think education is expensive, try ignorance.

4 4

CreateProcess API - undocumented use
by Ricardo 01 Feb '02

01 Feb '02

hi, I have a program that use the CreateProcess API with dwFileAttribute as a parameter. But not to use in the command line. It's used to write some data into a file and then another program read that file. But this isn't working. I'm not a programmer, I'm just testing the program. Does anybody know how can the program be changed, or wine patched, to solve this? thanks, Ricardo

3 10

Fix for MoveFileExA
by Gerhard W. Gruber 01 Feb '02

01 Feb '02

I just wrote a fix for a fixme located in MoveFileExA. Since this is the first time I'm writing something for wine I wanted to ask how I shall proceed now. Shall I simply add it into the CVS or does it have to go somewhere for revision? Also I don't want to submit it right now because my current fix is a bit ugly. The fix is applied for files that should be moved or deleted when windows boots after an application is installed. Currently there was a message telling the user that he has to delete/rename the specified files. Now I added some code that writes an entry in (WINECONFIG)/bootmove and (WINECONFIG)/bootdel when these functions are called. I also added some code in loader/main.c that checks if these files exists and if they do it will open them and deletes/renames the specified files. I hope this solution is acceptable. :) The only ugly thing about this is that the filenames for bootmove and bootdel are curerntly hardcoded where I need them. I don't know if there is a global space somewhere where I can add some fixed names so I did it this way for now, but this is not the best way in case the names should be changed or something and also I don't like hardecoded names. Another drawback of this approach is that it would be possible that more than one process is writing or reading at the same time there could be potential problems, so I'd like to hear some opinions if this is ok. -- Bye, Gerhard If you think education is expensive, try ignorance.

9 16

Re: DESTDIR support for make install
by Alexandre Julliard 01 Feb '02

01 Feb '02

Bernhard Rosenkraenzer <bero(a)redhat.de> writes: > wine currently doesn't support the DESTDIR flag commonly used by > packagers. The patch I've attached fixes this. Could you explain this a bit more? Why can't you use the existing $prefix to do the same thing? -- Alexandre Julliard julliard(a)winehq.com

4 5

Re: Pajama Sam's unmanaged window
by Ove Kaaven 01 Feb '02

01 Feb '02

On Sun, 27 Jan 2002, Ori Pessach wrote: > On Sunday 27 January 2002 11:22, Ove Kaaven wrote: > > On Sat, 26 Jan 2002, Ori Pessach wrote: > > > FALSE for those windows. Are there any other types of windows that > > > shouldn't be managed? > > > > Yes, Alexandre mentions popup menus and tooltips. Perhaps a chart could be > > made, so that it is possible to work out what conditions should be used to > > decide whether to make a window managed... > > Yep... Managed tooltips look silly. In any case, unmanaged windows behave > badly, and I don't see any reason to use unmanaged windows when Wine is > running in managed mode. > > Does anybody know how X toolkits display tooltips, popup menus, etc.? I looked at the GTK+ sources before creating that patch... for popup windows like menus and tooltips and stuff, GTK+ sets the override-redirect window attribute, which causes the window to become unmanaged. Effectively the same as Wine does. > I would think that when running managed Wine, all window should be > managed, and the distinction should be between decorationless windows > and everything else, not managed windows and everything else. > > If nobody else wants to dig into this, I'll probably take a shot at it. Go ahead.

4 10

ROTD (Rant Of The Day): patches
by Dimitrie O. Paun 01 Feb '02

01 Feb '02

Guys, I've come to _hate_ diffs attached as Application/OCTET-STREAM. Can you please, Please, PLEASE, attach them as Text/PLAIN? I use Pine over a ssh connection to read wine-{devel,patches}, and I can simply view the Text/PLAIN attachments, whereas I have to: -- press V to view the list of attachments -- select the attachment I want to view -- press S to save it to disk -- exit Pine -- start vi to actually view the thing -- restart pine... Just to view a Application/OCTET-STREAM attachment. Which means 2 things: -- I get frustrated (and look what happens when I do:)) -- I simply ignore those patches For all these reasons (and more), I think Linus is right when he insists on: -- ONE patch per email -- ONLY Text/PLAIN attachments. -- Dimi.

6 8