- Wine-devel - list.winehq.org

Re: audio.c cleanup
by Alexandre Julliard 08 Nov '01

08 Nov '01

Simon Britnell <ughbash(a)yahoo.com> writes: > This patch is based on winex cvs 1.14 and tidys up the > wodPlayer functionality to make it easier to follow. The WineX tree is not under the Wine license, so you cannot grab stuff from there. While I guess the Transgaming folks wouldn't object in this case, I'd prefer that you leave it to them to submit their patches back to the main tree, so that the license situation is clear. -- Alexandre Julliard julliard(a)winehq.com

2 1

wineshelllink
by Johan Gill 08 Nov '01

08 Nov '01

Are there any known issues with wineshelllink and KDE1 at the moment? It seems quite a few of my install programs hang when the shortcuts are about to be put in place. /Johan Gill, johane(a)lysator.liu.se

1 0

Re: Extra info in scrollbar can be an handle.
by Alexandre Julliard 08 Nov '01

08 Nov '01

Marco Bizzarri <m.bizzarri(a)icube.it> writes: > The included patch solves the problem by making an explicit GlobalLock, > and returning that value. I'm not sure this is the correct solution, so > comments are welcome. If you want to GlobalLock it, it should be allocated by GlobalAlloc. Plus the block layout will have to be compatible with what the app expects. Could you check what the app does with the memory block? Also what kind of brain-damaged app is this? -- Alexandre Julliard julliard(a)winehq.com

2 1

Two answers/questions from yesterdays and todays digests
by Robert Lunnon 08 Nov '01

08 Nov '01

Answers Now... >Message: 1 >Date: Tue, 06 Nov 2001 12:53:56 -0500 >From: Roger Fujii <rmf(a)lookhere.com> >To: wine-devel(a)winehq.com >Subject: queries on internals.... > >ok... getting reasonable output, but now I have some >questions. > >First, it seems like wine can't find the audio codecs, >though it seems to find the video ones. Is this a >to-be-implemented or a bug and any clues on where to look? Is this in Solaris ?, if so you wiould have to have OSS installed and even then I am not sure it would work properly. Investigating audio on Solaris I found that ACM was not happy unless the audio driver was available and installed properly otherwise it returns Device Busy. I do have a working Waveout Solution for native Solaris based on my libaudioio project. I've not tackled Direct Sound or Wavein yet. As yet this solution is not integrated with Wines Build environment so you can't set it up with configure. If you are prepared to grub through the relevant mods I can send you a patch kit. > Message: 1 > Date: Wed, 7 Nov 2001 20:50:11 +0100 > From: Andreas Mohr <andi(a)rhlx01.fht-esslingen.de> > To: Francois Gouget <fgouget(a)free.fr> > Cc: Martin Wilck <Martin.Wilck(a)fujitsu-siemens.com>, > wine-devel mailing list <wine-devel(a)winehq.com> > Subject: Re: [EXPERIMENTAL PATCH]: Winsock2 > Reply-To: andi(a)rhlx01.fht-esslingen.de > > On Wed, Nov 07, 2001 at 10:54:02AM -0800, Francois Gouget wrote: > > * To answer your question: > > /* Code copied largely from WSOCK32_accept() */ > > /* FIXME: Can we simply call WSOCK32_accept() instead ? */ > > /* I wasn't sure because of the AsyncSelect stuff at the end, > > which presumably should only be called if the connection is > > accepted */ > > > > Winsock2 should not call the wsock32 library. It should be the > > opposite. One of the things on my todo list (but whether I will have > > time to actually do it is another matter) is to reorganize the winsock > > libraries so that wsock32 and winsock are together in dlls/wsock32. The > > reason is that they both implement the winsock1 API except one is 16bit > > and the other 32bits. Then in dlls/winsock we would be left with just > > ws2_32 which implements the winsock2 API. So having ws2_32 call to > > wsock32 is not going in the right direction :-) > > Hmm ? > Sorry, but this directory stuff sounds rather dainbread to me. > IMHO winsock/wsock32 should be in winsock/, and ws2_32 should be in > winsock2/ Or, maybe even better, use winsock1/ instead of winsock/. > > WTH would you want to do it in a different way ? Whoever is playing with Winsock can you please ensure that the solutions you come up with are not linux centric. There is a lot of code in there that does not run on solaris because it grubs around in PROC getting TCP structures. I have made a bit of a start in cleaning this up, Here it is, absolutely untested non working code, but a start nevertheless, I put this into a separate file and link it with winsock and wsock32 from a common source, these functions replace the helper functions of similar name in the two dll subdirectories.

1 0

Re: File record locking (exclusive, nowait)
by eric pouech 08 Nov '01

08 Nov '01

"Medland, Bill" wrote: > > <<diff29.txt>> didn't you forget to add the server/fd.c file ? A+ -- --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) "The future will be better tomorrow", Vice President Dan Quayle

1 0

linking in .lib files
by Chris Dawson 08 Nov '01

08 Nov '01

Is it possible to link in .lib files using winelib and winemaker? If possible, what switch do I give winemaker? My application when compiled under Windows linked in a .lib file and I would rather not modify the source code. I've tried using the -l switch, but this is obviously only for *nix libraries even when compiling with winelib. Or, other suggestions to resolve all the undefined reference errors? Thanks in advance, Chris

3 4

[PROBLEM REPORT] Focus problem for mdi children
by Gerard Patel 08 Nov '01

08 Nov '01

Mdi child window activation is broken since ChangeSet ID: 10050857000162942344322801 CVSROOT: /opt/cvs-commit Module name: wine Changes by: julliard(a)wine2. 01/11/06 17:28:20 Modified files: dlls/ttydrv : wnd.c dlls/x11drv : winpos.c include : winpos.h windows : message.c winpos.c Log message: Window activation cleanups. The change that broke it is : --- /opt/cvs-commit/wine/dlls/x11drv/winpos.c 2001/10/22 19:08:34 1.31 +++ /opt/cvs-commit/wine/dlls/x11drv/winpos.c 2001/11/06 22:28:19 1.32 @@ -955,8 +955,7 @@ ShowCaret(winpos->hwnd); } - if (!(winpos->flags & SWP_NOACTIVATE)) - WINPOS_ChangeActiveWindow( winpos->hwnd, FALSE ); + if (!(winpos->flags & SWP_NOACTIVATE)) SetActiveWindow( winpos->hwnd ); /* And last, send the WM_WINDOWPOSCHANGED message */ Cause of the problem : the WM_CHILDACTIVATE message is not sent anymore, so the mdi children are not activated (caption does not change color, more annoyingly the active child is not set). The problem can be seen with Eudora or ForteFreeAgent. Using this patch : --- winpos.c.orig Wed Nov 7 10:41:32 2001 +++ winpos.c Thu Nov 8 00:44:29 2001 @@ -955,7 +955,20 @@ ShowCaret(winpos->hwnd); } - if (!(winpos->flags & SWP_NOACTIVATE)) SetActiveWindow( winpos->hwnd ); + if (!(winpos->flags & SWP_NOACTIVATE)) + { + SetActiveWindow( winpos->hwnd ); + if (!(wndPtr = WIN_FindWndPtr(winpos->hwnd))) return FALSE; + + /* child windows get WM_CHILDACTIVATE message */ + if( (wndPtr->dwStyle & (WS_CHILD | WS_POPUP)) == WS_CHILD ) + { + WIN_ReleaseWndPtr(wndPtr); + SendMessageA(winpos->hwnd, WM_CHILDACTIVATE, 0, 0L); + } + else + WIN_ReleaseWndPtr(wndPtr); + } /* And last, send the WM_WINDOWPOSCHANGED message */ seems to fix the problem. It may be too simple though :-) Gerard

1 0

Re: [PROBLEM REPORT] Focus problem for mdi children
by Alexandre Julliard 08 Nov '01

08 Nov '01

Gerard Patel <gerard.patel(a)nerim.net> writes: > Using this patch : > --- winpos.c.orig Wed Nov 7 10:41:32 2001 > +++ winpos.c Thu Nov 8 00:44:29 2001 > @@ -955,7 +955,20 @@ > ShowCaret(winpos->hwnd); > } > > - if (!(winpos->flags & SWP_NOACTIVATE)) SetActiveWindow( winpos->hwnd ); > + if (!(winpos->flags & SWP_NOACTIVATE)) > + { > + SetActiveWindow( winpos->hwnd ); > + if (!(wndPtr = WIN_FindWndPtr(winpos->hwnd))) return FALSE; > + > + /* child windows get WM_CHILDACTIVATE message */ > + if( (wndPtr->dwStyle & (WS_CHILD | WS_POPUP)) == WS_CHILD ) > + { > + WIN_ReleaseWndPtr(wndPtr); > + SendMessageA(winpos->hwnd, WM_CHILDACTIVATE, 0, 0L); > + } > + else > + WIN_ReleaseWndPtr(wndPtr); > + } > > /* And last, send the WM_WINDOWPOSCHANGED message */ > > > seems to fix the problem. It may be too simple though :-) No actually it's pretty much the right thing. I have applied a slightly simplified version of your patch, thanks for the report. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: RtlNtStatusToDosError issue
by Alexandre Julliard 07 Nov '01

07 Nov '01

"Bill Medland" <medbi01_1(a)accpac.com> writes: > What is the correct solution? To choose a status at random that translates > to ERROR_LOCK_VIOLATION? Yes. (but it's OK to pick one that makes some sense ;-) -- Alexandre Julliard julliard(a)winehq.com

1 0

RtlNtStatusToDosError issue
by Bill Medland 07 Nov '01

07 Nov '01

Can I solve this through documentation or do I have to use debug? I am implementing the LockFile stuff based on what Alexandre did to the CorelWine last year. Currently I have it returning error codes such as ERROR_LOCK_VIOLATION. However that causes RtlNtStatusToDosError to complain about not recognising it (no big surprise) during the server call. What is the correct solution? To choose a status at random that translates to ERROR_LOCK_VIOLATION? Bill

1 0