- Wine-devel - list.winehq.org

Re: SystemParametersInfo / GetSystemMetrics patches
by Alexandre Julliard 23 Oct '01

23 Oct '01

Andriy Palamarchuk <apa3a(a)yahoo.com> writes: > The last week I submitted a few patches, including a > couple patches for these functions. > > The patches have not been committed yet. > Is there anything wrong with them? I'm still not satisfied with the design. Having a big reload function is not a good idea IMO, you don't want to have to load all parameters on startup when most are never used. Also we need a way to make parameter changes work across multiple processes. -- Alexandre Julliard julliard(a)winehq.com

2 1

SystemParametersInfo / GetSystemMetrics patches
by Andriy Palamarchuk 23 Oct '01

23 Oct '01

The last week I submitted a few patches, including a couple patches for these functions. The patches have not been committed yet. Is there anything wrong with them? Thanks, Andriy Palamarchuk __________________________________________________ Do You Yahoo!? Make a great connection at Yahoo! Personals. http://personals.yahoo.com

1 0

Re: RPCRT4 Uuid String functions
by David Elliott 23 Oct '01

23 Oct '01

On 2001.10.21 18:34 David Elliott wrote: > This one should properly implement all of the Uuid*String[AW] functions > in > RPCRT4.DLL > > NOTE, this includes a bugfix to the existing UuidToStringA in that it > does > not allocate enough space to store the string it outputs. (it is short by > 2 > chars). > > -Dave > Noticed that Alexandre applied my NTDLL patch, but not this one. Hmm, now that I am looking at this I guess the swprintf is defined in NTDLL so I should just use that... WHOOPS, did a lot more coding than I had to. I will rework this to use the much saner method and resend the patch later tonight. Oh well, at least we got a free implementation of wcstoul out of it. :-) If I am on the wrong track here, lemme know. Originally I had thought that something like a printf function would only be declared in MSVCRT and didn't want to import that, but now that I am looking at it it seems that MSVCRT only forwards to NTDLL. Gotta get out of that UNIX mindset and into the windows one I guess. -Dave

2 3

Fix focus problem in cursor.exe
by Joshua Thielen 22 Oct '01

22 Oct '01

This patch fixes a focus problem in cursor.exe. cursor.ese handles the WM_ACTIVATE message and since it does not call DefWindowProc when messages are handled, GetFocus is not called as it normally is in DefWndProc. Since no window (or the desktop window) has the focus, PERQDATA_GetFocusWnd will return 0 and the focus will not be switched in WINPOS_SetActiveWindow. This patch fixes the behavior so that the focus will still be switched to the activated window even if the PERQDATA_GetFocusWnd returns 0. modified files: windows/winpos.c change log: Switch focus to activated window even if no window previously had the focus. Joshua Thielen thielen(a)netprince.net

1 0

Re: The big winsock patch
by Gerard Patel 22 Oct '01

22 Oct '01

At 10:52 AM 22/10/2001 -0700, you wrote: > That's my damn keyboard: nasty hardware :-) Well, if this patch makes it to the list, this version will be good enough for me. Gerard

1 0

Re: usleep in winmm/wineoss audio
by eric pouech 22 Oct '01

22 Oct '01

Simon Britnell wrote: > > For some games (HomeWorld 1.05 being the one I'm > working on), a hang occurs where the system thrashes > on an ioctl SNDCTL_GETOSPACE returning with 0 > fragments available. The symptom went away when I > turned on --debugmsg +wave, so it seems to be some > kind of race. > > I've introduced a usleep(100); before returning FALSE > when there are no fragments available. This seems to > fix the problem. > > I'm not overly happy with this solution and I'm > examining the code with an eye to using poll/select to > handle this more efficiently. Any comments? there's already a wait operation in wodPlayer, so writeFragments shouldn't do any delay there may be a race somewhere, but this is not the way to fix it. are you sure that the 0 fragment is the cause of your issues ? (and not between the sender of wavehdr and the playback thread ?) A+ -- --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) "The future will be better tomorrow", Vice President Dan Quayle

1 0

Re: Improving Wine focus handling
by Alexandre Julliard 22 Oct '01

22 Oct '01

Jukka Heinonen <jhei(a)iki.fi> writes: > - There have recently been lots of changes in directory > wine/windows/x11drv and I'm not sure whether the changes > are over yet. Definitely not over, they are only starting ;-) > - Alexandre did mention that this fix is in his todo list, > perhaps he has already planned a better way to do this fix. Yes, I'm going to work on that as part of fixing window activation for shared handles. I'm hoping to start on it this week, so you probably don't want to spend too much time on this right now. > - Mouse clicks over non-active windows should not automatically > result into focus transfer. In these cases, Windows sends a special > message that makes certain that the window really wants to gain focus. I don't think you should change X focus on mouse clicks. That is up to the window manager to decide. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: The big winsock patch
by Gerard Patel 22 Oct '01

22 Oct '01

At 12:57 AM 22/10/2001 -0700, you wrote: > Whoops. The patch was malformed but in such a way that it still >applied cleanly (thus fooling me). But a subtential part of winsock.h >was not getting patched. The best is to revert the previous patch and >apply this one. > I am recompiling in a separate tree right now. At least sock.c should >compile fine... Yes, it compiles. However : err:module:BUILTIN32_dlopen failed to load .so lib for builtin ws2_32.dll: /home/gerard/win/wine/dlls/libws2_32.so: undefined symbol: WSOCK32_gethostbyaddr err:module:PE_fixup_imports Module (file) ws2_32.dll (which is needed by wsock32.dll) not found err:module:load_library can't load wsock32.dll err:module:BUILTIN32_LoadLibraryExA loaded .so but dll wsock32.dll still not found Gerard

1 0

Re: The big winsock patch
by Gerard Patel 22 Oct '01

22 Oct '01

At 08:39 PM 21/10/2001 -0700, you (Francois Gouget) wrote: > > This patch fixes the issues listed in bug #118: gcc -c -I. -I. -I../include -I../include -g -O2 -Wall -mpreferred-stack-boundary=2 -D__WINE__ -D_REENTRANT -I/usr/X11R6/include -o sock.o sock.c In file included from ../include/winsock2.h:30, from sock.c:44: ../include/winsock.h:630:2: #endif without #if This on my stock Mandrake 8 - gcc 2.96, glibc 2.2.2 if it matters Gerard

1 0

Colour problems with latest DIB fix
by Johan Gill 21 Oct '01

21 Oct '01

Since the big DIB fix, red and blue are exchanged in some cases, for example in the install program for The Sims. This happens in both depth 16 and depth 24. /Johan Gill, johane(a)lysator.liu.se

2 2