- Wine-devel - list.winehq.org

Re: Crash in latest version
by Gerard Patel 29 Aug '01

29 Aug '01

At 10:34 PM 28/08/2001 +0200, you wrote: >Notice the change in the hwnd Windows handles are now generated on the server. This is a historical moment, btw :-) Now Wine has all the architectural features of Win 95 Not everything is implemented, FindWindow does not yet work across processes for example. But it's an important step nonetheless. Alexandre Julliard has implemented the 'generation' feature of handles. The higher part of a 32 bit handle is used for a counter that is incremented from a window creation to another, avoiding the age-old problem of windows being deleted, then braindead application trying to use their handles, using newly created windows instead. What this means is that any use of 16 bit code with window handles in Wine will break as the handles will be truncated. I already see many new crashes... The dialog code uses a 16 bit only Api (FillWindow) The following (and simplistic) patch should make your app crash a bit later. Gerard --- defdlg.c.orig Tue Aug 21 15:09:31 2001 +++ defdlg.c Wed Aug 29 00:07:28 2001 @@ -135,10 +135,18 @@ static LRESULT DEFDLG_Proc( HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam, DIALOGINFO *dlgInfo ) { + HBRUSH hbrush; switch(msg) { case WM_ERASEBKGND: - FillWindow16( hwnd, hwnd, (HDC16)wParam, (HBRUSH16)CTLCOLOR_DLG ); + hbrush = SendMessageA( hwnd, WM_CTLCOLORDLG, + wParam, (LPARAM)hwnd ); + if (hbrush ) + { + RECT r; + GetClientRect(hwnd, &r); + FillRect( (HDC) wParam, &r, hbrush ); + } return 1; case WM_NCDESTROY:

1 0

Call for Volunteers (Re: Newbie work?)
by Francois Gouget 29 Aug '01

29 Aug '01

Hi, On Tue, 28 Aug 2001, Daniel Sabo wrote: > I noticed that there was a file on > ftp://ibiblio.org/pub/Linux/ALPHA/wine/ about projects for newbie wine > developers. I also noticed that it was written in 1994. So I was wondering > if there was a more up to date version or if anyone had some ideas of > usefull work that a developer new to wine could do? Unfortunately this file does not seem very helpful. Time for another round of my Call for Volunteers it seems :-) Note that I did not get much time to update it so please send me your ideas. Also I'm thinking about starting an additional section for 'hard(er)' projects that would significantly improve Wine. Maybe it could also list projects that are already underway and for which help would be appreciated (DCOM?, STRICT handles?). But first, many thanks go to all those who fixed bugs from the previous call for volunteers and especially to Maciek Kaliszewski for his wrc fixes. What is the "Call for Volunteers"? I have built a list of projects that should be easy to tackle by new Wine developpers. The main goal is to provide the needed inspiration to potential Wine developpers that just are not motivated by the standard 'grep FIXME' answer (and I can understand them). So here goes. Easy: * PrgWin95/98: System metrics differ from the Win9x values #48: http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=48 One day I'll fix this one... I swear. Unless you want to work on it first. In that case I'll provide you with my test application and dumps of the metrics for Win95, Win98, NT4, 2000, ... * The doc about the command line arguments and the config file is out of date. See TextCP, XVideoPort and Synchronous for instance. I'm sure there are plenty of other things that are out of date. * Metabug: Test Wine with the VXCL samples #242: http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=242 Get the VXCL samples, test them with Wine and report the bugs in the bugzilla database. I know there's lots of them. Then people (or yourself) can start fixing these bugs in a distributed fashion. You can probably start reporting the most obvious bugs just by testing in Wine, but for more subtle bugs you will need two computers (or Win4Lin/VmWare) to more easily compare the behavior in Windows and in Wine. * Metabug: Test Wine with the Common Control Spy Samples #239: http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=239 Get the Common Control Spy samples and test Wine with them. You will need the native comctl32 dll but you can do the tests without rebooting between each test or using two computers. * PrgWin95: Listbox getting a recessed border instead of a flat one #56: http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=56 (I can provide you with the sample application) This one my be fixed, to check... * I think it would be nice to add a tool that displays the dlls version information like 'About' does in the windows explorer. I have some code you could use as a starting point and I think it could be merged with winver. In fact this would be almost stabdard windows programming. * Tabs are missing their inner border #243: http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=243 There's a bug in the drawing of the border of the common control tabs. Fixing each of the four instances of the code is easy. It would be interesting to find a way to factorize some of this code. Medium (I expect these would take longer or be a bit harder) * Quickbooks Pro Timer does not accept date (GetCalendarInfoA error) #276: http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=276 GetCalendarInfoA/W are not implemented yet. They involve quite a lot of internationalisation aspects, but providing a first implementation that at least handles the common cases should be feasible. * Provide a pedump utility #91: http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=91 I know there's sample code that does that already floating around so it should be relatively simple. Eric Pouech seems to be working on this. I did not check if his pedump dump the imports/exports but it probably does. * CreateIcon does not resize bitmaps #175: http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=175 I did a similar fix somewhere some time ago. I can provide a sample application and I might be able to point you in the right direction. * winemaker: 'winemaker --nomfc' does not have the intended effect #227: http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=227 * winemaker: Ignores the '--with-{mfc,wine}' options once they are cached #225: http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=225 If you're familiar with autoconf and know how configure scripts should behave... * StrokePath ignores PS_JOIN_xxx #11: http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=11 This should not be too difficult to fix but it would certainly help if you are familiar with GDI. * Checking the differences between what's in the Windows dlls and what's in our spec files... and fix the contents of our spec files as appropriate. I already have a list of all the APIs in each of the dlls for Win95, Win98, NT4 and Wine2000, plus a script that can show the differences. * Enhancing the above perl script. In particular it could be made smarter wrt. detecting whether an API is exported by ordinal or not. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Hiroshima '45 - Czernobyl '86 - Windows '95

1 0

Newbie work?
by Daniel Sabo 29 Aug '01

29 Aug '01

I noticed that there was a file on ftp://ibiblio.org/pub/Linux/ALPHA/wine/ about projects for newbie wine developers. I also noticed that it was written in 1994. So I was wondering if there was a more up to date version or if anyone had some ideas of usefull work that a developer new to wine could do? Daniel Sabo

2 1

Re: Crash in latest version
by Alexandre Julliard 29 Aug '01

29 Aug '01

Gerard Patel <gerard.patel(a)nerim.net> writes: > What this means is that any use of 16 bit code with > window handles in Wine will break as the handles > will be truncated. I already see many new crashes... Actually truncated handles should work just fine, the generation number is simply ignored if it is zero. There may theoretically be problems when we pass a truncated handle to a 32-bit app that compares it to a full 32-bit handle stored previously, but this should be fairly rare behavior. So your crashes are probably caused by something else. -- Alexandre Julliard julliard(a)winehq.com

1 0

Crash in latest version
by Uwe Bonnes 28 Aug '01

28 Aug '01

Hallo, sorry, the failure in the last mail was with an executable cvs-updated to " wine/ dlls/ttydrv/wnd.c dlls/x11drv/desktop.c ..." Bye Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Free Software: If you contribute nothing, expect nothing --

1 0

Crash in latest version
by Uwe Bonnes 28 Aug '01

28 Aug '01

Hallo, after an CVS update this evening including up to http://cvs.winehq.com/patch.py?id=999019609445169733371586 msdev.exe crashes earlier than before, when opening FILE->NEW This is from the relay log: 080681b8:CALL mfc42.2385: @(00000014,00000088,00000000) ret=5f47abec 080681b8:Call user32.CallWindowProcA(40d20259,00010052,00000014,00000088,00000000) ret=5f47a172 080681b8:Call window proc 0x4077d990 (hwnd=00010052,msg=WM_ERASEBKGND,wp=00000088,lp=00000000) 080681b8:Call window proc 0x5f47e7c0 (hwnd=00010052,msg=WM_ERASEBKGND,wp=00000088,lp=00000000) 080681b8:Ret window proc 0x5f47e7c0 (hwnd=00010052,msg=WM_ERASEBKGND,wp=00000088,lp=00000000) retval=00000000 080681b8:Call window proc 0x5f4bc820 (hwnd=00000052,msg=WM_CTLCOLORDLG,wp=00000088,lp=00000052) ^^^^^^^^ Notice the change in the hwnd. Backtrace is: =>0 0x5f4791e7 (AfxCallWndProc+0xc7(pWnd=0x0, hWnd=0x52, nMsg=0x136, wParam=0x88, lParam=0x52) [wincore.cpp:215] in D:\WINE95\SYSTEM\MFC42.DLL) (ebp=405c5110) 1 0x5f479539 (AfxWndProc+0x39(hWnd=0x52, nMsg=0x136, wParam=0x88, lParam=0x52) [wincore.cpp:368] in D:\WINE95\SYSTEM\MFC42.DLL) (ebp=405c5130) 2 0x5f4bc86a (AfxWndProcBase+0x4a(hWnd=0x52, nMsg=0x136, wParam=0x88, lParam=0x52) [afxstate.cpp:220] in D:\WINE95\SYSTEM\MFC42.DLL) (ebp=405c5160) 3 0x40793be7 (WINPROC_wrapper+0x17 in libuser32.so) (ebp=405c5184) 4 0x40793c66 (WINPROC_CallWndProc+0x76(proc=0x5f4bc820, hwnd=0x52, msg=0x136, wParam=0x88, lParam=0x52) [winproc.c:171] in libuser32.so) (ebp=405c51b0) 5 0x407999cb (CallWindowProcA+0x3b(func=0x5f4bc820, hwnd=0x52, msg=0x136, wParam=0x88, lParam=0x52) [winproc.c:2631] in libuser32.so) (ebp=405c51d8) 6 0x40733673 (call_window_proc+0xc3(hwnd=0x52, msg=0x136, wparam=0x88, lparam=0x52, unicode=0x0) [message.c:1112] in libuser32.so) (ebp=405c5224) 7 0x407342f0 (SendMessageTimeoutA+0xd0(hwnd=0x52, msg=0x136, wparam=0x88, lparam=0x52, flags=0x0, timeout=0xffffffff, res_ptr=0x405c52ac, hwnd=0x52) [message.c:1542] in libuser32.so) (ebp=405c527c) 8 0x40734469 (SendMessageA+0x39(hwnd=0x52, msg=0x136, wparam=0x88, lparam=0x52) [message.c:1587] in libuser32.so) (ebp=405c52b0) 9 0x407810b9 (PAINT_GetControlBrush+0x39(hParent=0x52, hWnd=0x52, hDC=0x88, ctlType=0x4) [painting.c:439] in libuser32.so) (ebp=405c52d8) 10 0x40781138 (PaintRect16+0x48(hwndParent=0x52, hwnd=0x52, hdc=0x88, hbrush=0x4, rect=0x405c5330) [painting.c:456] in libuser32.so) (ebp=405c52fc) 11 0x4078106b (FillWindow16+0x7b(hwndParent=0x52, hwnd=0x52, hdc=0x88, hbrush=0x4) [painting.c:430] in libuser32.so) (ebp=405c5348) 12 0x4076a3bd (DEFDLG_Proc+0xed(hwnd=0x10052, msg=0x14, wParam=0x88, lParam=0x0, dlgInfo=0x4041f91c) [defdlg.c:142] in libuser32.so) (ebp=405c536c) Bye Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Free Software: If you contribute nothing, expect nothing --

1 0

Codeweavers announces CrossOver plugin
by Marcus Meissner 28 Aug '01

28 Aug '01

Hi, Codeweavers has announced the CrossOver plugin, allowing Shockwave, Quicktime etc. to run in your favorite browser :) http://www.codeweavers.com/about/press_releases/?id=20010827.xml Ciao, Marcus

2 2

Wine in the press
by Eric Pouech 28 Aug '01

28 Aug '01

http://techupdate.zdnet.com/techupdate/stories/main/0,14179,2806411,00.html not a very good review for Wine indeed, but worth the reading this simply pinpoints what has to be fixed & enhanced A+ --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) The future will be better tomorrow, Vice President Dan Quayle __________________________________________________________ Faites un vu et puis Voila ! www.voila.fr Pendant tout l'été, gagnez une Ford Ka sur Voila Gratter ! http://cybergrattage.voila.fr/voila

1 0

Re: strange code
by Alexandre Julliard 28 Aug '01

28 Aug '01

Andreas Mohr <a.mohr(a)mailto.de> writes: > in PROFILE_LoadWineIni(), we return from processing in case we're not > the boot thread only *after* having created HKLM\\Software\\Wine\\Wine > registry keys: > > if (!CLIENT_IsBootThread()) return 1; /* already loaded */ > > Why ?? After all the registry is globally shared in > wineserver, so it shouldn't be necessary to create them again > via NtCreateKey if we're not the wine boot process. We don't need to create the keys, but we need to create the handle to the key. We could use NtOpenKey instead but NtCreateKey works just as well and avoids duplicating code. -- Alexandre Julliard julliard(a)winehq.com

1 0

strange code
by Andreas Mohr 27 Aug '01

27 Aug '01

Hi all, in PROFILE_LoadWineIni(), we return from processing in case we're not the boot thread only *after* having created HKLM\\Software\\Wine\\Wine registry keys: if (!CLIENT_IsBootThread()) return 1; /* already loaded */ Why ?? After all the registry is globally shared in wineserver, so it shouldn't be necessary to create them again via NtCreateKey if we're not the wine boot process. Am I right ? -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604 http://home.nexgo.de/andi.mohr/

1 0