Re: shell32: szFullPath is needed even for SHGFI_PIDL and SHGFI_USEFILEATTRIBUTES flags combination (bug 17633)

[Alexandre Julliard]

Petr Sumbera <Petr.Sumbera(a)Sun.COM> writes:
> dlls/shell32/shell32_main.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/dlls/shell32/shell32_main.c b/dlls/shell32/shell32_main.c
> index 78a2d57..f2f5924 100644
> --- a/dlls/shell32/shell32_main.c
> +++ b/dlls/shell32/shell32_main.c
> @@ -370,6 +370,8 @@ DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR path,DWORD dwFileAttributes,
>          {
>              lstrcpynW(szFullPath, path, MAX_PATH);
>          }
> +    } else {
> +       ILGetDisplayNameExW(NULL, (LPCITEMIDLIST)path, szFullPath, 0);

It seems to me you are just hiding the problem. If we have a pidl we
shouldn't access the path directly.

-- 
Alexandre Julliard
julliard(a)winehq.org