Re: [1/3] server: Implement job limit flags

[Alexandre Julliard]

Andrew Cook <ariscop(a)gmail.com> writes:
> +    switch (class)
> +    {
> +
> +    case JobObjectExtendedLimitInformation:
> +        if (len != sizeof(JOBOBJECT_EXTENDED_LIMIT_INFORMATION))
> +            return STATUS_INVALID_PARAMETER;
> +
> +        basic_limit = &(((JOBOBJECT_EXTENDED_LIMIT_INFORMATION *)info)->BasicLimitInformation);
> +        if (basic_limit->LimitFlags & ~JOB_OBJECT_EXTENDED_LIMIT_VALID_FLAGS)
> +            return STATUS_INVALID_PARAMETER;
> +
> +        goto set_basic_limits;
> +
> +    case JobObjectBasicLimitInformation:
> +        if (len != sizeof(JOBOBJECT_BASIC_LIMIT_INFORMATION))
> +            return STATUS_INVALID_PARAMETER;
> +
> +        basic_limit = info;
> +        if (basic_limit->LimitFlags & ~JOB_OBJECT_BASIC_LIMIT_VALID_FLAGS)
> +            return STATUS_INVALID_PARAMETER;
> +
> +    set_basic_limits:
> +        SERVER_START_REQ( set_job_limits )
> +        {
> +            req->handle = wine_server_obj_handle( handle );
> +            req->limit_flags = basic_limit->LimitFlags;
> +            status = wine_server_call( req );
> +        }
> +        SERVER_END_REQ;
> +        break;

A goto target in the middle of a switch statement is not very nice,
please try to find a better way.

-- 
Alexandre Julliard
julliard(a)winehq.org