Re: [PATCH 1/3] wininet/tests: Add some tests for InternetErrorDlg(FLAGS_ERROR_UI_FILTER_FOR_ERRORS).

[Jacek Caban]

Hi Dmitry,

On 9/1/21 4:13 PM, Dmitry Timoshkov wrote:
> @@ -1550,43 +1551,75 @@ static void test_InternetErrorDlg(void)
>           switch(i)
>           {
>           case ERROR_INTERNET_CHG_POST_IS_NON_SECURE:
> -            if (broken(res == ERROR_CANCELLED)) /* before win10 returns ERROR_CANCELLED */
> +            if (res == ERROR_CANCELLED) /* before win10 returns ERROR_CANCELLED */
> +            {

I sent v2 with those unrelated changes stripped out. I think that in 
case of those security-related functions we want to follow recent 
Windows and having stricter tests helps to ensure that.


Thanks,

Jacek