Re: [1/5] comctl32/tests: more tests for icon spacing calculation

[Daniel Jelinski]

Hello,
Thanks for reviewing. What's the preferred way of checking whether the
code is compiled for 32 or 64bit?
Regards,
Daniel

2013/1/24 Alexandre Julliard <julliard(a)winehq.org>:
> Daniel Jelinski <djelinski1(a)gmail.com> writes:
> > +#ifdef _WIN64
> > +    /* NOTE: -1 is not treated the same as (DWORD)-1 by 64bit listview */
> > +    ret = SendMessage(hwnd, LVM_SETICONSPACING, 0, (DWORD)-1);
> > +todo_wine {
> > +    expect(100, LOWORD(ret));
> > +    expect(0xFFFF, HIWORD(ret));
> > +}
> > +    ret = SendMessage(hwnd, LVM_SETICONSPACING, 0, 0xBAADF00DDEADBEEFLL);
>
> Please avoid ifdefs and long long constants.
>
> --
> Alexandre Julliard
> julliard(a)winehq.org