-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-09-23 13:52, schrieb Henri Verbeet:
I don't think the tests really support the implementation. For example, they don't test multiple swapchains at all, and they basically only test if WS_MINIMIZE is set or not as far as window styles are concerned. I'd expect at least some basic message and style tests along the lines of e.g. test_wndproc() and test_window_style(). Is the attached test what you had in mind? Mode switching is not included yet. Windows 7 and Windows Vista don't agree on the WM_WINDOWPOSCHANGING / WM_WINDOWPOSCHANGED parameters, so I'm not checking them. I can extend test_window_style as well to check for WS_VISIBLE, but I don't see a reason to do that given the messages being sent.
Wrt multiple swapchains, since we don't have any tests and support for multi-head or CreateAdditionalSwapchain in fullscreen mode that'd be a rather huge detour I'd prefer not to take. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUIewwAAoJEN0/YqbEcdMwsZIP/2hTwfUuPLSKSoC8MQ4dtEju /awDAyXOtKLwYl1FzyTYr8yugqXpPiJk0PEuId2HppVHVnbhVhH16eOt+iCPDpOy J+9rzt08OaGEPp5tVpqExI7aqbMdb+sxNApqi1rRwzmLyl6fmSFJuNj8LRmu2hTR EuIrTSqOVZwXKVXOZJ7OdeYG6Vm7TefLT8AAIqeI6FmPcnwBg350nXa13V01OYlO tzsGzQSK3IPA/urL6BVZea6Yuh4++mIq5/CFsTwfxXqjbnFKy+nUvtt4F7icJpe2 YgHb02C6eVm3vvwyatO/gfxqAjMhF3AoUo2bVnbLA55bM45H7EjDlBm6xAZuIevE 4qCl/Rdk9dMNTjI8e/s5PjGkJpJgn+LvWFFJBG6AmE5zJqGKswRhMjwLPP8WdVEl mUNtG3QutggqWfK3h2IXtA27GhUR8z8yi8oxLt4l/Oh2X18iTD1BjXNkFPJrKnIL Tr7eafhMW5R0GwNDfA9ImKMS4IIkWylhrIcIKhuDKpGUz3j5QqQ+TkHOwPob6xez kx+5B/9fRqVcepbEpfw7UHxcbW4P3l4Q/kkP02cRSETAKetO8vn17jA8GMzGfdGV mURE0QLciZ/d4/4kkjwv/fvLjilaW+qWi5FVgSWhOFg3ay2jrLadmCFQfnOmgmfG 0QEZ+3dkS2TAqb+MyCN+ =jmOV -----END PGP SIGNATURE-----