On 11/16/05, Raphael <fenix(a)club-internet.fr> wrote:
Changelog: - semi implementation of advpack APIs LaunchINFSection/LaunchINFSectionEx - semi implementation of advpack API ExtractFiles - setupapi: correct and check pExtractFiles return code
I appreciate your work on advpack, but some comments that might help get it accepted more easily: * separate the patch into as many independent chunks as you can. It seems like each function you implement can be sent in separate and linearly. * it would help to add test cases wherever you can even if it's just to check how the function handles parameters.
+ if (!bRet) {
+ ERR("Failed to CopyFileW(%s, %s)\n", debugstr_w(src), debugstr_w(dst));
+ }
The rest of the file uses standard C indentation, so it's best to stick with that: if (x) { } but seeing as how it's just a one liner, if (!bRet) ERR("..."); -- James Hawkins