-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-01-17 12:29, schrieb Alistair Leslie-Hughes:
The code in dpnet is already inconsistent with 2/4 space indents within each file. Don't know exactly how to clean that up. The usual way is to pick a new style you and whoever else is working on the code like and write all new code in the new style. Leave old lines alone until you touch them for some other reason.
Personally I recommend the style we're using in wined3d, see e.g. dlls/wined3d/cs.c for a file that is "pure". As far as I can see that matches the style in wineserver, except for /* wined3d */ if (foo) a(); else b(); vs /* wineserver */ if (foo) a(); else b(); But in the end its up to you if you intend to do more work on dplay. My personal opinion is that we should unify the entire code once with an automated tool and bite the bullet wrt this breaking git blame. IMO we have more problems with contributors not finding their way around the style requirements than the inconvenience this will cause with git blame for a while. But this is just my opinion, not the Wine project's. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS2ShgAAoJEN0/YqbEcdMwJKkP/0v81UxcEcF02LT3DHs59OCT NDRDosNu3dwJdUxgLKrLCbjk7wb11oFmfi+VIp1KqN2JMYf/Bqw4PtFSjiBcJmC6 v4oNZC7DckFrg4uNLT9y0u7gxV6UpkMKfssTg+CNUbenGXso+QepYSTUNnvgUQcv vQEKZvCvf3gZ1R7zrPeVv72yjZAUALILYItK8TWP0vCOFK2diyH34Ig2Cjqhfmvw 6lwyCYhcPcVXTwwnNhUWDgJMiBI8R3gsqRvWj+nBOlBmdjVXmM/a+frTiM8L96Xm vzKC9zOhMi8ebA7nP+5uKiQSkDaBSpFFJ/ieb5HqUnaVSbLKmuVjNkqeKgmYVpnn swvr0OCLVV/qZdKMszNNogAFCn8ryYpkjUOePfdUsQHIHmVECEeew0K6yIIDsiqg e/wmw+BVFcen05E/BgoR6vpGC5hSgreOhsSqFoO/L/XjYkwDa6SyIqQSqRQ+PQ8K uJd+GeSfMLPgGW1e0eMqP2ra+5KwzEyCnKLe5/vR0JVIR8JkcCKHWVYsByIlP7/k vIKT/OlifMsQgrVS9uZuqynnG08n7oFpN6wJOPvLAm72XBlc4KrE30IC3yyO1CJ5 5Ab+j77VXzOwpTBa2ZzgC/eatfWFtQKJ6YYnjTyJb926mDptwEprtH8uHnYC1I8N ILE7fME8f48aAno2Iskz =Hb5J -----END PGP SIGNATURE-----