Re: [PATCH 3/4] vbscript: Implement persistent named items.

[Jacek Caban]

Hi Gabriel,


On 19/03/2020 15:07, Gabriel Ivăncescu wrote:
> +    LIST_FOR_EACH_ENTRY(item, &This->ctx->named_items, named_item_t, entry)
> +    {
> +        if(!item->disp)
> +        {
> +            hres = retrieve_named_item_disp(pass, item);
> +            if(FAILED(hres))
> +            {
> +                This->ctx->script_obj->ctx = NULL;
> +                IDispatchEx_Release(&This->ctx->script_obj->IDispatchEx_iface);
> +                return hres;

This would also need to set ctx->script_obj to NULL in error case. I'd 
suggest to simply move the loop before create_script_disp() call instead.


Thanks,

Jacek