Re: [PATCH 03/17] shell32/autocomplete: Handle heap_alloc failure and avoid a potential buffer overflow

[Huw Davies]

On 6 Sep 2018, at 16:43, Gabriel Ivăncescu <gabrielopcode(a)gmail.com> wrote:
> On Thu, Sep 6, 2018 at 6:28 PM, Huw Davies <huw.davies(a)physics.ox.ac.uk> wrote:
> > I suggest we do the sprintf ourselves.  All we'd need to do
> > is replace the first occurrence of '%s' with the appropriate
> > string.  We can ignore width/precision specifiers for now
> > unless we find that an app actually depends on them.
>
> You mean you want the code itself to replace the %s with the string
> without using sprintf? But then %12s wouldn't work, though I don't
> think it's really useful... but if you're really fine with that I'll
> go and do it.

Yes, as I said, we can always add '%12s' support if we find something
that needs it.

Huw.