Re: [PATCH] conhost: Respect the StartupInfo's wShowWindow.

[Dmitry Timoshkov]

Gabriel Ivăncescu <gabrielopcode(a)gmail.com> wrote:
> > > -        ShowWindow( console.win, SW_SHOW );
> > > +        ShowWindow( console.win, (si.dwFlags & STARTF_USESHOWWINDOW) && si.wShowWindow != SW_SHOWDEFAULT
> > > +                                 ? si.wShowWindow : SW_SHOW );
> >
> > What's the reason to treat SW_SHOWDEFAULT specially?
>
> I initially tried just setting it to SW_SHOWDEFAULT without any checks, 
> and it didn't work. I was assuming the SW_SHOW was there for a reason in 
> such case, as the "default". I'm not that familiar with how this works, 
> so of course I can remove it if it's actually unnecessary.

If there's no real reason then please remove it.

-- 
Dmitry.