Re: [PATCH vkd3d 2/6] vkd3d-shader: Write empty SM1 shaders.

[Henri Verbeet]

On Wed, 14 Apr 2021 at 07:03, Zebediah Figura <zfigura(a)codeweavers.com> wrote:
> +typedef enum _D3DSHADER_INSTRUCTION_OPCODE_TYPE
> +{
> +    D3DSIO_NOP          =  0,
> +    D3DSIO_MOV          =  1,
> +    D3DSIO_ADD          =  2,
> ...
> +    D3DSIO_SETP         = 94,
> +    D3DSIO_TEXLDL       = 95,
> +    D3DSIO_BREAKP       = 96,
> +
> Hexadecimal constants, please.
> +struct bytecode_buffer
> +{
> +    DWORD *data;
> +    size_t count, size;
> +    int status;
> +};
> +
> We have some instances of DWORD in vkd3d-shader, but the preferred
> type for 32-bit unsigned integers is uint32_t.