Re: [PATCH v2 1/2] secur32: Fix race between schan_(Encrypt|Decrypt)Message

[Jacek Caban]

Hi Anton,

On 14.09.2017 18:30, Anton Romanov wrote:
> ctx->req_ctx_attr = fContextReq;
>
> -    transport.ctx = ctx;
> -    init_schan_buffers(&transport.in, pInput, schan_init_sec_ctx_get_next_input_buffer);
> -    transport.in.limit = expected_size;
> -    init_schan_buffers(&transport.out, pOutput, schan_init_sec_ctx_get_next_output_buffer);
> -    schan_imp_set_session_transport(ctx->session, &transport);
> +    ctx->transport.ctx = ctx;

One last thing, please move this line closer to
schan_imp_create_session, where it belongs. transport.ctx should be set
once, during context creation, and not touched later. Other than that,
the patch looks good.


Thanks,

Jacek