The new name makes it clearer that _IsAddOnBad() returns true (the error message) if the addon is bad and false otherwise. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/lib/Build/Utils.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/testbot/lib/Build/Utils.pm b/testbot/lib/Build/Utils.pm index 7d0739e5bd..17addeede8 100644 --- a/testbot/lib/Build/Utils.pm +++ b/testbot/lib/Build/Utils.pm @@ -360,7 +360,7 @@ sub BuildWine($$$$;$) # Wine addons updates # -sub _VerifyAddOn($$) +sub _IsAddOnBad($$) { my ($AddOn, $Arch) = @_; @@ -395,7 +395,7 @@ sub _UpdateAddOn($$$) $AddOn->{filename} = "wine-$Name-$AddOn->{version}". ($Arch eq "" ? "" : "-$Arch") .".msi"; - return 1 if (!_VerifyAddOn($AddOn, $Arch)); + return 1 if (!_IsAddOnBad($AddOn, $Arch)); InfoMsg "Downloading $AddOn->{filename}\n"; mkdir "$DataDir/$Name"; @@ -407,7 +407,7 @@ sub _UpdateAddOn($$$) "wget --no-verbose -O- '$Url' >'$AddOn->{filename}'"); last if ($? == 0); } - my $ErrMessage = _VerifyAddOn($AddOn, $Arch); + my $ErrMessage = _IsAddOnBad($AddOn, $Arch); return 1 if (!defined $ErrMessage); LogMsg "$ErrMessage\n"; return 0; -- 2.20.1