2016-04-25 22:17 GMT-06:00 Nikolay Sivov <bunglehead(a)gmail.com>:
On 26.04.2016 6:09, Alex Henrie wrote:
Cc: Andrew Eikum <aeikum(a)codeweavers.com>
Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- dlls/qedit/Makefile.in | 3 +- dlls/qedit/qedit_private.h | 2 + dlls/qedit/tests/timeline.c | 3 - dlls/qedit/timeline.c | 10 +- dlls/qedit/timelineobj.c | 470 ++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 482 insertions(+), 6 deletions(-) create mode 100644 dlls/qedit/timelineobj.c
I think it's better to add this to timeline.c.
I'm not sure it's a good idea to shove everything into one file. Andrew, what do you think?
+ + TRACE("(%d,%p)\n", type, ppv); + + switch (type) + { + case TIMELINE_MAJOR_TYPE_COMPOSITE: + case TIMELINE_MAJOR_TYPE_TRACK: + case TIMELINE_MAJOR_TYPE_SOURCE: + case TIMELINE_MAJOR_TYPE_TRANSITION: + case TIMELINE_MAJOR_TYPE_EFFECT: + case TIMELINE_MAJOR_TYPE_GROUP: + break; + default: + return E_INVALIDARG; + }
What happens to returned pointer on type error?
Nothing, but I'll add a test for this and resubmit. I will also make the rest of the changes to this patch that you suggested. -Alex